Kyösti Mälkki (kyosti.malkki@gmail.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/1198
-gerrit
commit 891ea785344ce58984beb1653e248f9a163b4613 Author: Kyösti Mälkki kyosti.malkki@gmail.com Date: Tue Jul 10 10:17:32 2012 +0300
Drop start_cpu_lock
Function alloc_find_dev() is serialized.
Change-Id: I40d27d1adca629f1f7ce2f09c1cb2fd04b76eb9a Signed-off-by: Kyösti Mälkki kyosti.malkki@gmail.com --- src/arch/x86/lib/cpu.c | 10 ---------- 1 files changed, 0 insertions(+), 10 deletions(-)
diff --git a/src/arch/x86/lib/cpu.c b/src/arch/x86/lib/cpu.c index 2d64be9..5214abe 100644 --- a/src/arch/x86/lib/cpu.c +++ b/src/arch/x86/lib/cpu.c @@ -235,10 +235,6 @@ static void set_cpu_ops(struct device *cpu) cpu->ops = driver ? driver->ops : NULL; }
-#if CONFIG_SMP -static spinlock_t start_cpu_lock = SPIN_LOCK_UNLOCKED; -#endif - void cpu_initialize(struct bus *cpu_bus, int index) { /* Because we busy wait at the printk spinlock. @@ -255,13 +251,7 @@ void cpu_initialize(struct bus *cpu_bus, int index) cpu_path.apic.apic_id = id; cpu_path.apic.index = index;
-#if CONFIG_SMP - spin_lock(&start_cpu_lock); -#endif cpu = alloc_find_dev(cpu_bus, &cpu_path); -#if CONFIG_SMP - spin_unlock(&start_cpu_lock); -#endif printk(BIOS_DEBUG, "Initializing CPU #%d\n", id);
/* Find what type of cpu we are dealing with */