(Hm, this message seems to not have made it through. Resending...)
Hi all,
I've just recently brought my development environment up to speed with the latest coreboot version -- which is very nice! -- and caught a couple of minor issues. I'm not sure I fully understand the underlying logic behind the different CAR setup routines in src/cpu/amd/car/cache_as_ram.inc, but the attached patch is required to make the S2912 board choose the correct code path. I've also upped the MAX_CPUS setting to 12 to accommodate 6-core Istanbul CPUs. This might make sense for other fam10 boards as well.
Signed-off-by: Arne Georg Gleditsch arne.gleditsch@numascale.com
Am 05.03.2010 17:53, schrieb Arne Georg Gleditsch:
Signed-off-by: Arne Georg Gleditsch arne.gleditsch@numascale.com
Acked-by: Patrick Georgi patrick.georgi@coresystems.de
and committed as r5197
The "real" fix would be to eliminate the uses of these config options (they're useless since we dropped newconfig), but this is a good indicator on how to handle the AMD code when cleaning it up.
Thanks, Patrick