[PATCH] Enable compatible mod on SIL3114

[Rudolf Marek]

Hello,

Following patch reprograms SIL3114 into PCI IDE native mode compatible class 
code allowing legacy software to recognize it as IDE and boot from it. I think
this should be the default for two Tyan boards (k8s and what Ward has).

Ward, please test again if it works for you this way.

Thanks,
Rudolf

[Stefan Reinauer]

On 5/16/10 10:59 AM, Rudolf Marek wrote:
> Index: src/drivers/si/3114/Makefile.inc
>
> --- src/drivers/si/3114/Makefile.inc	(revision 0)
> +++ src/drivers/si/3114/Makefile.inc	(revision 0)
> @@ -0,0 +1 @@
> +driver-$(CONFIG_DRIVERS_SI) += si_sata.o

CONFIG_DRIVERS_SI (one I)
> Index: src/mainboard/tyan/s2881/Kconfig
>
> --- src/mainboard/tyan/s2881/Kconfig	(revision 5555)
> +++ src/mainboard/tyan/s2881/Kconfig	(working copy)
> @@ -13,6 +13,7 @@
>    select HAVE_MP_TABLE
>    select BOARD_ROMSIZE_KB_512
>    select SB_HT_CHAIN_UNITID_OFFSET_ONLY
> select DRIVERS_SII

CONFIG_DRIVERS_SII (two I)

Where I think it should be DRIVERS_SI_3114

[Rudolf Marek]

Hi,

Thanks for the review. Whoops right. Messed the selects up.

But I vote for DRIVERS_SII because we can add all other SATA SIL because they 
are all compatible.

Rudolf

[Stefan Reinauer]

On 5/16/10 12:20 PM, Rudolf Marek wrote:
> Hi,
>
> Thanks for the review. Whoops right. Messed the selects up.
>
> But I vote for DRIVERS_SII because we can add all other SATA SIL
> because they are all compatible.

why "SII" not "SIL" then? just asking... is that the name of the "group
of devices"?

maybe we should rename the directory, then so that it's easier for
people to match the option with the directory?

Anyways, it helps solve the issue, so it should go in...
Acked-by: Stefan Reinauer

Stefan

[Rudolf Marek]

Well,

Linux  has sata_sil and former was sata_sii. I think SIL is more right. It is a 
shortcut for SilliconImage. But the dir name is already SI...

I admit this is a mess, maybe rename it to DRIVERS_SI then?

Thanks,
Rudolf

[Carl-Daniel Hailfinger]

On 16.05.2010 13:28, Stefan Reinauer wrote:
> On 5/16/10 12:20 PM, Rudolf Marek wrote:
> > But I vote for DRIVERS_SII because we can add all other SATA SIL
> > because they are all compatible.
>
> why "SII" not "SIL" then? just asking... is that the name of the "group
> of devices"?

AFAIK someone from Silicon Image sent a mail to the Linux kernel mailing
list some time ago and explained that SiI (uppercase S, lowercase i,
uppercase I) was the preferred spelling/capitalization, but sii and SII
were OK as well. The SIL variant was caused by people who mistook the
last letter (uppercase I) for a lowercase l and then changed
capitalization of the misread word to all-uppercase or all-lowercase.

However, it seems that even inside Silicon Image some people use SIL,
but they seem to be in the minority.
The following (unrelated to the device the mail was about) PDF uses a
font where uppercase I and lowercase l look different:
http://www.siliconimage.com/docs/SiI%201169PB%20FINAL.pdf

Regards,
Carl-Daniel