Alec Ari (neotheuser@ymail.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/166
-gerrit
commit d402be72762f60d4b60edf5662d31a14eccb03ec Author: Alec Ari neotheuser@ymail.com Date: Sun Aug 21 21:52:41 2011 -0500
Fix up various dsdt.asl files
Change-Id: I46eb27847deb3a903ac9af347992a9954e50ff6e Signed-off-by: Alec Ari neotheuser@ymail.com --- src/mainboard/asus/m4a78-em/dsdt.asl | 4 ++-- src/mainboard/asus/m4a785-m/dsdt.asl | 4 ++-- src/mainboard/gigabyte/ma785gmt/dsdt.asl | 2 +- 3 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/mainboard/asus/m4a78-em/dsdt.asl b/src/mainboard/asus/m4a78-em/dsdt.asl index 3170a0b..7c28398 100644 --- a/src/mainboard/asus/m4a78-em/dsdt.asl +++ b/src/mainboard/asus/m4a78-em/dsdt.asl @@ -22,8 +22,8 @@ DefinitionBlock ( "DSDT.AML", /* Output filename */ "DSDT", /* Signature */ 0x02, /* DSDT Revision, needs to be 2 for 64bit */ - "AMD ", /* OEMID */ - "TILAPIA ", /* TABLE ID */ + "ASUS ", /* OEMID */ + "M4A78-EM ", /* TABLE ID */ 0x00010001 /* OEM Revision */ ) { /* Start of ASL file */ diff --git a/src/mainboard/asus/m4a785-m/dsdt.asl b/src/mainboard/asus/m4a785-m/dsdt.asl index 3170a0b..34ddd3a 100644 --- a/src/mainboard/asus/m4a785-m/dsdt.asl +++ b/src/mainboard/asus/m4a785-m/dsdt.asl @@ -22,8 +22,8 @@ DefinitionBlock ( "DSDT.AML", /* Output filename */ "DSDT", /* Signature */ 0x02, /* DSDT Revision, needs to be 2 for 64bit */ - "AMD ", /* OEMID */ - "TILAPIA ", /* TABLE ID */ + "ASUS ", /* OEMID */ + "M4A785-M ", /* TABLE ID */ 0x00010001 /* OEM Revision */ ) { /* Start of ASL file */ diff --git a/src/mainboard/gigabyte/ma785gmt/dsdt.asl b/src/mainboard/gigabyte/ma785gmt/dsdt.asl index 608513d..fdd3a3e 100644 --- a/src/mainboard/gigabyte/ma785gmt/dsdt.asl +++ b/src/mainboard/gigabyte/ma785gmt/dsdt.asl @@ -23,7 +23,7 @@ DefinitionBlock ( "DSDT", /* Signature */ 0x02, /* DSDT Revision, needs to be 2 for 64bit */ "GIGA ", /* OEMID */ - "GA785GMT", /* TABLE ID */ + "MA785GMT-UD2H", /* TABLE ID */ 0x00010001 /* OEM Revision */ ) { /* Start of ASL file */
Am Montag, den 22.08.2011, 04:55 +0200 schrieb Alec Ari:
Alec Ari (neotheuser@ymail.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/166
-gerrit
commit d402be72762f60d4b60edf5662d31a14eccb03ec Author: Alec Ari neotheuser@ymail.com Date: Sun Aug 21 21:52:41 2011 -0500
Fix up various dsdt.asl files
Fix up copy and pasted IDs in various dstd.asl files
describes the change more accurately.
Did you run test any of these boards? (Just for the record and not needed for this patch.)
It would be nice if you could update those with `git commit --amend`.
Change-Id: I46eb27847deb3a903ac9af347992a9954e50ff6e Signed-off-by: Alec Ari <neotheuser@ymail.com>
Acked-by: Paul Menzel paulepanter@users.sourceforge.net
[…]
Thanks,
Paul
On 8/22/11 1:37 AM, Paul Menzel wrote:
Am Montag, den 22.08.2011, 04:55 +0200 schrieb Alec Ari:
Alec Ari (neotheuser@ymail.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/166
-gerrit
commit d402be72762f60d4b60edf5662d31a14eccb03ec Author: Alec Arineotheuser@ymail.com Date: Sun Aug 21 21:52:41 2011 -0500
Fix up various dsdt.asl files
Fix up copy and pasted IDs in various dstd.asl files
Maybe we should use generic IDs in those files and not the board names. I think we do that on most boards.