#65: Unify SuperIO code? ----------------------------------+----------------------------------------- Reporter: stepan | Owner: uwe Type: enhancement | Status: closed Priority: major | Milestone: Cosmetic fixes Component: coreboot | Resolution: fixed Keywords: | Dependencies: Patch Status: there is no patch | ----------------------------------+----------------------------------------- Changes (by stepan):
* status: new => closed * resolution: => fixed
Comment:
As original reporter of the "issue" I am closing it now, since there is no clear description or issue that could be fixed in order to ever "succeed" in the goal of reducing code duplication. Also, what might seem like wasteful code duplication is sometimes two different pieces of hardware that happen to behave the same way without any systematic reason. Two chips might seem exactly the same, but need very different workarounds, and moving the distinction from the device tree model into the code just moves complexity, and in addition and much worse, the required testing overhead significantly.
So, if you recognize evil code duplication, it should be fixed. At all cost? No. Only if it makes sense.
-
coreboot