[PATCH]es: Use CBFS on amd/serengeti_cheetah and iwill/dk8_htx

[Patrick Georgi]

Hi,

the attached patches can serve as an example on how to port boards that make 
use of our "failover"-infrastructure to CBFS.

1. Set FALLBACK_SIZE to ROM_IMAGE_SIZE

2. Set ROM_IMAGE_SIZE so that
FAILOVER_SIZE + ROM_IMAGE_SIZE = XIP_ROM_SIZE
to avoid problems with XIP.

3. Enable CONFIG_CBFS (of course)

4. Drop
ldscript /arch/i386/init/ldscript_apc.lb
from the board's Config.lb - coreboot_apc is in CBFS now.

5. Drop most size definitions in targets/*/*/Config*lb except
ROM_SIZE (if it differs from the board's default) and the size configuration 
of the failover image.

The patches are
Signed-off-by: Patrick Georgi 
and are build tested.
serengeti_cheetah survived in simnow, so it's boot tested.

Regards,
Patrick

[ron minnich]

Acked-by: Ronald G. Minnich

[PATCH]es: Use CBFS on amd/serengeti_cheetah and iwill/dk8_htx

[Carl-Daniel Hailfinger]

Hi Patrick,

On 06.06.2009 15:14, Patrick Georgi wrote:
> "failover"-infrastructure to CBFS.
> Set ROM_IMAGE_SIZE so that
>
> FAILOVER_SIZE + ROM_IMAGE_SIZE = XIP_ROM_SIZE
> to avoid problems with XIP.

Actually, this is a big problem for me. Which XIP_ROM_SIZE setting is
honored? The one in src/mainboard/$VENDOR/$BOARD/Config.lb or the one in
src/mainboard/$VENDOR/$BOARD/Options.lb or the one in
targets/$VENDOR/$BOARD/Config.lb or targets/$VENDOR/$BOARD/Config-abuild.lb?

I have a script which does all conversions except ROM_IMAGE_SIZE. Once
my question above is answered, I should be able to fix my script and
post it.
What bothers me is that my script changed more in the iwill/dk8_htx case
than your patch.

Regards,
Carl-Daniel

[PATCH]es: Use CBFS on amd/serengeti_cheetah and iwill/dk8_htx

[Patrick Georgi]

Am 07.06.2009 15:10, schrieb Carl-Daniel Hailfinger:
> Hi Patrick,
>
> On 06.06.2009 15:14, Patrick Georgi wrote:
> > "failover"-infrastructure to CBFS.
> > Set ROM_IMAGE_SIZE so that
> >
> > FAILOVER_SIZE + ROM_IMAGE_SIZE = XIP_ROM_SIZE
> > to avoid problems with XIP.
>
> Actually, this is a big problem for me. Which XIP_ROM_SIZE setting is
> honored? The one in src/mainboard/$VENDOR/$BOARD/Config.lb or the one in
> src/mainboard/$VENDOR/$BOARD/Options.lb or the one in
> targets/$VENDOR/$BOARD/Config.lb or targets/$VENDOR/$BOARD/Config-abuild.lb?

Whatever is effective ;-) (helpful, I know)

In my opinion targets/*/*/Config*lb shouldn't define any XIP_* values 
except for failover (and maybe not even that)
And in src/mainboard, it should also only be in one of the files, to not 
confuse users. (again imho)
> I have a script which does all conversions except ROM_IMAGE_SIZE. Once
> my question above is answered, I should be able to fix my script and
> post it.
> What bothers me is that my script changed more in the iwill/dk8_htx case
> than your patch.

I wrote the instructions from looking at the patches and not the other 
way around, so the "canonical" solution might be different. But there's 
more than one valid way to do it. As long as it builds, it's a step in 
the right direction, in my opinion. There will be more changes to make 
the rom layout more space efficient etc, that should simplify and 
disambiguate things.

I'm on vacation the next week and thus offline.

Regards,
Patrick