Re: [coreboot] Change in coreboot[master]: Inagua: Synchronize AMD/inagua mainboard.

[Marc Jones]

On Fri, Jan 20, 2012 at 9:45 AM, Wolfgang Kamp - datakamp
 wrote:
> Hello Marc,
>
> I reviewed the code and it looks good.
> But real testing shows an issue with soft restart (UBUNTU).
> The southbridge seems to hang. Coreboot stops because it could not read the SPI ROM of DIMM Module.
> Please see logs.
> The cold start log also reports errors but will successful boot Ubuntu.
>
> Regards
>
> Wolfgang

Woflgang,

The ASSERTs in the passing case are non-critical failures for early
heap use. These are AGESA bugs and have been reported to AMD, but they
are not critical.

As you said, The bad failure is this one:

EventLog:	EventClass = 7, EventInfo = 4011c00.
    Param1 = 0, Param2 = 0.
    Param3 = 0, Param4 = 0.

Which is the SPD problem...
#define MEM_ERROR_NO_DIMM_FOUND_ON_SYSTEM 0x04011C00    ///< No DIMMs
have been found

Can you check what happens in AmdMemoryReadSPD(), in dimmSpd.c? Does
it check the correct dimm address? Is the i2c io address set
correctly?

Thanks,
Marc
> -----Ursprüngliche Nachricht-----
> Von: gerrit code review [mailto:[e-mail]]
> Gesendet: Freitag, 20. Januar 2012 00:52
> An: Wolfgang Kamp - datakamp
> Cc: Kerry Sheh
> Betreff: Change in coreboot[master]: Inagua: Synchronize AMD/inagua mainboard.
>
> From Marc Jones :
>
> Hello Wolfgang Kamp,
>
> I'd like you to do a code review.  Please visit
>
> http://review.coreboot.org/542
>
> to review the following change.
>
> Change subject: Inagua: Synchronize AMD/inagua mainboard.
> .....................................................................
>
> Inagua: Synchronize AMD/inagua mainboard.
>
> AMD/persimmon mainboard code is derived from AMD/inagua mainbard.
> Persimmom update a lot in the last few month, sync these modification to inagua.
>
> Change-Id: Ia038e5a2b9550fe81bb075f31e30b98354758e9e
> Signed-off-by: Kerry Sheh 
> Signed-off-by: Kerry Sheh
>
> M src/mainboard/amd/inagua/BiosCallOuts.c
> M src/mainboard/amd/inagua/BiosCallOuts.h
> M src/mainboard/amd/inagua/Kconfig
> M src/mainboard/amd/inagua/Makefile.inc
> M src/mainboard/amd/inagua/OptionsIds.h
> M src/mainboard/amd/inagua/PlatformGnbPcie.c
> D src/mainboard/amd/inagua/acpi/ssdt2.asl
> D src/mainboard/amd/inagua/acpi/ssdt3.asl
> D src/mainboard/amd/inagua/acpi/ssdt4.asl
> D src/mainboard/amd/inagua/acpi/ssdt5.asl
> M src/mainboard/amd/inagua/acpi_tables.c
> M src/mainboard/amd/inagua/agesawrapper.c
> M src/mainboard/amd/inagua/agesawrapper.h
> M src/mainboard/amd/inagua/buildOpts.c
> M src/mainboard/amd/inagua/devicetree.cb
> M src/mainboard/amd/inagua/dimmSpd.c
> M src/mainboard/amd/inagua/dsdt.asl
> M src/mainboard/amd/inagua/fadt.c
> M src/mainboard/amd/inagua/get_bus_conf.c
> M src/mainboard/amd/inagua/irq_tables.c
> M src/mainboard/amd/inagua/mainboard.c
> M src/mainboard/amd/inagua/mptable.c
> M src/mainboard/amd/inagua/platform_cfg.h
> M src/mainboard/amd/inagua/romstage.c
> 24 files changed, 249 insertions(+), 717 deletions(-)
> git pull ssh://review.coreboot.org:29418/coreboot refs/changes/42/542/2
>
> To view, visit http://review.coreboot.org/542
> To unsubscribe, visit http://review.coreboot.org/settings
>
> Gerrit-MessageType: newchange
> Gerrit-Change-Id: Ia038e5a2b9550fe81bb075f31e30b98354758e9e
> Gerrit-PatchSet: 2
> Gerrit-Project: coreboot
> Gerrit-Branch: master
> Gerrit-Owner: Kerry Sheh 
> Gerrit-Reviewer: Kerry Sheh 
> Gerrit-Reviewer: Wolfgang Kamp 
> Gerrit-Reviewer: build bot (Jenkins)