Re: [coreboot] AMD Family 15h and 16h: ASSERTION ERROR

[Marshall Dawson]

Hey Paul,

I don't have either of these two systems, and have only quickly scanned the
Kabini AGESA source.

But if I had to make a guess, I believe the GetDmiInfoMain() likely has a
problem with its return value.  Look at how it returns Flag, but the
function starts by setting Flag=TRUE.  Since Flag is an AGESA_STATUS and
gets downgraded as necessary, it should've been initialized with
AGESA_SUCCESS instead.  The same idea applies to GetType4Type7Info() too.

It's not immediately apparent to me where the apu2 board picks up its
buildOpts, but most systems are configured for BUILDOPT_REMOVE_CDIT TRUE.
I seem to recall CDIT causing an error to be returned if the option wasn't
removed (as in imb-a180/buildOpts.c).

Thanks,
Marshall

On Mon, Apr 16, 2018 at 1:50 AM, Paul Menzel <
[e-mail]> wrote:
> Dear coreboot folks,
>
> Looking through the board status uploads, the AMD Family 15h and 16h
> uploads contain lines with *ASSERTION ERROR*. For example:
> asrock/imb-a180/4.6-812-g4a1d450/2017-07-22T05_25_01Z/coreboot_console.txt:ASSERTION
>
> ERROR: file 'src/vendorcode/amd/agesa/f16kb/Proc/CPU/cpuGeneralServices.c',
> line 779
> pcengines/apu2/4.6-1904-ga547e40/2017-10-26T06_40_33Z/coreboot_console.txt:ASSERTION
>
> ERROR: file 'src/northbridge/amd/pi/agesawrapper.c', line 279
>
> Has somebody analyzed those yet?
>
> Kind regards,
>
> Paul