[PATCH] flashrom: Always verify erase and write

[Uwe Hermann]

See patch.

I cannot think of any situation where we would not want to verify, and
verifying always will help many users to properly detect misflashes.

The patch is not tested on hardware (yet), might need a bit of tweaking.

If this goes in the -v option will stay for

(a) backwards compatibility

(b) manual verifying via 'flashrom -v file.bin' (vs. -wv directly)

Uwe.

[Carl-Daniel Hailfinger]

On 28.05.2009 14:36, Uwe Hermann wrote:
> See patch.
>
> I cannot think of any situation where we would not want to verify, and
> verifying always will help many users to properly detect misflashes.
>
> The patch is not tested on hardware (yet), might need a bit of tweaking.
>
> If this goes in the -v option will stay for
>
> (a) backwards compatibility
>
> (b) manual verifying via 'flashrom -v file.bin' (vs. -wv directly)

Can you please introduce a no-verify switch?

Regards,
Carl-Daniel

[Peter Stuge]

Uwe Hermann wrote:
> /* Always verify write and erase operations. */
> if (write_it || erase_it)
> verify_it = 1;

This doesn't work as one might expect at least for erase.

Erase has always verified since a good while back, it is handled by
the code orchestrating the erase in flashrom.c.

I agree it's good to also verify writes unconditionally!

//Peter