[PATCH]flashrom fix for M50FW080

I verified this is now working.

Signed-off-by: Joseph Smith

[root@localhost ~]# flashrom -r test.rom
Calibrating delay loop... OK.
Found coreboot table at 0x00000530.
Vendor ID: RCA, part ID: RM4100
Found chipset "Intel ICH4/ICH4-L", enabling flash write... OK.
NOT FOUND RCA:RM4100
M50FW080 found at physical address 0xfff00000.
Flash part is M50FW080 (1024 KB).
Reading Flash...done
[root@localhost ~]# flashrom -v test.rom
Calibrating delay loop... OK.
Found coreboot table at 0x00000530.
Vendor ID: RCA, part ID: RM4100
Found chipset "Intel ICH4/ICH4-L", enabling flash write... OK.
NOT FOUND RCA:RM4100
M50FW080 found at physical address 0xfff00000.
Flash part is M50FW080 (1024 KB).
Verifying flash... VERIFIED.
[root@localhost ~]# flashrom -E
Calibrating delay loop... OK.
Found coreboot table at 0x00000530.
Vendor ID: RCA, part ID: RM4100
Found chipset "Intel ICH4/ICH4-L", enabling flash write... OK.
NOT FOUND RCA:RM4100
M50FW080 found at physical address 0xfff00000.
Flash part is M50FW080 (1024 KB).
Erasing flash chip
total_size is 1048576; flash->page_size is 65536
DONE BLOCK 0x0
DONE BLOCK 0x10000
DONE BLOCK 0x20000
DONE BLOCK 0x30000
DONE BLOCK 0x40000
DONE BLOCK 0x50000
DONE BLOCK 0x60000
DONE BLOCK 0x70000
DONE BLOCK 0x80000
DONE BLOCK 0x90000
DONE BLOCK 0xa0000
DONE BLOCK 0xb0000
DONE BLOCK 0xc0000
DONE BLOCK 0xd0000
DONE BLOCK 0xe0000
DONE BLOCK 0xf0000
DONE ERASE
[root@localhost ~]# flashrom -wv test.rom
Calibrating delay loop... OK.
Found coreboot table at 0x00000530.
Vendor ID: RCA, part ID: RM4100
Found chipset "Intel ICH4/ICH4-L", enabling flash write... OK.
NOT FOUND RCA:RM4100
M50FW080 found at physical address 0xfff00000.
Flash part is M50FW080 (1024 KB).
total_size is 1048576; flash->page_size is 65536
DONE BLOCK 0x0
DONE BLOCK 0x10000
DONE BLOCK 0x20000
DONE BLOCK 0x30000
DONE BLOCK 0x40000
DONE BLOCK 0x50000
DONE BLOCK 0x60000
DONE BLOCK 0x70000
DONE BLOCK 0x80000
DONE BLOCK 0x90000
DONE BLOCK 0xa0000
DONE BLOCK 0xb0000
DONE BLOCK 0xc0000
DONE BLOCK 0xd0000
DONE BLOCK 0xe0000
DONE BLOCK 0xf0000
DONE ERASE
Programming page: 0015 at address: 0x000f0000
Verifying flash... VERIFIED.
[root@localhost ~]#

Thanks - Joe

[PATCH]flashrom fix for M50FW080 ACK?

Quoting [e-mail]:
> I verified this is now working.
>
> Signed-off-by: Joseph Smith
>
> [root@localhost ~]# flashrom -r test.rom
> Calibrating delay loop... OK.
> Found coreboot table at 0x00000530.
> Vendor ID: RCA, part ID: RM4100
> Found chipset "Intel ICH4/ICH4-L", enabling flash write... OK.
> NOT FOUND RCA:RM4100
> M50FW080 found at physical address 0xfff00000.
> Flash part is M50FW080 (1024 KB).
> Reading Flash...done
> [root@localhost ~]# flashrom -v test.rom
> Calibrating delay loop... OK.
> Found coreboot table at 0x00000530.
> Vendor ID: RCA, part ID: RM4100
> Found chipset "Intel ICH4/ICH4-L", enabling flash write... OK.
> NOT FOUND RCA:RM4100
> M50FW080 found at physical address 0xfff00000.
> Flash part is M50FW080 (1024 KB).
> Verifying flash... VERIFIED.
> [root@localhost ~]# flashrom -E
> Calibrating delay loop... OK.
> Found coreboot table at 0x00000530.
> Vendor ID: RCA, part ID: RM4100
> Found chipset "Intel ICH4/ICH4-L", enabling flash write... OK.
> NOT FOUND RCA:RM4100
> M50FW080 found at physical address 0xfff00000.
> Flash part is M50FW080 (1024 KB).
> Erasing flash chip
> total_size is 1048576; flash->page_size is 65536
> DONE BLOCK 0x0
> DONE BLOCK 0x10000
> DONE BLOCK 0x20000
> DONE BLOCK 0x30000
> DONE BLOCK 0x40000
> DONE BLOCK 0x50000
> DONE BLOCK 0x60000
> DONE BLOCK 0x70000
> DONE BLOCK 0x80000
> DONE BLOCK 0x90000
> DONE BLOCK 0xa0000
> DONE BLOCK 0xb0000
> DONE BLOCK 0xc0000
> DONE BLOCK 0xd0000
> DONE BLOCK 0xe0000
> DONE BLOCK 0xf0000
> DONE ERASE
> [root@localhost ~]# flashrom -wv test.rom
> Calibrating delay loop... OK.
> Found coreboot table at 0x00000530.
> Vendor ID: RCA, part ID: RM4100
> Found chipset "Intel ICH4/ICH4-L", enabling flash write... OK.
> NOT FOUND RCA:RM4100
> M50FW080 found at physical address 0xfff00000.
> Flash part is M50FW080 (1024 KB).
> total_size is 1048576; flash->page_size is 65536
> DONE BLOCK 0x0
> DONE BLOCK 0x10000
> DONE BLOCK 0x20000
> DONE BLOCK 0x30000
> DONE BLOCK 0x40000
> DONE BLOCK 0x50000
> DONE BLOCK 0x60000
> DONE BLOCK 0x70000
> DONE BLOCK 0x80000
> DONE BLOCK 0x90000
> DONE BLOCK 0xa0000
> DONE BLOCK 0xb0000
> DONE BLOCK 0xc0000
> DONE BLOCK 0xd0000
> DONE BLOCK 0xe0000
> DONE BLOCK 0xf0000
> DONE ERASE
> Programming page: 0015 at address: 0x000f0000
> Verifying flash... VERIFIED.
> [root@localhost ~]#
>
> Thanks - Joe

Thanks - Joe

[Peter Stuge]

On Fri, Mar 14, 2008 at 11:49:07AM -0400, [e-mail] wrote:
> I verified this is now working.
>
> Signed-off-by: Joseph Smith
> Index: flashrom/flashchips.c
>
> --- flashrom/flashchips.c	(revision 3143)
> +++ flashrom/flashchips.c	(working copy)
> @@ -165,7 +165,7 @@
>    {"M50FLW080B",	ST_ID,		ST_M50FLW080B,	1024,	64 * 1024,
>     probe_jedec,	erase_chip_jedec,	write_jedec},
>    {"M50FW080",	ST_ID,		ST_M50FW080,	1024,	64 * 1024,
> probe_jedec,	erase_chip_jedec,	write_jedec},
> probe_82802ab,	erase_82802ab,		write_82802ab},
> {"M50FW016",	ST_ID,		ST_M50FW016,	2048,	64 * 1024,
>   probe_jedec,	erase_chip_jedec,	write_jedec},
>  {"M50LPW116",	ST_ID,		ST_M50LPW116,	2048,	64 * 1024,

And why is this needed for M50FW080 but not others in the same
family?

//Peter

[Carl-Daniel Hailfinger]

On 14.03.2008 19:55, Peter Stuge wrote:
> On Fri, Mar 14, 2008 at 11:49:07AM -0400, [e-mail] wrote:
> > I verified this is now working.
> >
> > Signed-off-by: Joseph Smith
> > Index: flashrom/flashchips.c
> >
> > --- flashrom/flashchips.c	(revision 3143)
> > +++ flashrom/flashchips.c	(working copy)
> > @@ -165,7 +165,7 @@
> >    {"M50FLW080B",	ST_ID,		ST_M50FLW080B,	1024,	64 * 1024,
> >     probe_jedec,	erase_chip_jedec,	write_jedec},
> >    {"M50FW080",	ST_ID,		ST_M50FW080,	1024,	64 * 1024,
> > probe_jedec,	erase_chip_jedec,	write_jedec},
> > probe_82802ab,	erase_82802ab,		write_82802ab},
> > {"M50FW016",	ST_ID,		ST_M50FW016,	2048,	64 * 1024,
> >   probe_jedec,	erase_chip_jedec,	write_jedec},
> >  {"M50LPW116",	ST_ID,		ST_M50LPW116,	2048,	64 * 1024,
>
> And why is this needed for M50FW080 but not others in the same
> family?

To be honest, it is probably needed for all of them, but I don't have
the time to read all data sheets nor do I have the hardware. We really
need that "supported" flag in flashrom.

Regards,
Carl-Daniel

Quoting Peter Stuge :
> On Fri, Mar 14, 2008 at 11:49:07AM -0400, [e-mail] wrote:
> > I verified this is now working.
> >
> > Signed-off-by: Joseph Smith
> > Index: flashrom/flashchips.c
> >
> > --- flashrom/flashchips.c	(revision 3143)
> > +++ flashrom/flashchips.c	(working copy)
> > @@ -165,7 +165,7 @@
> >    {"M50FLW080B",	ST_ID,		ST_M50FLW080B,	1024,	64 * 1024,
> >     probe_jedec,	erase_chip_jedec,	write_jedec},
> >    {"M50FW080",	ST_ID,		ST_M50FW080,	1024,	64 * 1024,
> > probe_jedec,	erase_chip_jedec,	write_jedec},
> > probe_82802ab,	erase_82802ab,		write_82802ab},
> > {"M50FW016",	ST_ID,		ST_M50FW016,	2048,	64 * 1024,
> >   probe_jedec,	erase_chip_jedec,	write_jedec},
> >  {"M50LPW116",	ST_ID,		ST_M50LPW116,	2048,	64 * 1024,
>
> And why is this needed for M50FW080 but not others in the same
> family?

It could, but I have no way to test them.....call out to anyone with  
these other chips in the same family to test them.

Thanks - Joe

[Carl-Daniel Hailfinger]

On 14.03.2008 16:49, [e-mail] wrote:
> I verified this is now working.
>
> Signed-off-by: Joseph Smith

That's really relieving! It pays to put a lot of effort into solving
flash problems.

Acked-by: Carl-Daniel Hailfinger

Regards,
Carl-Daniel

[Uwe Hermann]

On Fri, Mar 14, 2008 at 09:03:50PM +0100, Carl-Daniel Hailfinger wrote:
> On 14.03.2008 16:49, [e-mail] wrote:
> > I verified this is now working.
> >
> > Signed-off-by: Joseph Smith
>
> That's really relieving! It pays to put a lot of effort into solving
> flash problems.
>
> Acked-by: Carl-Daniel Hailfinger

This is r3145.

Uwe.