Hi,
i just found that 32 bit PCI Accesses thru ports 0xCF8/0xCFC will not work in YABEL. This fixes it:
Signed-off-by: Pattrick Hueper phueper@hueper.net --- util/x86emu/yabel/io.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/util/x86emu/yabel/io.c b/util/x86emu/yabel/io.c index a69e5e6..6f481a7 100644 --- a/util/x86emu/yabel/io.c +++ b/util/x86emu/yabel/io.c @@ -348,7 +348,7 @@ u32 pci_cfg_read(X86EMU_pioAddr addr, u8 size) { u32 rval = 0xFFFFFFFF; - if ((addr >= 0xCFC) && ((addr + size) <= 0xCFF)) { + if ((addr >= 0xCFC) && ((addr + size) <= 0xD00)) { // PCI Configuration Mechanism 1 step 1 // write to 0xCF8, sets bus, device, function and Config Space offset // later read from 0xCFC-0xCFF returns the value... @@ -404,7 +404,7 @@ pci_cfg_read(X86EMU_pioAddr addr, u8 size) void pci_cfg_write(X86EMU_pioAddr addr, u32 val, u8 size) { - if ((addr >= 0xCFC) && ((addr + size) <= 0xCFF)) { + if ((addr >= 0xCFC) && ((addr + size) <= 0xD00)) { // PCI Configuration Mechanism 1 step 1 // write to 0xCF8, sets bus, device, function and Config Space offset // later write to 0xCFC-0xCFF sets the value... -- 1.6.1.2
On 04.03.2009 23:09, Pattrick Hueper wrote:
Hi,
i just found that 32 bit PCI Accesses thru ports 0xCF8/0xCFC will not work in YABEL. This fixes it:
Signed-off-by: Pattrick Hueper phueper@hueper.net
Acked-by: Carl-Daniel Hailfinger c-d.hailfinger.devel.2006@gmx.net
Do you have commit privileges?
Regards, Carl-Daniel
Carl-Daniel Hailfinger wrote:
i just found that 32 bit PCI Accesses thru ports 0xCF8/0xCFC will not work in YABEL. This fixes it:
Signed-off-by: Pattrick Hueper phueper@hueper.net
Acked-by: Carl-Daniel Hailfinger c-d.hailfinger.devel.2006@gmx.net
This is r1144. Please remember to note the commit rev in the patch thread, it is very helpful since we are managing all patches on the mailing list.
Or you can use trac of course. :)
//Peter
uups... sorry, i did reply to Carl-Daniels Ack with the revision.... but only to Carl-Daniel, sorry!
Pattrick
On Fri, Mar 6, 2009 at 9:31 PM, Peter Stuge peter@stuge.se wrote:
Carl-Daniel Hailfinger wrote:
i just found that 32 bit PCI Accesses thru ports 0xCF8/0xCFC will not work in YABEL. This fixes it:
Signed-off-by: Pattrick Hueper phueper@hueper.net
Acked-by: Carl-Daniel Hailfinger c-d.hailfinger.devel.2006@gmx.net
This is r1144. Please remember to note the commit rev in the patch thread, it is very helpful since we are managing all patches on the mailing list.
Or you can use trac of course. :)
//Peter
-- coreboot mailing list: coreboot@coreboot.org http://www.coreboot.org/mailman/listinfo/coreboot
Pattrick Hueper wrote:
uups... sorry, i did reply to Carl-Daniels Ack with the revision.... but only to Carl-Daniel, sorry!
Too bad Gmail doesn't have list-reply. Try nagging them about it maybe.
//Peter