[PATCH] v2 i945 updates

[Stefan Reinauer]

See patch

[Peter Stuge]

Hi,

Stefan Reinauer wrote:
> i945 northbridge update
> lots of PCIe updates
> various bug fixes to early init
> some fixes for typos and warnings
> initial support for PCIe x16
> some minor fixes to memory init code
> some subsystem vendor id patches, to be consistent with ICH7
>
> Signed-off-by: Stefan Reinauer

Here is a plea:

Please PLEEASE do not include whitespace fixes in other patches!!

That requires THREE or FOUR times the effort for every review - and
the result is that less people will bother to look at the code!

It is a waste of reviewer time.

How to easily check it? My suggestion is to always read every svn
diff output before sending.

Acked-by: Peter Stuge

[Stefan Reinauer]

> Hi,
>
> Stefan Reinauer wrote:
> > i945 northbridge update
> > lots of PCIe updates
> > various bug fixes to early init
> > some fixes for typos and warnings
> > initial support for PCIe x16
> > some minor fixes to memory init code
> > some subsystem vendor id patches, to be consistent with ICH7
> >
> > Signed-off-by: Stefan Reinauer
>
> Here is a plea:
>
> Please PLEEASE do not include whitespace fixes in other patches!!
>
> That requires THREE or FOUR times the effort for every review - and
> the result is that less people will bother to look at the code!
>
> It is a waste of reviewer time.

Big sorry for that. early_init.c is a bit of a special case for me here,
and I'm still practising to get it right.

I'll try to do better the next time.
> Acked-by: Peter Stuge

Thanks. r3997

[Peter Stuge]

Stefan Reinauer wrote:
> > Please PLEEASE do not include whitespace fixes in other patches!!
> >
> > That requires THREE or FOUR times the effort for every review - and
> > the result is that less people will bother to look at the code!
>
> Big sorry for that. early_init.c is a bit of a special case for me
> here, and I'm still practising to get it right.

Okey!
> I'll try to do better the next time.

Awesome. The important thing to take away is not that I get upset
at whitespace changes, but that review quality suffers tremendously.

My mind becomes saturated so much more quickly when scrutinizing a
bunch of lines that didn't really change, compared to same number of
lines where there are actual changes.

//Peter

[Patrick Georgi]

Am 11.03.2009 17:15, schrieb Peter Stuge:
> How to easily check it? My suggestion is to always read every svn
> diff output before sending.

svn diff -x -w helps, too

Regards,
Patrick

[Peter Stuge]

Patrick Georgi wrote:
> Am 11.03.2009 17:15, schrieb Peter Stuge:
> > How to easily check it? My suggestion is to always read every svn
> > diff output before sending.
>
> svn diff -x -w helps, too

Yes! I think if the actual commit has extra whitespace changes
compared to the reviewed patch it is much better than if they
are part of the review material.

//Peter