See patch.
Uwe.
On 11/26/10 2:28 PM, Uwe Hermann wrote:
See patch.
Uwe.
Since it's amd specific (in a sense that it's not much benefit and only used on amd based boards), we should move it to cpu/amd/acpi or cpu/amd/amdk8/acpi?
Stefan
Stefan Reinauer wrote:
On 11/26/10 2:28 PM, Uwe Hermann wrote:
See patch.
Uwe.
Since it's amd specific (in a sense that it's not much benefit and only used on amd based boards), we should move it to cpu/amd/acpi or cpu/amd/amdk8/acpi?
It doesn't look amd-specific though. At the very least the STA_* definitions in statdef.asl look useful. globutil.asl and debug.asl are not specific to amd at all. And the debugging primitives are probably quite useful for more complicated acpi code.
On Sat, Nov 27, 2010 at 10:18:01AM +0100, Tobias Diedrich wrote:
Since it's amd specific (in a sense that it's not much benefit and only used on amd based boards), we should move it to cpu/amd/acpi or cpu/amd/amdk8/acpi?
It doesn't look amd-specific though. At the very least the STA_* definitions in statdef.asl look useful. globutil.asl and debug.asl are not specific to amd at all. And the debugging primitives are probably quite useful for more complicated acpi code.
Yup, those files are not AMD-specific and are potentially reusable by other chipsets, keeping them outside of amd/ dirs makes sense IMHO.
Uwe.
On 06.12.2010, at 14:16, Uwe Hermann uwe@hermann-uwe.de wrote:
On Sat, Nov 27, 2010 at 10:18:01AM +0100, Tobias Diedrich wrote:
Since it's amd specific (in a sense that it's not much benefit and only used on amd based boards), we should move it to cpu/amd/acpi or cpu/amd/amdk8/acpi?
It doesn't look amd-specific though. At the very least the STA_* definitions in statdef.asl look useful. globutil.asl and debug.asl are not specific to amd at all. And the debugging primitives are probably quite useful for more complicated acpi code.
Yup, those files are not AMD-specific and are potentially reusable by other chipsets, keeping them outside of amd/ dirs makes sense IMHO.
Alright
Acked-by: Stefan Reinauer stepan@coreboot.org
Uwe.
http://hermann-uwe.de | http://sigrok.org http://randomprojects.org | http://unmaintained-free-software.org
-- coreboot mailing list: coreboot@coreboot.org http://www.coreboot.org/mailman/listinfo/coreboot
On Wed, Dec 08, 2010 at 10:02:17AM -0800, Stefan Reinauer wrote:
Acked-by: Stefan Reinauer stepan@coreboot.org
Thanks, r6156.
Uwe.
-
Stefan Reinauer -
Tobias Diedrich -
Uwe Hermann