[PATCH] Gigabyte MA785GMT support

[Qing Pei Wang]

hi,
  the attach file added the support of Gigabyte MA785GMT mainboard.
the details of the hardware configuration can be found at
http://www.gigabyte.com/products/product-page.aspx?pid=3478
a breif configuration is:
1. CPU:Support for AM3 processors: AMD PhenomTM II processor/ AMD Athlon™ II
processor
2. North Bridge: AMD 785G
3. South Bridge: AMD SB710
4: Super IO : ITE8718F

The mainboard has two bios flashchip. Coreboot ROM should be flashed into
the M_BIOS(which means main bios).
signed-off-by Wang Qing Pei

[Paul Menzel]

Dear Wang,

Am Freitag, den 13.08.2010, 15:50 +0800 schrieb Qing Pei Wang:
> the attach file added the support of Gigabyte MA785GMT mainboard.

thank you. These are great news.
> the details of the hardware configuration can be found at
> http://www.gigabyte.com/products/product-page.aspx?pid=3478 
> a breif configuration is:

s/breif/brief/
> CPU:Support for AM3 processors: AMD PhenomTM II processor/ AMD
>
> Athlon™ II processor
> 2. North Bridge: AMD 785G
> 3. South Bridge: AMD SB710 
> 4: Super IO : ITE8718F
>
> The mainboard has two bios flashchip. Coreboot ROM should be flashed

flashchip*s*
> into the M_BIOS(which means main bios).

1. Did you set up a Wiki page for this board where you describe what is
working and what is not?
2. Could you also mention in the commit message if there are any missing
pieces, please.
3. What payloads and GNU/Linux distribution did you test the system
with?
4. Could you attach the logs please.
5. Could you compare the system running coreboot with the proprietary
BIOS.
> signed-off-by Wang Qing Pei

I think »:« is needed after S-o-b. But I do not know the commit script.

Thanks,

Paul

[Qing Pei Wang]

hi Paul，
  i think the wiki page should be add after the code in checked in. I did
not compare coreboot with
proprietary BIOS. Actually, i do not know how to compare them.
It's an public mainboad, anyone who has this board can do these things.
The payload which i use is FILO. But i would like to try Seabios later.
Thanks for your kindly suggestion. the log will be attached soon.
On Fri, Aug 13, 2010 at 4:54 PM, Paul Menzel <
[e-mail]> wrote:
> Dear Wang,
>
> Am Freitag, den 13.08.2010, 15:50 +0800 schrieb Qing Pei Wang:
> > the attach file added the support of Gigabyte MA785GMT mainboard.
>
> thank you. These are great news.
> > the details of the hardware configuration can be found at
> > http://www.gigabyte.com/products/product-page.aspx?pid=3478
> > a breif configuration is:
>
> s/breif/brief/
> > CPU:Support for AM3 processors: AMD PhenomTM II processor/ AMD
> >
> > Athlon™ II processor
> > 2. North Bridge: AMD 785G
> > 3. South Bridge: AMD SB710
> > 4: Super IO : ITE8718F
> >
> > The mainboard has two bios flashchip. Coreboot ROM should be flashed
>
> flashchip*s*
> > into the M_BIOS(which means main bios).
> Did you set up a Wiki page for this board where you describe what is
>
> working and what is not?
> 2. Could you also mention in the commit message if there are any missing
> pieces, please.
> 3. What payloads and GNU/Linux distribution did you test the system
> with?
> 4. Could you attach the logs please.
> 5. Could you compare the system running coreboot with the proprietary
> BIOS.
> > signed-off-by Wang Qing Pei
>
> I think »:« is needed after S-o-b. But I do not know the commit script.
>
> Thanks,
>
> Paul

[Paul Menzel]

Dear Wang,

Am Freitag, den 13.08.2010, 17:50 +0800 schrieb Qing Pei Wang:
> i think the wiki page should be add after the code in checked in.

fair enough.
> I did not compare coreboot with
> proprietary BIOS. Actually, i do not know how to compare them.

I thought about working things (ports, ACPI, audio, USB, SATA, …) and
boot speed, i. e., time until FILO appears under coreboot and time until
bootloader (GRUB ?) appears under proprietary BIOS. Maybe you could also
run some kind of benchmark.
> It's an public mainboad, anyone who has this board can do these
> things.

Well, this information would be good for people thinking about buying a
board supported by coreboot. Until now, you are the only person I know
having this board with coreboot running on it.
> The payload which i use is FILO. But i would like to try Seabios
> later.
> Thanks for your kindly suggestion. the log will be attached soon.

Great!

Thank you,

Paul

[Niels Ole Salscheider]

Hello,
> > It's an public mainboad, anyone who has this board can do these
> > things.
>
> Well, this information would be good for people thinking about buying a
> board supported by coreboot. Until now, you are the only person I know
> having this board with coreboot running on it.

I have a GA-MA785GT-UD3H - since both boards seem to be quite similar it 
should not be too difficult to get my board working. I might give it a try in 
about two weeks when I have some time.

Did you use the dual bios feature for development or do I need a hardware 
modification?

Regards,

Ole

[Qing Pei Wang]

hi Niels
  In my eyes, you can flash the M_BIOS with coreboot. It should not need any
hardware modification.
Although i did some of them, but they are just used to let me find out the
problems of dual bios things

On Fri, Aug 13, 2010 at 6:40 PM, Niels Ole Salscheider <
[e-mail]> wrote:
> Hello,
> > > It's an public mainboad, anyone who has this board can do these
> > > things.
> >
> > Well, this information would be good for people thinking about buying a
> > board supported by coreboot. Until now, you are the only person I know
> > having this board with coreboot running on it.
>
> I have a GA-MA785GT-UD3H - since both boards seem to be quite similar it
> should not be too difficult to get my board working. I might give it a try
> in
> about two weeks when I have some time.
>
> Did you use the dual bios feature for development or do I need a hardware
> modification?
>
> Regards,
>
> Ole

[Ward Vandewege]

Hi Niels,

On Sat, Aug 14, 2010 at 01:38:26AM +0800, Qing Pei Wang wrote:
> In my eyes, you can flash the M_BIOS with coreboot. It should not need any
> hardware modification.
> Although i did some of them, but they are just used to let me find out the
> problems of dual bios things

Qing Pei is right, no hardware modification necessary. I started a page on
the MA785GMT-UD2H that explains how to recover from an unbootable M_BIOS, by
using the B_BIOS feature. It boils down to shorting pins 4 (GND) and 7
(#HOLD) on the M_BIOS chip for a few seconds on cold boot, and then releasing
the short.

See

http://www.coreboot.org/GIGABYTE_GA-MA785GMT-UD2H

Thanks,
Ward.

[Ward Vandewege]

On Fri, Aug 13, 2010 at 03:50:45PM +0800, Qing Pei Wang wrote:
> the attach file added the support of Gigabyte MA785GMT mainboard.
> the details of the hardware configuration can be found at
> http://www.gigabyte.com/products/product-page.aspx?pid=3478
> a breif configuration is:
> CPU:Support for AM3 processors: AMD PhenomTM II processor/ AMD Athlon™ II
>
> processor
> 2. North Bridge: AMD 785G
> 3. South Bridge: AMD SB710
> 4: Super IO : ITE8718F
>
> The mainboard has two bios flashchip. Coreboot ROM should be flashed into
> the M_BIOS(which means main bios).
> signed-off-by Wang Qing Pei

Thank you! I have a few of these boards arriving next week and will be
testing this.

Thanks!
Ward.

[Stefan Reinauer]

On 8/13/10 9:50 AM, Qing Pei Wang wrote:
> hi,
>   the attach file added the support of Gigabyte MA785GMT mainboard.
> the details of the hardware configuration can be found at
> http://www.gigabyte.com/products/product-page.aspx?pid=3478
> a breif configuration is:
> CPU:Support for AM3 processors: AMD PhenomTM II processor/ AMD
>
> Athlon™ II processor
> 2. North Bridge: AMD 785G
> 3. South Bridge: AMD SB710
> 4: Super IO : ITE8718F
>
> The mainboard has two bios flashchip. Coreboot ROM should be flashed
> into the M_BIOS(which means main bios).
> signed-off-by Wang Qing Pei <[e-mail]
> >

Hi Qing Pei!

Thanks for this patch! It's great to have more boards in the tree.
> --- src/mainboard/gigabyte/ma785gmt/mb_sysconf.h        (revision 0)
> +++ src/mainboard/gigabyte/ma785gmt/mb_sysconf.h        (revision 0)

..
> +#ifndef MB_SYSCONF_H
>
> +#define MB_SYSCONF_H
>
> +struct mb_sysconf_t {
>   u8 bus_isa;
>   u8 bus_8132_0;
>   u8 bus_8132_1;
>   u8 bus_8132_2;
>   u8 bus_8111_0;
>   u8 bus_8111_1;
>   u8 bus_8132a[31][3];
>   u8 bus_8151[31][2];
>   u32 apicid_8111;
>   u32 apicid_8132_1;
>   u32 apicid_8132_2;
>   u32 apicid_8132a[31][2];
>   u32 sbdn3;
>   u32 sbdn3a[31];
>   u32 sbdn5[31];
>   u32 bus_type[256];
>
> +};
>
> +#endif

Can you check if this file is really needed?

I would expect that anything that references AMD8132, AMD8111 and
AMD8151 is not needed on an AMD785/SB710 board?

Also, a lot of files in the patch are exact copies of the AMD Tilapia
board. I counted 15 files where the only change from Tilapia is the
following:
> @@ -1,7 +1,7 @@
>  /*
> This file is part of the coreboot project.
> Copyright (C) 2010 Advanced Micro Devices, Inc.
> Copyright (C) 2010 Wang Qing Pei
> This program is free software; you can redistribute it and/or modify
> it under the terms of the GNU General Public License as published by

Some more change the name from AMD Tilapia to Gigabyte GA785GMT in
addition to that.

Those files should keep the AMD copyright in there I believe. The ones
that you didn't change should not have your copyright added.

I think with above issues adressed we could commit this patch.

Thanks,

Stefan

[Qing Pei Wang]

hi stepan,
  thanks for your kindly help about the code reviewing. I did a new patch
which followed by your suggestion.
the new patch also added the function to avoid RS780 PCI emulation problems.
I also attached the log which booting SUSE 11.2 with coreboot. The payload
is Seabios.

On Sun, Aug 15, 2010 at 7:51 PM, Stefan Reinauer <
[e-mail]> wrote:
> On 8/13/10 9:50 AM, Qing Pei Wang wrote:
>
> hi,
>   the attach file added the support of Gigabyte MA785GMT mainboard.
> the details of the hardware configuration can be found at
> http://www.gigabyte.com/products/product-page.aspx?pid=3478
> a breif configuration is:
> CPU:Support for AM3 processors: AMD PhenomTM II processor/ AMD Athlon™
>
> II processor
> 2. North Bridge: AMD 785G
> 3. South Bridge: AMD SB710
> 4: Super IO : ITE8718F
>
> The mainboard has two bios flashchip. Coreboot ROM should be flashed into
> the M_BIOS(which means main bios).
> signed-off-by Wang Qing Pei
>
> Hi Qing Pei!
>
> Thanks for this patch! It's great to have more boards in the tree.
>
> --- src/mainboard/gigabyte/ma785gmt/mb_sysconf.h        (revision 0)
> +++ src/mainboard/gigabyte/ma785gmt/mb_sysconf.h        (revision 0)
>
> ..
>
> +#ifndef MB_SYSCONF_H
>
> +#define MB_SYSCONF_H
>
> +struct mb_sysconf_t {
>   u8 bus_isa;
>   u8 bus_8132_0;
>   u8 bus_8132_1;
>   u8 bus_8132_2;
>   u8 bus_8111_0;
>   u8 bus_8111_1;
>   u8 bus_8132a[31][3];
>   u8 bus_8151[31][2];
>   u32 apicid_8111;
>   u32 apicid_8132_1;
>   u32 apicid_8132_2;
>   u32 apicid_8132a[31][2];
>   u32 sbdn3;
>   u32 sbdn3a[31];
>   u32 sbdn5[31];
>   u32 bus_type[256];
>
> +};
>
> +#endif
>
> Can you check if this file is really needed?
>
> I would expect that anything that references AMD8132, AMD8111 and AMD8151
> is not needed on an AMD785/SB710 board?
>
> Also, a lot of files in the patch are exact copies of the AMD Tilapia
> board. I counted 15 files where the only change from Tilapia is the
> following:
>
> @@ -1,7 +1,7 @@
>  /*
> This file is part of the coreboot project.
> Copyright (C) 2010 Advanced Micro Devices, Inc.
> Copyright (C) 2010 Wang Qing Pei
> This program is free software; you can redistribute it and/or modify
> it under the terms of the GNU General Public License as published by
>
> Some more change the name from AMD Tilapia to Gigabyte GA785GMT in addition
> to that.
>
> Those files should keep the AMD copyright in there I believe. The ones that
> you didn't change should not have your copyright added.
>
> I think with above issues adressed we could commit this patch.
>
> Thanks,
>
> Stefan

[Torsten Duwe]

On Sunday 15 August 2010, Stefan Reinauer wrote:
> On 8/13/10 9:50 AM, Qing Pei Wang wrote:
> > hi,
> >
> > the attach file added the support of Gigabyte MA785GMT mainboard.
> >
> > the details of the hardware configuration can be found at
> > http://www.gigabyte.com/products/product-page.aspx?pid=3478
> Thanks for this patch! It's great to have more boards in the tree.

Yes indeed, thanks!

Gigabyte's website mentions 4 board revisions: 1.0, 1.1, 1.3 and 3.3; the 
user's manual suggests there's PCBs with varying features, from GA-MA785GMT-
US2H to GA-MA785GPMT-UD2H. Which of these could be supported by your patch?

Torsten

[Qing Pei Wang]

my board revision is 1.1. Not sure the others can be supported.

On Tue, Aug 17, 2010 at 4:19 PM, Torsten Duwe  wrote:
> On Sunday 15 August 2010, Stefan Reinauer wrote:
> > On 8/13/10 9:50 AM, Qing Pei Wang wrote:
> > > hi,
> > >
> > > the attach file added the support of Gigabyte MA785GMT mainboard.
> > >
> > > the details of the hardware configuration can be found at
> > > http://www.gigabyte.com/products/product-page.aspx?pid=3478
> > Thanks for this patch! It's great to have more boards in the tree.
>
> Yes indeed, thanks!
>
> Gigabyte's website mentions 4 board revisions: 1.0, 1.1, 1.3 and 3.3; the
> user's manual suggests there's PCBs with varying features, from
> GA-MA785GMT-
> US2H to GA-MA785GPMT-UD2H. Which of these could be supported by your patch?
>    Torsten