buildrom: GRUB2! \o/

[Jordan Crouse]

I am most pleased to present this patch to buildrom to add GRUB2!!!
I booted to the prompt in QEMU and played around for a bit.

Very good job Patrick!

Jordan

[Paul Menzel]

Dear Jordan,

thank you for your patch. I just spotted a missing replacement.

Am Freitag, den 18.04.2008, 09:29 -0600 schrieb Jordan Crouse:
> Index: buildrom-devel/config/payloads/grub2.conf
>
> --- /dev/null   1970-01-01 00:00:00.000000000 +0000
> +++ buildrom-devel/config/payloads/grub2.conf   2008-04-18 09:09:14.000000000 -0600
> @@ -0,0 +1,11 @@
> +# Configuration file for the etherboot payload

s/ethernet/GRUB2/

Thanks,

Paul

[Uwe Hermann]

On Fri, Apr 18, 2008 at 09:29:52AM -0600, Jordan Crouse wrote:
> buildrom:  Add GRUB2
>
> Many thanks to Patrick Georgi for his excellent work!  This adds GRUB2 -
> enough to get to the GRUB2 prompt.  Detailed configurations and more
> modules coming later.
>
> Signed-off-by: Jordan Crouse

Acked-by: Uwe Hermann

Build-tested with QEMU.

(but see below)
> Index: buildrom-devel/config/payloads/grub2.conf
>
> --- /dev/null	1970-01-01 00:00:00.000000000 +0000
> +++ buildrom-devel/config/payloads/grub2.conf	2008-04-18 09:09:14.000000000 -0600
> @@ -0,0 +1,11 @@
> +# Configuration file for the etherboot payload

As noted in another mail, s/etherboot/GRUB2/.
> Index: buildrom-devel/packages/grub2/conf/grub.cfg
>
> --- /dev/null	1970-01-01 00:00:00.000000000 +0000
> +++ buildrom-devel/packages/grub2/conf/grub.cfg	2008-04-18 09:09:14.000000000 -0600
> @@ -0,0 +1,5 @@
> +coreboot
>
> +menuentry "Bob!" {

Maybe something more descriptive here?
> set root=(ata0)
>
> +}
> Index: buildrom-devel/packages/grub2/grub2.mk
> ===================================================================
> --- /dev/null	1970-01-01 00:00:00.000000000 +0000
> +++ buildrom-devel/packages/grub2/grub2.mk	2008-04-18 09:25:39.000000000 -0600
> @@ -0,0 +1,76 @@
> +GRUB2_REVISION=194d5cb45967444d2c107dc9a859323428d561da
> +GRUB2_URL=http://coreboot.org:8889/revision/tar/$(GRUB2_REVISION)

As per IRC, this needs updates.
> +GRUB2_CFG=$(PACKAGE_DIR)/grub2/conf/grub.cfg
> +GRUB2_MODULES=coreboot hello cat cmp fat iso9660 help lspci \
>      serial terminal lar terminfo memdisk ata ls \
>          configfile boot hexdump linux multiboot ext2

I'd personally drop at least hello and fat, the image is pretty big
already (170 KB) which will cause problems with small 256KB ROM images
(with normal/fallback even more).

Maybe we should add a kconfig string field where the user can specify
the list of modules (later). And/or at least provide a "rescue",
"minimal", "full" payload config option...

Uwe.

[Jordan Crouse]

On 22/04/08 23:28 +0200, Uwe Hermann wrote:
> On Fri, Apr 18, 2008 at 09:29:52AM -0600, Jordan Crouse wrote:
> > buildrom:  Add GRUB2
> >
> > Many thanks to Patrick Georgi for his excellent work!  This adds GRUB2 -
> > enough to get to the GRUB2 prompt.  Detailed configurations and more
> > modules coming later.
> >
> > Signed-off-by: Jordan Crouse
>
> Acked-by: Uwe Hermann

r153.  I have no objections if somebody wants to construct "default" lists
of modules for grub2.

Jordan