[PATCH]Move SET_FIDVID* to Kconfig

[Patrick Georgi]

Hi,

I moved the SET_FIDVID family of configuration options to Kconfig,
adapting its use (CONFIG_ prefix), and tried to minimize the board
specific settings.

They get some defaults in src/cpu/amd/model_*xx/Kconfig, which are
derived from the various #ifndef ... #define ... #endif blocks I removed
in the cpu specific code.

All "#define SET_FIDVID 0" in romstage.c files weren't necessary due to
these defaults, as well as all "#define SET_FIDVID 1" in Fam10 boards,
so these were stripped.
Some "select SET_FIDVID" could probably still be removed.

SET_FIDVID_CORE_RANGE was always 0, so I just chose that in the CPU
config, instead of per-board.
SET_FIDVID_CORE0_ONLY was always 1, so again, I moved this to the CPU.

Any change in SET_FIDVID* configuration values as a result of this patch
is a bug in this patch.

Regards,
Patrick

Move SET_FIDVID family of configuration options to Kconfig.
Reduce their per-board use and rely on per-cpu values instead.

Signed-off-by: Patrick Georgi

[xdrudis]

On Sat, Nov 06, 2010 at 01:56:45PM +0100, Patrick Georgi wrote:
> Hi,
>
> I moved the SET_FIDVID family of configuration options to Kconfig,
> adapting its use (CONFIG_ prefix), and tried to minimize the board
> specific settings.
>
> They get some defaults in src/cpu/amd/model_*xx/Kconfig, which are
> derived from the various #ifndef ... #define ... #endif blocks I removed
> in the cpu specific code.
>
> All "#define SET_FIDVID 0" in romstage.c files weren't necessary due to
> these defaults, as well as all "#define SET_FIDVID 1" in Fam10 boards,
> so these were stripped.
> Some "select SET_FIDVID" could probably still be removed.

So far so good. I'm not sure FIDVID can be an option for fam10 .
BKDG require it but I don't know if any fam10 cpu can boot without it.
> SET_FIDVID_CORE0_ONLY was always 1, so again, I moved this to the CPU.

It isn't always 1. It's 0 for FAM10. But the patch is right as far as I 
can see asleep as I am.

[Patrick Georgi]

Am 07.11.2010 02:28, schrieb xdrudis:
> So far so good. I'm not sure FIDVID can be an option for fam10 .
> BKDG require it but I don't know if any fam10 cpu can boot without it.

It is an option right now (just in romstage.c) - maybe we should drop
some of these options on Fam10 completely (and their uses as well), but
for now all I want to do is move them to Kconfig.
> > SET_FIDVID_CORE0_ONLY was always 1, so again, I moved this to the CPU.
>
> It isn't always 1. It's 0 for FAM10. But the patch is right as far as I 
> can see asleep as I am.

Indeed. I mixed that up in the explanation, but not in the code.

Thank you for looking into it, it's highly appreciated!

Patrick

[xdrudis]

On Sun, Nov 07, 2010 at 08:37:00AM +0100, Patrick Georgi wrote:
> Am 07.11.2010 02:28, schrieb xdrudis:
> It is an option right now (just in romstage.c) - maybe we should drop
> some of these options on Fam10 completely (and their uses as well), but
> for now all I want to do is move them to Kconfig.

Sure. I didn't mean if had to be the same patch.
> Thank you for looking into it, it's highly appreciated!

Thank you for your work (and to the others too).