Re: [coreboot] [coreboot-gerrit] Change in coreboot[master]: KBL: Update FSP headers - upgrade to FSP.2.0.0

[Aaron Durbin]

Why can't I access this CL on gerrit, but I'm getting emails for it?

On Tue, Mar 28, 2017 at 10:10 AM, Subrata Banik (Code Review)
 wrote:
> Subrata Banik has posted comments on this change. ( https://review.coreboot.org/19023 )
>
> Change subject: KBL: Update FSP headers - upgrade to FSP.2.0.0
> ......................................................................
>
> Patch Set 3:
>
> (2 comments)
>
> https://review.coreboot.org/#/c/19023/3/src/vendorcode/intel/fsp/fsp2_0/skyk...
> File src/vendorcode/intel/fsp/fsp2_0/skykabylake/ConfigBlock/CpuConfigFspData.h:
>
> PS3, Line 66:    } Bits;
>             :     UINT32 Uint32[2];
>             :   } CPU_CONFIG_FSP_DATA;
> why added space? don't we run clean up script?
>
> https://review.coreboot.org/#/c/19023/3/src/vendorcode/intel/fsp/fsp2_0/skyk...
> File src/vendorcode/intel/fsp/fsp2_0/skykabylake/FspmUpd.h:
>
> PS3, Line 41: #include <MemInfoHob.h>
> directory structure change
> ??
>
> Gerrit-MessageType: comment
> Gerrit-Change-Id: Id8ecea6fa5f4e7a72410f8da535ab9c4808b3482
> Gerrit-PatchSet: 3
> Gerrit-Project: coreboot
> Gerrit-Branch: master
> Gerrit-Owner: Balaji Manigandan 
> Gerrit-Reviewer: Barnali Sarkar 
> Gerrit-Reviewer: Naresh Solanki 
> Gerrit-Reviewer: Rizwan Qureshi 
> Gerrit-Reviewer: Subrata Banik 
> Gerrit-HasComments: Yes