[PATCH] flashrom: add AMD-768 chipset support

[Sven Schnelle]

Hi List,

the patch attached adds support for the AMD-768 chipset.

Signed-off-by: Sven Schnelle

Index: chipset_enable.c
===================================================================
--- chipset_enable.c	(revision 3845)
+++ chipset_enable.c	(working copy)
@@ -114,6 +114,19 @@
    return 0;
 }

+static int enable_flash_amd768(struct pci_dev *dev, const char *name)
+{
+	/* enable address decoding for LPC */
+	pci_write_byte(dev, 0x40, pci_read_byte(dev, 0x40) | 0x01);
+	pci_write_byte(dev, 0x43, 0xbf);
+
+	return 0;
+}
+
 /* Datasheet:
  *   - Name: 82371AB PCI-TO-ISA / IDE XCELERATOR (PIIX4)
  *   - URL: http://www.intel.com/design/intarch/datashts/290562.htm
@@ -937,6 +950,7 @@
    {0x1002, 0x4377, "ATI SB400",		enable_flash_sb400},
    {0x1166, 0x0205, "Broadcom HT-1000",	enable_flash_ht1000},
    {0x1022, 0x3000, "AMD Elan SC520",	get_flashbase_sc520},
+	{0x1022, 0x7440, "AMD AMD-768",         enable_flash_amd768},
 };

void print_supported_chipsets(void)

[Peter Stuge]

Hi Sven,

Sven Schnelle wrote:
> the patch attached adds support for the AMD-768 chipset.

..
> +static int enable_flash_amd768(struct pci_dev *dev, const char *name)
> +{
> /* enable address decoding for LPC */
> pci_write_byte(dev, 0x40, pci_read_byte(dev, 0x40) | 0x01);
> pci_write_byte(dev, 0x43, 0xbf);
> return 0;
>
> +}

Does this chipset supporty anything else than LPC?

//Peter

[Sven Schnelle]

Peter Stuge  writes:
> Sven Schnelle wrote:
> > the patch attached adds support for the AMD-768 chipset.
>
> ..
> > +static int enable_flash_amd768(struct pci_dev *dev, const char *name)
> > +{
> > /* enable address decoding for LPC */
> > pci_write_byte(dev, 0x40, pci_read_byte(dev, 0x40) | 0x01);
> > pci_write_byte(dev, 0x43, 0xbf);
> > return 0;
> >
> > +}
>
> Does this chipset supporty anything else than LPC?

Don't think so, at least the documentation only mentions LPC as BIOS
interface. Nevertheless i've recognized that the algorithm is the same
as for the AMD8111, so let's just add the PCI Ids.

Signed-off-by: Sven Schnelle

Index: coreboot-v2/util/flashrom/chipset_enable.c
===================================================================
--- coreboot-v2/util/flashrom/chipset_enable.c	(revision 3846)
+++ coreboot-v2/util/flashrom/chipset_enable.c	(working copy)
@@ -937,6 +937,7 @@
    {0x1002, 0x4377, "ATI SB400",		enable_flash_sb400},
    {0x1166, 0x0205, "Broadcom HT-1000",	enable_flash_ht1000},
    {0x1022, 0x3000, "AMD Elan SC520",	get_flashbase_sc520},
+	{0x1022, 0x7440, "AMD AMD-768",         enable_flash_amd8111},
 };

void print_supported_chipsets(void)

[Uwe Hermann]

On Tue, Jan 06, 2009 at 09:43:27AM +0100, Sven Schnelle wrote:
> > Does this chipset supporty anything else than LPC?
>
> Don't think so, at least the documentation only mentions LPC as BIOS
> interface. Nevertheless i've recognized that the algorithm is the same
> as for the AMD8111, so let's just add the PCI Ids.
>
> Signed-off-by: Sven Schnelle

Thanks, r3849.

Uwe.