Add support for socket 940. Move common files from socket_F, socket_AM2, and socket_940 into model_fxx.
Signed-off-by: Myles Watson mylesgw@gmail.com
Thanks, Myles
On 8/24/09 8:01 PM, Myles Watson wrote:
Add support for socket 940. Move common files from socket_F, socket_AM2, and socket_940 into model_fxx.
Signed-off-by: Myles Watson mylesgw@gmail.com
Thanks, Myles
Acked-by: Stefan Reinauer stepan@coresystems.de
On Mon, Aug 24, 2009 at 11:01 AM, Myles Watsonmylesgw@gmail.com wrote:
Move common files from socket_F, socket_AM2, and socket_940 into model_fxx.
This may be good for this model and set of sockets but may be a problem in general. If some future socket includes both model_fxx, AND includes some other model, is there any problem that may occur if the subdirs-y for some directories are executed twice?
Remember, you are not only setting up sockets/models for one part of one cpu family, you are setting up a pattern which others will follow. Be very careful about that!
If there is no problem, I guess this change is ok. I'm not that comfortable with it, however.
ron
Move common files from socket_F, socket_AM2, and socket_940 into model_fxx.
This may be good for this model and set of sockets but may be a problem in general. If some future socket includes both model_fxx, AND includes some other model, is there any problem that may occur if the subdirs-y for some directories are executed twice?
I think it should be pushed even farther down the tree and then that wouldn't be a problem either. Lets say that we had a "generic Pentium+" config, then we could source that from almost any socket, and nothing would be included twice. There should be no boards with two sockets, right?
Remember, you are not only setting up sockets/models for one part of one cpu family, you are setting up a pattern which others will follow. Be very careful about that!
I was trying, but I've had several missteps.
If there is no problem, I guess this change is ok. I'm not that comfortable with it, however.
You can revert it or tell me to.
Thanks, Myles