[PATCH]Move USB debug port includes out of romstage

[Patrick Georgi]

Hi,

attached patch does:
- move EHCI_BAR_INDEX to ehci.h - it's constant as per EHCI spec 2.3.1
- move EHCI_BAR and EHCI_DEBUG_OFFSET to Kconfig to be set by USB debug
port enabled southbridges
- drop USB debug code includes from romstage.cs and use romstage-srcs in
the build system instead
- Disable USBDEBUG in abuild, I forgot this by accident before the
previous commit

It's abuild tested.

Signed-off-by: Patrick Georgi

[Uwe Hermann]

On Tue, Oct 05, 2010 at 12:56:41PM +0200, Patrick Georgi wrote:
> Signed-off-by: Patrick Georgi

Looks good.

Acked-by: Uwe Hermann

Uwe.

[Myles Watson]

On Tue, Oct 5, 2010 at 4:56 AM, Patrick Georgi  wrote:
> Hi,
>
> attached patch does:
> move EHCI_BAR_INDEX to ehci.h - it's constant as per EHCI spec 2.3.1
> move EHCI_BAR and EHCI_DEBUG_OFFSET to Kconfig to be set by USB debug
>
> port enabled southbridges
> drop USB debug code includes from romstage.cs and use romstage-srcs in
>
> the build system instead
> Disable USBDEBUG in abuild, I forgot this by accident before the
>
> previous commit

Since you're changing USBDEBUG code, it seems like a good idea to keep
it in abuild... at least until it has stabilized.

Thanks,
Myles

[Patrick Georgi]

Am 05.10.2010 14:46, schrieb Myles Watson:
> Since you're changing USBDEBUG code, it seems like a good idea to keep
> it in abuild... at least until it has stabilized.

Kept it in.

Patrick

[Peter Stuge]

Patrick Georgi wrote:
> move EHCI_BAR and EHCI_DEBUG_OFFSET to Kconfig to be set by USB
>
> debug port enabled southbridges

Only comment is that I really like the

if SOUTH

config FOO
  default xy

endif

pattern in Kconfig files, so that the SOUTH isn't needed in each
place.

//Peter