ACPI support on M57SLI

[Harald Gutmann]

Hello once more!

Here is my patch to activate ACPI on M57SLI.
This patch solves the following issues on this mainboard:

* ACPI support is added
* PowerNow! for fam10 CPU's is activated
* Soft-Poweroff works

What this patch does not:
* ACPI support which is accepted by windows.

Take care on the following:
*** WARNING ***
* This patch needs as dependency the IRQ mptable fix patch[1] (which is right 
now not committed) in order to work!

[1] http://www.coreboot.org/pipermail/coreboot/2009-June/049570.html

I have ATM no space to try a windows installation, and I don't own a windows 
license and therefore I didn't cared on windows related ACPI problems.

It should be quite easy to complete this, that windows also will like it.
If anyone is interested in doing that, please contact me.
I've an IRC-Log from the discussion with Rudolf Marek related to ACPI on 
windows and what will be needed to get it right.

Please be so kindly and review it, so that it can get commited.

Signed-off-by: Harald Gutmann

Kind regards,
Harald Gutmann

[Harald Gutmann]

Oooopppss.....
forgot to attach the file.

Sorry for that.

On Sunday 14 June 2009 16:56:47 Harald Gutmann wrote:
> Hello once more!
>
> Here is my patch to activate ACPI on M57SLI.
> This patch solves the following issues on this mainboard:
> ACPI support is added
> PowerNow! for fam10 CPU's is activated
> Soft-Poweroff works
>
> What this patch does not:
> ACPI support which is accepted by windows.
>
> Take care on the following:
> *** WARNING ***
> This patch needs as dependency the IRQ mptable fix patch[1] (which is
>
> right now not committed) in order to work!
>
> [1] http://www.coreboot.org/pipermail/coreboot/2009-June/049570.html
>
> I have ATM no space to try a windows installation, and I don't own a
> windows license and therefore I didn't cared on windows related ACPI
> problems.
>
> It should be quite easy to complete this, that windows also will like it.
> If anyone is interested in doing that, please contact me.
> I've an IRC-Log from the discussion with Rudolf Marek related to ACPI on
> windows and what will be needed to get it right.
>
> Please be so kindly and review it, so that it can get commited.
>
> Signed-off-by: Harald Gutmann
>
> Kind regards,
> Harald Gutmann

[Florentin Demetrescu]

The power-off works..
:)
What other tests I can/should do?
(I have an Ubuntu Feisty installed on the coreboot test machine)
Florentin

Quoting Harald Gutmann :
> Oooopppss.....
> forgot to attach the file.
>
> Sorry for that.
>
> On Sunday 14 June 2009 16:56:47 Harald Gutmann wrote:
> > Hello once more!
> >
> > Here is my patch to activate ACPI on M57SLI.
> > This patch solves the following issues on this mainboard:
> > ACPI support is added
> > PowerNow! for fam10 CPU's is activated
> > Soft-Poweroff works
> >
> > What this patch does not:
> > ACPI support which is accepted by windows.
> >
> > Take care on the following:
> > *** WARNING ***
> > This patch needs as dependency the IRQ mptable fix patch[1] (which is
> >
> > right now not committed) in order to work!
> >
> > [1] http://www.coreboot.org/pipermail/coreboot/2009-June/049570.html
> >
> > I have ATM no space to try a windows installation, and I don't own a
> > windows license and therefore I didn't cared on windows related ACPI
> > problems.
> >
> > It should be quite easy to complete this, that windows also will like it.
> > If anyone is interested in doing that, please contact me.
> > I've an IRC-Log from the discussion with Rudolf Marek related to ACPI on
> > windows and what will be needed to get it right.
> >
> > Please be so kindly and review it, so that it can get commited.
> >
> > Signed-off-by: Harald Gutmann
> >
> > Kind regards,
> > Harald Gutmann

[Harald Gutmann]

On Sunday 14 June 2009 18:45:30 Florentin Demetrescu wrote:
> The power-off works..
>
> :)

1. check dmesg for error related to acpi.
2. check soft-power-off
3. check PowerNow! (modprobe powernow-k8) 
    http://www.twibble.org/Articles/amd-x2-powernow (overview)
4. check HPET (works with coreboot, but not with proprietary bios ;))
5. review my patch
> What other tests I can/should do?
> (I have an Ubuntu Feisty installed on the coreboot test machine)
> Florentin

Thanks for testing,
kind regards,

Harald
> Quoting Harald Gutmann :
> > Oooopppss.....
> > forgot to attach the file.
> >
> > Sorry for that.
> >
> > On Sunday 14 June 2009 16:56:47 Harald Gutmann wrote:
> > > Hello once more!
> > >
> > > Here is my patch to activate ACPI on M57SLI.
> > > This patch solves the following issues on this mainboard:
> > > ACPI support is added
> > > PowerNow! for fam10 CPU's is activated
> > > Soft-Poweroff works
> > >
> > > What this patch does not:
> > > ACPI support which is accepted by windows.
> > >
> > > Take care on the following:
> > > *** WARNING ***
> > > This patch needs as dependency the IRQ mptable fix patch[1] (which is
> > >
> > > right now not committed) in order to work!
> > >
> > > [1] http://www.coreboot.org/pipermail/coreboot/2009-June/049570.html
> > >
> > > I have ATM no space to try a windows installation, and I don't own a
> > > windows license and therefore I didn't cared on windows related ACPI
> > > problems.
> > >
> > > It should be quite easy to complete this, that windows also will like
> > > it. If anyone is interested in doing that, please contact me.
> > > I've an IRC-Log from the discussion with Rudolf Marek related to ACPI
> > > on windows and what will be needed to get it right.
> > >
> > > Please be so kindly and review it, so that it can get commited.
> > >
> > > Signed-off-by: Harald Gutmann
> > >
> > > Kind regards,
> > > Harald Gutmann

[Myles Watson]

I don't have the hardware, so I can't test.

+unsigned long write_acpi_tables(unsigned long start)
+{
+	get_bus_conf();
+	sbdn = sysconf.sbdn;

Since sbdn isn't used in write_acpi_tables, could you make it a local
variable in acpi_fill_madt instead and move that code there?
write_acpi_tables is pretty generic, and will eventually be factored out at
least per northbridge, so it makes sense to keep it as clean as possible.

fadt.c should be in the southbridge/nvidia/mcp55/ directory.  Won't it work
for any board that has that chipset?

In Config.lb it seems like the indenting isn't uniform.  Could you use tabs
to make it cleaner?  Also in dsdt.asl there are multiple lines that have
indented blank lines.

Thanks,
Myles

[Harald Gutmann]

On Tuesday 16 June 2009 05:52:38 Myles Watson wrote:
> I don't have the hardware, so I can't test.
>
> +unsigned long write_acpi_tables(unsigned long start)
> +{
> get_bus_conf();
> sbdn = sysconf.sbdn;

Done.
> Since sbdn isn't used in write_acpi_tables, could you make it a local
> variable in acpi_fill_madt instead and move that code there?
> write_acpi_tables is pretty generic, and will eventually be factored out at
> least per northbridge, so it makes sense to keep it as clean as possible.
>
> fadt.c should be in the southbridge/nvidia/mcp55/ directory.  Won't it work
> for any board that has that chipset?

Done.
> In Config.lb it seems like the indenting isn't uniform.  Could you use tabs
> to make it cleaner?  Also in dsdt.asl there are multiple lines that have
> indented blank lines.

The dsdt.asl is now whitspace/indenting cleared.
And got some further improvements to be able to install and boot windows 7 
from coreboot with acpi support on m57sli.

I have already done a whitespace/indenting fix on Config.lb but attaching this 
to the acpi patch would just blow it up too much.
> Thanks,
> Myles

Thanks for your review,
Harald

[Myles Watson]

> The dsdt.asl is now whitspace/indenting cleared.
> And got some further improvements to be able to install and boot windows 7
> from coreboot with acpi support on m57sli.

Great.
> I have already done a whitespace/indenting fix on Config.lb but attaching
> this
> to the acpi patch would just blow it up too much.

Sure.  I just meant the lines you were touching.

Acked-by: Myles Watson

Thanks,
Myles

[Peter Stuge]

Harald Gutmann wrote:
> And got some further improvements to be able to install and boot
> windows 7 from coreboot with acpi support on m57sli.

Very cool! Can you say something about what was required to do this?

//Peter

[Harald Gutmann]

On Thursday 18 June 2009 21:05:30 Peter Stuge wrote:
> Harald Gutmann wrote:
> > And got some further improvements to be able to install and boot
> > windows 7 from coreboot with acpi support on m57sli.
>
> Very cool! Can you say something about what was required to do this?

Yes, sure. I talked to Rudolf about what is to do to get windows working.
His explanation was quite easy: You'll need the _CRS symbols in your dsdt.asl.

I had a look at his dsdt.asl from asus/m2v-mx_se, and saw that there are not 
much _CRS symbols in it.
Keyboard, Mouse, Floppy, and the PCI root device has _CRS Symbols.
Afterward I had a look at my disassembled vendors dsdt.asl, and added the _CRS 
Symbols with the values for my hardware.

The first try on installing the windows 7 build 7100 lead into a "STOP: 
0x0000005a 0x000000d ... ... ..."
I had a look at the "STOP 0x000000A5" page from Microsoft's support site [1], 
and discovered that Parameter1 0xd means that there is some _HID or _ADR 
symbol missing.

After rechecking my dsdt.asl with Rudolf's I found quite fast out that he had 
an _ADR value for Device(ISA), so I added this value according to my hardware, 
and tried again installing Win7.

That was all, which has lead to success with coreboot and windows. :)

[1]http://support.microsoft.com/kb/314830/en
> //Peter

Regards,
Harald

[Peter Stuge]

Harald Gutmann wrote:
> His explanation was quite easy: You'll need the _CRS symbols in
> your dsdt.asl.
>
> I had a look at his dsdt.asl from asus/m2v-mx_se, and saw that
> there are not much _CRS symbols in it.
> Keyboard, Mouse, Floppy, and the PCI root device has _CRS Symbols.

And we already have the info for these, right, it would be awesome to
generate that part of the DSDT automatically, as Rudolf has
mentioned before.
> That was all, which has lead to success with coreboot and windows. :)

Great! Has the patch been committed? If not, please do it. :)

Acked-by: Peter Stuge

[Harald Gutmann]

On Thursday 18 June 2009 22:20:24 Peter Stuge wrote:
> Harald Gutmann wrote:
> > His explanation was quite easy: You'll need the _CRS symbols in
> > your dsdt.asl.
> >
> > I had a look at his dsdt.asl from asus/m2v-mx_se, and saw that
> > there are not much _CRS symbols in it.
> > Keyboard, Mouse, Floppy, and the PCI root device has _CRS Symbols.
>
> And we already have the info for these, right, it would be awesome to
> generate that part of the DSDT automatically, as Rudolf has
> mentioned before.

Did Rudolf talk about automatic generation for _CRS symbols, or from _PRT 
symbols?
I think his thoughts have been for the _PRT symbols, where we should have alle 
the information in the device struct (except the used interrupts).

Maybe we should start a standalone discussion on that, I think it could be 
possible to generate some parts of the dsdt.asl through information which is 
available.
> > That was all, which has lead to success with coreboot and windows. :)
>
> Great! Has the patch been committed? If not, please do it. :)

Will be done in a few minutes.
> Acked-by: Peter Stuge

Thanks, for the second Acked-by, the patch was already Acked-by from Myles 
Watson.

Kind regards,
Harald Gutmann

[Harald Gutmann]

On Thursday 18 June 2009 17:14:08 Myles Watson wrote:
> > The dsdt.asl is now whitspace/indenting cleared.
> > And got some further improvements to be able to install and boot windows 7
> > from coreboot with acpi support on m57sli.
>
> Great.
> > I have already done a whitespace/indenting fix on Config.lb but attaching
> > this
> > to the acpi patch would just blow it up too much.
>
> Sure.  I just meant the lines you were touching.
> Acked-by: Myles Watson

On Thursday 18 June 2009 22:20:24 Peter Stuge wrote:
> Harald Gutmann wrote:
> > His explanation was quite easy: You'll need the _CRS symbols in
> > your dsdt.asl.
> >
> > I had a look at his dsdt.asl from asus/m2v-mx_se, and saw that
> > there are not much _CRS symbols in it.
> > Keyboard, Mouse, Floppy, and the PCI root device has _CRS Symbols.
>
> And we already have the info for these, right, it would be awesome to
> generate that part of the DSDT automatically, as Rudolf has
> mentioned before.
> > That was all, which has lead to success with coreboot and windows. :)
>
> Great! Has the patch been committed? If not, please do it. :)
>
> Acked-by: Peter Stuge

Thanks, r4364.

Kind regards,
Harald

[Florentin Demetrescu]

Hello everyone,

The last release works for me wonderfully almost "out of the box". (still don't
like HAVE_HIGH_TABLES :/)

As a premium, the hvm virtualization works too. (kvm)

Again, congratulation for all the work done by the coreboot team (and especialy
Harald) for this board! I think we can now validate all of its features on the
wiki..

Florentin

Quoting Harald Gutmann :
> On Thursday 18 June 2009 17:14:08 Myles Watson wrote:
> > > The dsdt.asl is now whitspace/indenting cleared.
> > > And got some further improvements to be able to install and boot windows 7
> > > from coreboot with acpi support on m57sli.
> >
> > Great.
> > > I have already done a whitespace/indenting fix on Config.lb but attaching
> > > this
> > > to the acpi patch would just blow it up too much.
> >
> > Sure.  I just meant the lines you were touching.
> > Acked-by: Myles Watson
>
> On Thursday 18 June 2009 22:20:24 Peter Stuge wrote:
> > Harald Gutmann wrote:
> > > His explanation was quite easy: You'll need the _CRS symbols in
> > > your dsdt.asl.
> > >
> > > I had a look at his dsdt.asl from asus/m2v-mx_se, and saw that
> > > there are not much _CRS symbols in it.
> > > Keyboard, Mouse, Floppy, and the PCI root device has _CRS Symbols.
> >
> > And we already have the info for these, right, it would be awesome to
> > generate that part of the DSDT automatically, as Rudolf has
> > mentioned before.
> > > That was all, which has lead to success with coreboot and windows. :)
> >
> > Great! Has the patch been committed? If not, please do it. :)
> >
> > Acked-by: Peter Stuge
>
> Thanks, r4364.
>
> Kind regards,
> Harald

[Harald Gutmann]

On Saturday 20 June 2009 22:17:51 Florentin Demetrescu wrote:
> Hello everyone,
>
> The last release works for me wonderfully almost "out of the box". (still
> don't like HAVE_HIGH_TABLES :/)

Use a recent SeaBios version and get happy with HIGH_TABLES. ;)
> As a premium, the hvm virtualization works too. (kvm)

Does that mean you have tested "Hardware Visualization"?
If yes, please be so kindly and mark it in the wiki entry for m57sli as OK (if 
you have an account) otherwise please give some details on that, so I can add 
this as tested.
> Again, congratulation for all the work done by the coreboot team (and
> especialy Harald) for this board! I think we can now validate all of its
> features on the wiki..

The wiki should be up to date for this board, I changed all of the entries 
which I was able to test. Hopefully we can find/fix/verify the last outstanding 
problems on v1 with that board, so that it can be stated as "fully supported".
(And maybe, when I've too much time I'll have a look at the S3 ACPI mode, but 
this could get quite hard, as the MCP55 documentation is under NDA by nvidia.)

If you have a floppy device and the possibility to test it, please do so and 
report if it works. (Otherwise I'll test that in a few weeks, as i don't have 
a floppy device here.)

Great that this patches make you happy, and hopefully everything works like 
expected. If you run into problems please report it.
> Florentin

Kind regards,
Harald
> Quoting Harald Gutmann :
> > On Thursday 18 June 2009 17:14:08 Myles Watson wrote:
> > > > The dsdt.asl is now whitspace/indenting cleared.
> > > > And got some further improvements to be able to install and boot
> > > > windows 7 from coreboot with acpi support on m57sli.
> > >
> > > Great.
> > > > I have already done a whitespace/indenting fix on Config.lb but
> > > > attaching this
> > > > to the acpi patch would just blow it up too much.
> > >
> > > Sure.  I just meant the lines you were touching.
> > >
> > > Acked-by: Myles Watson
> >
> > On Thursday 18 June 2009 22:20:24 Peter Stuge wrote:
> > > Harald Gutmann wrote:
> > > > His explanation was quite easy: You'll need the _CRS symbols in
> > > > your dsdt.asl.
> > > >
> > > > I had a look at his dsdt.asl from asus/m2v-mx_se, and saw that
> > > > there are not much _CRS symbols in it.
> > > > Keyboard, Mouse, Floppy, and the PCI root device has _CRS Symbols.
> > >
> > > And we already have the info for these, right, it would be awesome to
> > > generate that part of the DSDT automatically, as Rudolf has
> > > mentioned before.
> > > > That was all, which has lead to success with coreboot and windows. :)
> > >
> > > Great! Has the patch been committed? If not, please do it. :)
> > >
> > > Acked-by: Peter Stuge
> >
> > Thanks, r4364.
> >
> > Kind regards,
> > Harald