Re: [coreboot] [PATCH] drivers vs. obj

[Myles Watson]

On Tue, Feb 23, 2010 at 8:37 AM, Patrick Georgi wrote:
> Am 24.09.2009 22:59, schrieb Myles Watson:
> > Based on that, here's a patch that changes drivers that aren't console,
> > pci, or cpu, to obj.
> >
> > The most common one was mainboard.c as a driver.
> >
> > Boot tested with Tyan s2895.
> >
> > Signed-off-by: Myles Watson
>
> I updated the patch, with all the boards converted that appeared in
> Kconfig after this patch was made, too. There's not a single driver in
> src/mainboard left.
>
> Signed-off-by: Patrick Georgi

Index: src/mainboard/roda/rk886ex/Makefile.inc
===================================================================
--- src/mainboard/roda/rk886ex/Makefile.inc    (revision 5149)
+++ src/mainboard/roda/rk886ex/Makefile.inc    (working copy)
@@ -21,10 +21,10 @@
 ## This mainboard requires DCACHE_AS_RAM enabled. It won't work without.
 ##

-driver-y += mainboard.o
-driver-y += m3885.o
-driver-y += ec.o
-driver-y += rtl8168.o
+obj-y += mainboard.o
+obj-y += m3885.o
+obj-y += ec.o
+obj-y += rtl8168.o

It looks like rtl8168 should stay a driver, since it's a PCI device. I don't
know about m3885.o and ec.o. I'm also not sure about the debug devices.  Are
they considered PCI?  It's been a long time since I thought about this.

Thanks,
Myles