Re: [coreboot] v3 __func0 cleanup

[Myles Watson]

On Tue, Oct 28, 2008 at 2:15 PM, Marc Jones  wrote:
> Myles Watson wrote:
> > This patch documents the unreadable function in northbridge/amd/k8/pci.c
> > and
> > cleans up the NULL pointer protection.
> >
> > Signed-off-by: Myles Watson <[e-mail] <mailto:[e-mail]
> > > >
>
> Untested but this looks correct to me. See if Ron has some comment.
>
> Acked-by: Marc Jones

Thanks.
> > It also begs the question why cpu_bus_scan and cpu_bus_init aren't needed
> > in v3.  They aren't called.  Is that an oversight, or should they be
> > removed.
>
> I think it is because the HT init (cpu setup) is all done pre-memory and
> done by the time dts is used. This could change if the dts is present in
> stage1.

Do you know what the corresponding functions are in v3?

Thanks,
Myles