This patch documents the unreadable function in northbridge/amd/k8/pci.c and cleans up the NULL pointer protection.
Signed-off-by: Myles Watson mylesgw@gmail.com
It also begs the question why cpu_bus_scan and cpu_bus_init aren't needed in v3. They aren't called. Is that an oversight, or should they be removed.
Thanks, Myles
Myles Watson wrote:
This patch documents the unreadable function in northbridge/amd/k8/pci.c and cleans up the NULL pointer protection.
Signed-off-by: Myles Watson <mylesgw@gmail.com mailto:mylesgw@gmail.com>
Untested but this looks correct to me. See if Ron has some comment.
Acked-by: Marc Jones marc.jones@amd.com
It also begs the question why cpu_bus_scan and cpu_bus_init aren't needed in v3. They aren't called. Is that an oversight, or should they be removed.
I think it is because the HT init (cpu setup) is all done pre-memory and done by the time dts is used. This could change if the dts is present in stage1.
Marc
Marc Jones Senior Firmware Engineer (970) 226-9684 Office mailto:Marc.Jones@amd.com http://www.amd.com/embeddedprocessors
On Tue, Oct 28, 2008 at 2:15 PM, Marc Jones Marc.Jones@amd.com wrote:
Myles Watson wrote:
This patch documents the unreadable function in northbridge/amd/k8/pci.c and cleans up the NULL pointer protection.
Signed-off-by: Myles Watson <mylesgw@gmail.com <mailto:mylesgw@gmail.com
Untested but this looks correct to me. See if Ron has some comment.
Acked-by: Marc Jones marc.jones@amd.com
Thanks.
It also begs the question why cpu_bus_scan and cpu_bus_init aren't needed in v3. They aren't called. Is that an oversight, or should they be removed.
I think it is because the HT init (cpu setup) is all done pre-memory and done by the time dts is used. This could change if the dts is present in stage1.
Do you know what the corresponding functions are in v3?
Thanks, Myles
-----Original Message----- From: Marc Jones [mailto:Marc.Jones@amd.com] Sent: Tuesday, October 28, 2008 2:16 PM To: Myles Watson Cc: Coreboot Subject: Re: [coreboot] v3 __func0 cleanup
Myles Watson wrote:
This patch documents the unreadable function in northbridge/amd/k8/pci.c
and
cleans up the NULL pointer protection.
Signed-off-by: Myles Watson <mylesgw@gmail.com
Untested but this looks correct to me. See if Ron has some comment.
Acked-by: Marc Jones marc.jones@amd.com
Rev 960.
Thanks, Myles
On Tue, Oct 28, 2008 at 1:02 PM, Myles Watson mylesgw@gmail.com wrote:
This patch documents the unreadable function in northbridge/amd/k8/pci.c and cleans up the NULL pointer protection.
Signed-off-by: Myles Watson mylesgw@gmail.com
It also begs the question why cpu_bus_scan and cpu_bus_init aren't needed in v3. They aren't called. Is that an oversight, or should they be removed.
This is a big improvement.
I am not sure those functions are needed but let's not remove them just yet. Peter, stefan and I are doing more looking at device code.
Found more ugliness, trying to do more cleanup.
ron