Re: [coreboot] [PATCH] move fadt.c closer to chipset (VT8237)

[Peter Stuge]

Rudolf Marek wrote:
> Following patch moves all vt8237 fadt.c from mainboard/* file to
> chipset directory just with one common file.
>
> Signed-off-by: Rudolf Marek

..
> +/**
> Create the Fixed ACPI Description Tables (FADT) for this board.

Please change or yank 'board' here.
> memcpy(header->signature, "FACP", 4);

Can you explain FADT vs. FACP ?
> memcpy(header->asl_compiler_id, "IASL", 4);

Why not "CORE" ?

Other than that:

Acked-by: Peter Stuge