[PATCH] move fadt.c closer to chipset (VT8237)

[Rudolf Marek]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hello,

Following patch moves all vt8237 fadt.c from mainboard/* file to chipset
directory just with one common file.

Signed-off-by: Rudolf Marek

Rudolf
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAkodsm8ACgkQ3J9wPJqZRNXfcgCgmguKgo3vLe1EZ+Jzbp00duk9
ocQAniA7v9oytvXBgZyqyojyFLik4tCL
=8FW5
-----END PGP SIGNATURE-----

[Peter Stuge]

Rudolf Marek wrote:
> Following patch moves all vt8237 fadt.c from mainboard/* file to
> chipset directory just with one common file.
>
> Signed-off-by: Rudolf Marek

..
> +/**
> Create the Fixed ACPI Description Tables (FADT) for this board.

Please change or yank 'board' here.
> memcpy(header->signature, "FACP", 4);

Can you explain FADT vs. FACP ?
> memcpy(header->asl_compiler_id, "IASL", 4);

Why not "CORE" ?

Other than that:

Acked-by: Peter Stuge

[Uwe Hermann]

On Thu, May 28, 2009 at 02:30:20AM +0200, Peter Stuge wrote:
> Rudolf Marek wrote:
> > Following patch moves all vt8237 fadt.c from mainboard/* file to
> > chipset directory just with one common file.
> >
> > Signed-off-by: Rudolf Marek

Yep, very nice. Factoring out common code is always a good thing.

Acked-by: Uwe Hermann
> > +/**
> > Create the Fixed ACPI Description Tables (FADT) for this board.
>
> Please change or yank 'board' here.

Ack.
> > memcpy(header->asl_compiler_id, "IASL", 4);
>
> Why not "CORE" ?

What's the purpose of this field? Does it mean the user
should use 'iasl'? That iasl was used to create the file?
Depending on the meaning, IASL or CORE may be more appropriate,
but I don't know enough about this stuff to decide...

Uwe.

[Rudolf Marek]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Its in.

Author: ruik
Date: 2009-05-31 19:00:25 +0200 (Sun, 31 May 2009)
New Revision: 4327
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAkoiuDgACgkQ3J9wPJqZRNX/ZACfV+52B6u5qLRtat1drcUykli/
FVkAn386VkjGHp6iJqBF+zskqIQBG6rX
=GuUq
-----END PGP SIGNATURE-----

[Rudolf Marek]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi,

Thanks for the review.
> Please change or yank 'board' here.

yes.
> > memcpy(header->signature, "FACP", 4);
>
> Can you explain FADT vs. FACP ?

Nope, but this is correct. The name is different from signature.
> > memcpy(header->asl_compiler_id, "IASL", 4);
>
> Why not "CORE" ?

Yes I fixed that.

I Also change the revision & test again against linux and Windows 7.

Rudolf
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAkoisy8ACgkQ3J9wPJqZRNXcTQCgz94IvtyR2Ltcj8aOY/C2Dhtt
ayYAnjNw1TzvcxNI//Ie7UPkH/qm9Snz
=2OED
-----END PGP SIGNATURE-----