Re: [coreboot] [PATCH] New config option for 440BX northbridge

[Joseph Smith]

On 03/12/2010 06:07 PM, ron minnich wrote:
> On Fri, Mar 12, 2010 at 2:55 PM, Keith Hui  wrote:
> > If we go through all the Kconfigs for all 440BX boards and identify all that
> > have 4 slots, and enter this setting for all of them, done before my 440BX
> > ram init code is ready. ;-) There is a reason for expert mode, no?
>
> I think this goes beyond expert mode. It seems to me it is a setting
> that can render the machine unbootable if configured incorrectly. Even
> for experts, I don't think it should be visible in Kconfig.

has anyone even tested this yet???
> > slot4_detect = (spd_read_byte((DIMM_SPD_BASE + 3), SPD_MEMORY_TYPE);
> >
> > if (slot4_detect != 0xff) {
> >  /* We have 4 slots */
> >  ----Set bit 4 in SDRAMPWR----
> >  #define DIMM_SOCKETS 4
> >
> > } else {
> >  /* We have 3 slots */
> >  ----Set bit 4 in SDRAMPWR----
> >  #define DIMM_SOCKETS 3
> >
> > }