Re: [coreboot] [commit] r5348 - in trunk/src: cpu/amd/model_gx2 include/console mainboard/advantech/pcm-5820 mainboard/amd/db800 northbridge/amd/lx southbridge/amd/cs5536

[Myles Watson]

> Modified: trunk/src/include/console/console.h
>
> ==============================================================================
> --- trunk/src/include/console/console.h Fri Apr  2 23:39:12 2010
>  (r5347)
> +++ trunk/src/include/console/console.h Sat Apr  3 00:11:20 2010
>  (r5348)
> @@ -44,6 +44,9 @@
>  #endif
>
> #ifndef __ROMCC__
> +void console_init(void);
> +void post_code(u8 value);
> +void __attribute__ ((noreturn)) die(const char *msg);
>  int do_printk(int msg_level, const char *fmt, ...)
> __attribute__((format(printf, 2, 3)));

This looks redundant as of 5347.
> Modified: trunk/src/mainboard/amd/db800/romstage.c
>
> ==============================================================================
> --- trunk/src/mainboard/amd/db800/romstage.c    Fri Apr  2 23:39:12 2010
>      (r5347)
> +++ trunk/src/mainboard/amd/db800/romstage.c    Sat Apr  3 00:11:20 2010
>      (r5348)
> @@ -24,6 +24,7 @@
>  #include <device/pnp_def.h>
>  #include <arch/hlt.h>
>  #include "pc80/serial.c"
> +#include <console/console.h>
>  #include "console/console.c"

This shouldn't be necessary, since console.c includes console.h

Thanks,
Myles