Re: [coreboot] [patch] ck804 ACPI PIC/APIC interrupt logic

[Stefan Reinauer]

* Jonathan A. Kollasch  [110525 18:59]:
> > >      If (LEqual (Arg0, 8)) {
> >
> > white spaces look messed up
>
> No, that was intentional, i wanted the LEqual to line up,
> though then I didn't pad the single character numbers ...

Sorry not sure what you were trying to achieve. As long as the code
looks like

If (LEqual (Arg0, 8)) {
                ....
        } ElseIf (LEqual (Arg0, 13)) {
                ....
        } ...

you should be fine
> > > +Device (APIB) {
> > > Name (_HID, EISAID ("PNP0C0F"))
> >
> > Can you call these LNKA/LNKB... we used those names in all other targets
> > afaict.
>
> This is intentional, I need a link Device for APIC and PIC for each
> device.

Yes, you should handle the APIC/PIC cases in your LNKA/LNKB/... nodes.
I think we should still call them LNKA/LNKB/... for readability of the
code.

Device (LNKB)
                {
                        Name (_HID, EisaId ("PNP0C0F"))
                        Name (_UID, 0x02)
                        ...
                        /* Current Resources - return irq set up in BIOS */
                        Method (_CRS, 0, NotSerialized)
                        {
                                ...
                                If (LNot (PICF)) {
                                        Return (CRSP)
                                } Else {
                                        Return (CRSA)
                                }
                        }
                        ...
                }