[patch] ck804 ACPI PIC/APIC interrupt logic

[Jonathan A. Kollasch]

Add ACPI automatic PIC/APIC interrupt routing logic for ck804.

Signed-off-by: Jonathan Kollasch

[Stefan Reinauer]

* Jonathan A. Kollasch  [110523 21:28]:
> Add ACPI automatic PIC/APIC interrupt routing logic for ck804.
>
> Signed-off-by: Jonathan Kollasch
> Index: src/southbridge/nvidia/ck804/acpi/ck804.asl
>
> --- src/southbridge/nvidia/ck804/acpi/ck804.asl	(revision 0)
> +++ src/southbridge/nvidia/ck804/acpi/ck804.asl	(revision 0)
> @@ -0,0 +1,918 @@
> +/* For _CRS */
> +Method (ILM0, 1, Serialized) {

For Methods the { should be on a new line.
>      If (LEqual (Arg0, 8)) {

white spaces look messed up
> Return (20)
> } ElseIf (LEqual (Arg0, 13)) {
> Return (21)
> } ElseIf (LEqual (Arg0, 2)) {
> Return (22)
> } ElseIf (LEqual (Arg0, 1)) {
> Return (23)
> } Else {
> Return (0)
> }
>
> +}
> +/* For _SRS */
> +Method (MLI0, 1, Serialized) {
>      If (LEqual (Arg0, 20)) {
> Return (8)

ditto
> +/* For _CRS */
> +Method (ILM1, 1, Serialized) {
>      If (LEqual (Arg0, 8)) {
> Return (16)

... and here
> +/* For _SRS */
> +Method (MLI1, 1, Serialized) {
>      If (LEqual (Arg0, 16)) {
> Return (8)

.. here too.
> +Device (APIB) {
> Name (_HID, EISAID ("PNP0C0F"))

Can you call these LNKA/LNKB... we used those names in all other targets
afaict.

[Jonathan A. Kollasch]

On Mon, May 23, 2011 at 09:53:49PM +0200, Stefan Reinauer wrote:
> Jonathan A. Kollasch  [110523 21:28]:
> > Add ACPI automatic PIC/APIC interrupt routing logic for ck804.
> >
> > Signed-off-by: Jonathan Kollasch
> > Index: src/southbridge/nvidia/ck804/acpi/ck804.asl
> >
> > --- src/southbridge/nvidia/ck804/acpi/ck804.asl	(revision 0)
> > +++ src/southbridge/nvidia/ck804/acpi/ck804.asl	(revision 0)
> > @@ -0,0 +1,918 @@
> > +/* For _CRS */
> > +Method (ILM0, 1, Serialized) {
>
> For Methods the { should be on a new line.
> >      If (LEqual (Arg0, 8)) {
>
> white spaces look messed up

No, that was intentional, i wanted the LEqual to line up,
though then I didn't pad the single character numbers ...
> > Return (20)
> > } ElseIf (LEqual (Arg0, 13)) {
> > Return (21)
> > } ElseIf (LEqual (Arg0, 2)) {
> > Return (22)
> > } ElseIf (LEqual (Arg0, 1)) {
> > Return (23)
> > } Else {
> > Return (0)
> > }
> >
> > +}
> > +/* For _SRS */
> > +Method (MLI0, 1, Serialized) {
> >      If (LEqual (Arg0, 20)) {
> > Return (8)
>
> ditto

too much indentation inside?
> > +/* For _CRS */
> > +Method (ILM1, 1, Serialized) {
> >      If (LEqual (Arg0, 8)) {
> > Return (16)
>
> ... and here
> > +/* For _SRS */
> > +Method (MLI1, 1, Serialized) {
> >      If (LEqual (Arg0, 16)) {
> > Return (8)
>
> .. here too.
> > +Device (APIB) {
> > Name (_HID, EISAID ("PNP0C0F"))
>
> Can you call these LNKA/LNKB... we used those names in all other targets
> afaict.

This is intentional, I need a link Device for APIC and PIC for each
device.

Jonathan Kollasch

[Stefan Reinauer]

* Jonathan A. Kollasch  [110525 18:59]:
> > >      If (LEqual (Arg0, 8)) {
> >
> > white spaces look messed up
>
> No, that was intentional, i wanted the LEqual to line up,
> though then I didn't pad the single character numbers ...

Sorry not sure what you were trying to achieve. As long as the code
looks like

If (LEqual (Arg0, 8)) {
                ....
        } ElseIf (LEqual (Arg0, 13)) {
                ....
        } ...

you should be fine
> > > +Device (APIB) {
> > > Name (_HID, EISAID ("PNP0C0F"))
> >
> > Can you call these LNKA/LNKB... we used those names in all other targets
> > afaict.
>
> This is intentional, I need a link Device for APIC and PIC for each
> device.

Yes, you should handle the APIC/PIC cases in your LNKA/LNKB/... nodes.
I think we should still call them LNKA/LNKB/... for readability of the
code.

Device (LNKB)
                {
                        Name (_HID, EisaId ("PNP0C0F"))
                        Name (_UID, 0x02)
                        ...
                        /* Current Resources - return irq set up in BIOS */
                        Method (_CRS, 0, NotSerialized)
                        {
                                ...
                                If (LNot (PICF)) {
                                        Return (CRSP)
                                } Else {
                                        Return (CRSA)
                                }
                        }
                        ...
                }

[patch v2] ck804 ACPI PIC/APIC interrupt logic

[Jonathan A. Kollasch]

Add ACPI automatic PIC/APIC interrupt routing logic for ck804.

Signed-off-by: Jonathan Kollasch