Re: [coreboot] [PATCH] move fadt.c closer to chipset (VT8237)

[Rudolf Marek]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi,

Thanks for the review.
> Please change or yank 'board' here.

yes.
> > memcpy(header->signature, "FACP", 4);
>
> Can you explain FADT vs. FACP ?

Nope, but this is correct. The name is different from signature.
> > memcpy(header->asl_compiler_id, "IASL", 4);
>
> Why not "CORE" ?

Yes I fixed that.

I Also change the revision & test again against linux and Windows 7.

Rudolf
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAkoisy8ACgkQ3J9wPJqZRNXcTQCgz94IvtyR2Ltcj8aOY/C2Dhtt
ayYAnjNw1TzvcxNI//Ie7UPkH/qm9Snz
=2OED
-----END PGP SIGNATURE-----