Re: [coreboot] [PATCH] move fadt.c closer to chipset (VT8237)

[Uwe Hermann]

On Thu, May 28, 2009 at 02:30:20AM +0200, Peter Stuge wrote:
> Rudolf Marek wrote:
> > Following patch moves all vt8237 fadt.c from mainboard/* file to
> > chipset directory just with one common file.
> >
> > Signed-off-by: Rudolf Marek

Yep, very nice. Factoring out common code is always a good thing.

Acked-by: Uwe Hermann
> > +/**
> > Create the Fixed ACPI Description Tables (FADT) for this board.
>
> Please change or yank 'board' here.

Ack.
> > memcpy(header->asl_compiler_id, "IASL", 4);
>
> Why not "CORE" ?

What's the purpose of this field? Does it mean the user
should use 'iasl'? That iasl was used to create the file?
Depending on the meaning, IASL or CORE may be more appropriate,
but I don't know enough about this stuff to decide...

Uwe.