Re: [coreboot] [patch] fix compilation of all i82371eb boards when ACPI tables aren't generated

[Idwer Vollering]

2011/4/1 Stefan Reinauer :
> Idwer Vollering  [110401 20:29]:
> > Signed-off-by: Idwer Vollering
> > Index: src/southbridge/intel/i82371eb/Makefile.inc
> >
> > --- src/southbridge/intel/i82371eb/Makefile.inc (revision 6474)
> > +++ src/southbridge/intel/i82371eb/Makefile.inc (working copy)
> > @@ -24,8 +24,10 @@
> >  driver-y +=  usb.c
> >  driver-y +=  smbus.c
> >  driver-y +=  reset.c
> > +ifeq ($(CONFIG_GENERATE_ACPI_TABLES),y)
> >  driver-$(CONFIG_HAVE_ACPI_TABLES) += fadt.c
> >  driver-$(CONFIG_HAVE_ACPI_TABLES) += acpi_tables.c
> > +endif
>
> should this just be
> driver-$(CONFIG_GENERATE_ACPI_TABLES) += fadt.c
> driver-$(CONFIG_GENERATE_ACPI_TABLES) += acpi_tables.c
>
> instead?

Ah, yes: for f in $(find -name Makefile.inc); do grep -H
CONFIG_GENERATE_ACPI_TABLES $f ; done | wc -l
23
>