[patch] fix compilation of all i82371eb boards when ACPI tables aren't generated

[Idwer Vollering]

When CONFIG_GENERATE_ACPI_TABLES is not used/set, this error appears:

CC         southbridge/intel/i82371eb/fadt.driver.o
src/southbridge/intel/i82371eb/fadt.c:35:35: error: expected ')'
before '*' token
make: *** [build/southbridge/intel/i82371eb/fadt.driver.o] Error 1

These boards are affected (shell command): for f in $(find
src/mainboard/ -name Kconfig); do grep -Hi i82371eb $f ; done | awk -F
/ '{ print $3 "/" $4 }'| sort
abit/be6-ii_v2_0
asus/p2b
asus/p2b-d
asus/p2b-ds
asus/p2b-f
asus/p2b-ls
asus/p3b-f
a-trend/atc-6220
a-trend/atc-6240
azza/pt-6ibd
biostar/m6tba
compaq/deskpro_en_sff_p600
emulation/qemu-x86
gigabyte/ga-6bxc
gigabyte/ga-6bxe
msi/ms6119
msi/ms6147
msi/ms6156
nokia/ip530
soyo/sy-6ba-plus-iii
tyan/s1846

Signed-off-by: Idwer Vollering

---

Index: src/southbridge/intel/i82371eb/Makefile.inc
===================================================================
--- src/southbridge/intel/i82371eb/Makefile.inc (revision 6474)
+++ src/southbridge/intel/i82371eb/Makefile.inc (working copy)
@@ -24,8 +24,10 @@
 driver-y +=  usb.c
 driver-y +=  smbus.c
 driver-y +=  reset.c
+ifeq ($(CONFIG_GENERATE_ACPI_TABLES),y)
 driver-$(CONFIG_HAVE_ACPI_TABLES) += fadt.c
 driver-$(CONFIG_HAVE_ACPI_TABLES) += acpi_tables.c
+endif

romstage-y += early_pm.c
 romstage-y += early_smbus.c

[Stefan Reinauer]

* Idwer Vollering  [110401 20:29]:
> Signed-off-by: Idwer Vollering
> Index: src/southbridge/intel/i82371eb/Makefile.inc
>
> --- src/southbridge/intel/i82371eb/Makefile.inc (revision 6474)
> +++ src/southbridge/intel/i82371eb/Makefile.inc (working copy)
> @@ -24,8 +24,10 @@
>  driver-y +=  usb.c
>  driver-y +=  smbus.c
>  driver-y +=  reset.c
> +ifeq ($(CONFIG_GENERATE_ACPI_TABLES),y)
>  driver-$(CONFIG_HAVE_ACPI_TABLES) += fadt.c
>  driver-$(CONFIG_HAVE_ACPI_TABLES) += acpi_tables.c
> +endif

should this just be
driver-$(CONFIG_GENERATE_ACPI_TABLES) += fadt.c
driver-$(CONFIG_GENERATE_ACPI_TABLES) += acpi_tables.c

instead?

[Idwer Vollering]

2011/4/1 Stefan Reinauer :
> Idwer Vollering  [110401 20:29]:
> > Signed-off-by: Idwer Vollering
> > Index: src/southbridge/intel/i82371eb/Makefile.inc
> >
> > --- src/southbridge/intel/i82371eb/Makefile.inc (revision 6474)
> > +++ src/southbridge/intel/i82371eb/Makefile.inc (working copy)
> > @@ -24,8 +24,10 @@
> >  driver-y +=  usb.c
> >  driver-y +=  smbus.c
> >  driver-y +=  reset.c
> > +ifeq ($(CONFIG_GENERATE_ACPI_TABLES),y)
> >  driver-$(CONFIG_HAVE_ACPI_TABLES) += fadt.c
> >  driver-$(CONFIG_HAVE_ACPI_TABLES) += acpi_tables.c
> > +endif
>
> should this just be
> driver-$(CONFIG_GENERATE_ACPI_TABLES) += fadt.c
> driver-$(CONFIG_GENERATE_ACPI_TABLES) += acpi_tables.c
>
> instead?

Ah, yes: for f in $(find -name Makefile.inc); do grep -H
CONFIG_GENERATE_ACPI_TABLES $f ; done | wc -l
23
>

[Idwer Vollering]

V2.

Signed-off-by: Idwer Vollering

---

Index: src/southbridge/intel/i82371eb/Makefile.inc
===================================================================
--- src/southbridge/intel/i82371eb/Makefile.inc (revision 6474)
+++ src/southbridge/intel/i82371eb/Makefile.inc (working copy)
@@ -24,8 +24,8 @@
 driver-y +=  usb.c
 driver-y +=  smbus.c
 driver-y +=  reset.c
-driver-$(CONFIG_HAVE_ACPI_TABLES) += fadt.c
-driver-$(CONFIG_HAVE_ACPI_TABLES) += acpi_tables.c
+driver-$(CONFIG_GENERATE_ACPI_TABLES) += fadt.c
+driver-$(CONFIG_GENERATE_ACPI_TABLES) += acpi_tables.c

romstage-y += early_pm.c
 romstage-y += early_smbus.c

[Stefan Reinauer]

* Idwer Vollering  [110401 23:00]:
> V2.
>
> Signed-off-by: Idwer Vollering

Acked-by: Stefan Reinauer
> Index: src/southbridge/intel/i82371eb/Makefile.inc
>
> --- src/southbridge/intel/i82371eb/Makefile.inc (revision 6474)
> +++ src/southbridge/intel/i82371eb/Makefile.inc (working copy)
> @@ -24,8 +24,8 @@
>  driver-y +=  usb.c
>  driver-y +=  smbus.c
>  driver-y +=  reset.c
> -driver-$(CONFIG_HAVE_ACPI_TABLES) += fadt.c
> -driver-$(CONFIG_HAVE_ACPI_TABLES) += acpi_tables.c
> +driver-$(CONFIG_GENERATE_ACPI_TABLES) += fadt.c
> +driver-$(CONFIG_GENERATE_ACPI_TABLES) += acpi_tables.c
>
> romstage-y += early_pm.c
>  romstage-y += early_smbus.c