coreboot

coreboot@coreboot.org

39717 discussions

RE: [LinuxBIOS] PATCH: nested spinlock hang when initializing x86 sibling CPUs
by Lu, Yinghai 09 Sep '05

09 Sep '05

Please do not touch SERIAL_CPU_INIT. That doesn't hurt. YH -----Original Message----- From: Steven J. Magnani [mailto:steve@digidescorp.com] Sent: Friday, September 09, 2005 12:59 PM To: Lu, Yinghai; yinghailu(a)gmail.com Cc: linuxbios(a)openbios.org Subject: RE: [LinuxBIOS] PATCH: nested spinlock hang when initializing x86 sibling CPUs Here is a revised patch which works in the Intel world. Let me know if this causes any problems in the AMD world. I'm still planning on making the comment changes to src/config/Options.lb, unless someone thinks I've made things more confusing. PATCH: --- src/cpu/x86/lapic/lapic_cpu_init.c.orig 2005-09-09 09:29:25.156250000 -0500 +++ src/cpu/x86/lapic/lapic_cpu_init.c 2005-09-09 14:54:51.218750000 -0500 @@ -227,20 +227,26 @@ } /* C entry point of secondary cpus */ + +// secondary_cpu_lock is used to serialize initialization of secondary CPUs +// This can be used to avoid interleaved debugging messages. + +static spinlock_t secondary_cpu_lock = SPIN_LOCK_UNLOCKED; + void secondary_cpu_init(void) { atomic_inc(&active_cpus); + #if SERIAL_CPU_INIT == 1 - #if CONFIG_MAX_CPUS>2 - spin_lock(&start_cpu_lock); - #endif + spin_lock(&secondary_cpu_lock); #endif + cpu_initialize(); + #if SERIAL_CPU_INIT == 1 - #if CONFIG_MAX_CPUS>2 - spin_unlock(&start_cpu_lock); - #endif + spin_unlock(&secondary_cpu_lock); #endif + atomic_dec(&active_cpus); stop_this_cpu(); } ------------------------------------------------------------------------ Steven J. Magnani "I claim this network for MARS! www.digidescorp.com Earthling, return my space modulator!" #include <standard.disclaimer>

1 0

RE: [LinuxBIOS] PATCH: nested spinlock hang when initializing x86 sibling CPUs
by Steven J. Magnani 09 Sep '05

09 Sep '05

Here is a revised patch which works in the Intel world. Let me know if this causes any problems in the AMD world. I'm still planning on making the comment changes to src/config/Options.lb, unless someone thinks I've made things more confusing. PATCH: --- src/cpu/x86/lapic/lapic_cpu_init.c.orig 2005-09-09 09:29:25.156250000 -0500 +++ src/cpu/x86/lapic/lapic_cpu_init.c 2005-09-09 14:54:51.218750000 -0500 @@ -227,20 +227,26 @@ } /* C entry point of secondary cpus */ + +// secondary_cpu_lock is used to serialize initialization of secondary CPUs +// This can be used to avoid interleaved debugging messages. + +static spinlock_t secondary_cpu_lock = SPIN_LOCK_UNLOCKED; + void secondary_cpu_init(void) { atomic_inc(&active_cpus); + #if SERIAL_CPU_INIT == 1 - #if CONFIG_MAX_CPUS>2 - spin_lock(&start_cpu_lock); - #endif + spin_lock(&secondary_cpu_lock); #endif + cpu_initialize(); + #if SERIAL_CPU_INIT == 1 - #if CONFIG_MAX_CPUS>2 - spin_unlock(&start_cpu_lock); - #endif + spin_unlock(&secondary_cpu_lock); #endif + atomic_dec(&active_cpus); stop_this_cpu(); } ------------------------------------------------------------------------ Steven J. Magnani "I claim this network for MARS! www.digidescorp.com Earthling, return my space modulator!" #include <standard.disclaimer>

1 0

RE: [LinuxBIOS] PATCH: nested spinlock hang when initializing x86 sibling CPUs
by Lu, Yinghai 09 Sep '05

09 Sep '05

This has nothing to do with AMD or intel. For AMD four ways single core system, or two way dual core system. If you need to set SERIAL_CPU_INIT = 0 , you may need to set loglevel to 7 instead of 8. For 8 ways Opteron system, if you set SERIAL_CPU_INIT=0, the mem on node1-node7, will be init_ecc at the same time to reduce init time from 7x to 1.1x. If intel has NUMA support, there will be the same. But if you need debug info or better output message format, you need to set SERIAL_CPU_INIT = 1. YH ________________________________ From: linuxbios-bounces(a)openbios.org [mailto:linuxbios-bounces@openbios.org] On Behalf Of Steven J. Magnani Sent: Friday, September 09, 2005 9:51 AM To: yinghailu(a)gmail.com Cc: linuxbios(a)openbios.org Subject: RE: [LinuxBIOS] PATCH: nested spinlock hang when initializing x86 sibling CPUs Based on the mainboard config files I see, it looks like the only purpose of SERIAL_CPU_INIT is to work around the nested spinlock issue with Intel hyperthreaded CPUs. I don't think this is the best solution to the problem. To me, 'SERIAL_CPU_INIT' implies a free choice - I can choose whether my CPUs are initialized serially or concurrently, and either choice is acceptable. But that's not the way it works; making the wrong choice on Intel systems causes the system to hang. I think a better solution will do away with SERIAL_CPU_INIT, but might keep the spinlock bracket around cpu_initialize(). The question is how to reconcile the differences between AMD and Intel SMP startup. Can you provide any suggestions from the AMD viewpoint? Steve -----Original Message----- From: yhlu [mailto:yinghailu@gmail.com] Sent: Friday, September 09, 2005 10:01 AM To: Steven J. Magnani Cc: linuxbios(a)openbios.org Subject: Re: [LinuxBIOS] PATCH: nested spinlock hang when initializing x86 sibling CPUs You need to keep SERIAL_CPU_INIT. reason is for AMD K8 cpu_init regarding init_ecc there maybe some conflict on console. You can disable it by set it to 0. YH On 9/9/05, Steven J. Magnani <steve(a)digidescorp.com> wrote: This patch resolves the issue identified in http://openbios.org/pipermail/linuxbios/2005-July/011903.html. Changes: * Remove spinlock bracketing of cpu_initialize() call * Drop SERIAL_CPU_INIT option * (Unrelated) Attempt more descriptive comments for various config options PATCH: --- src/cpu/x86/lapic/lapic_cpu_init.c.orig 2005-09-09 09:29:25.156250000 -0500 +++ src/cpu/x86/lapic/lapic_cpu_init.c 2005-09-09 09:31:59.109375000 -0500 @@ -230,17 +230,16 @@ void secondary_cpu_init(void) { atomic_inc(&active_cpus); -#if SERIAL_CPU_INIT == 1 - #if CONFIG_MAX_CPUS>2 - spin_lock(&start_cpu_lock); - #endif -#endif + + // NOTE: The call to cpu_initialize() used to be bracketed by + // calls to lock and unlock the start_cpu_lock spin lock. + // These were removed to resolve a hang due to nested spin locking + // when secondary CPUs go to initialize their siblings. + // See http://openbios.org/pipermail/linuxbios/2005-July/011903.html. + // It's possible that some other form of concurrency control + // is needed at this level. cpu_initialize(); -#if SERIAL_CPU_INIT == 1 - #if CONFIG_MAX_CPUS>2 - spin_unlock(&start_cpu_lock); - #endif -#endif + atomic_dec(&active_cpus); stop_this_cpu(); } @@ -265,11 +264,9 @@ printk_err("CPU %u would not start!\n", cpu->path.u.apic.apic_id); } -#if SERIAL_CPU_INIT == 1 #if CONFIG_MAX_CPUS>2 udelay(10); #endif -#endif } /* Now loop until the other cpus have finished initializing */ --- src/config/Options.lb.orig 2005-09-09 09:36:27.562500000 -0500 +++ src/config/Options.lb 2005-09-09 09:35:17.125000000 -0500 @@ -188,37 +188,37 @@ default 65536 format "0x%x" export used - comment "Default fallback image size" + comment "ROM_SECTION_SIZE to use for the fallback build." end define ROM_SIZE default none format "0x%x" export used - comment "Size of your ROM" + comment "Total number of bytes allocated for normal and fallback LinuxBIOS images and payloads. Note that the fallback image goes at the end of the ROM, and the normal image at the beginning." end define ROM_IMAGE_SIZE default 65535 format "0x%x" export always - comment "Default image size" + comment "Maximum number of bytes allowed for a LinuxBIOS image. Does not include the payload." end define ROM_SECTION_SIZE default {FALLBACK_SIZE} format "0x%x" export used - comment "Default rom section size" + comment "Default rom section size. Normally, this is calculated in mainboard Config.lb and varies between the normal and fallback builds." end define ROM_SECTION_OFFSET default {ROM_SIZE - FALLBACK_SIZE} format "0x%x" export used - comment "Default rom section offset" + comment "Number of bytes from the beginning of the ROM to the start of the section containing this build (normal or fallback). Normally, this is calculated in mainboard Config.lb." end define PAYLOAD_SIZE default {ROM_SECTION_SIZE - ROM_IMAGE_SIZE} format "0x%x" export always - comment "Default payload size" + comment "Maximum number of bytes allowed for a payload. Normally, this is calculated as above." end define _ROMBASE default {PAYLOAD_SIZE} @@ -479,7 +479,7 @@ export used comment "System clock frequency in MHz" end - + ############################################### # SMP options ############################################### @@ -509,11 +509,6 @@ export used comment "Define to build an MP table" end -define SERIAL_CPU_INIT - default 1 - export always - comment "Serialize CPU init" -end ############################################### # Boot options @@ -533,7 +528,7 @@ default {0xffffffff - ROM_SIZE + ROM_SECTION_OFFSET + 1} format "0x%x" export always - comment "ROM stream start location" + comment "Memory address of this (normal or fallback) build's payload in ROM. Normally, this is calculated as above." end define CONFIG_FS_STREAM default 0 --- src/mainboard/tyan/s2735/Options.lb.orig 2005-09-08 13:35:22.453125000 -0500 +++ src/mainboard/tyan/s2735/Options.lb 2005-09-09 09:21:21.531250000 -0500 @@ -8,7 +8,6 @@ uses CONFIG_MAX_CPUS uses CONFIG_MAX_PHYSICAL_CPUS uses CONFIG_LOGICAL_CPUS -uses SERIAL_CPU_INIT uses CONFIG_IOAPIC uses CONFIG_SMP uses FALLBACK_SIZE @@ -127,8 +126,6 @@ default CONFIG_MAX_PHYSICAL_CPUS=2 default CONFIG_LOGICAL_CPUS=1 -default SERIAL_CPU_INIT=0 - #BTEXT Console #default CONFIG_CONSOLE_BTEXT=1 ------------------------------------------------------------------------ Steven J. Magnani "I claim this network for MARS! www.digidescorp.com Earthling, return my space modulator!" #include <standard.disclaimer> -- LinuxBIOS mailing list LinuxBIOS(a)openbios.org http://www.openbios.org/mailman/listinfo/linuxbios

2 1

[LinuxBIOS] PATCH: nested spinlock hang when initializing x86 sibling CPUs
by Steven J. Magnani 09 Sep '05

09 Sep '05

This patch resolves the issue identified in http://openbios.org/pipermail/linuxbios/2005-July/011903.html. Changes: * Remove spinlock bracketing of cpu_initialize() call * Drop SERIAL_CPU_INIT option * (Unrelated) Attempt more descriptive comments for various config options PATCH: --- src/cpu/x86/lapic/lapic_cpu_init.c.orig 2005-09-09 09:29:25.156250000 -0500 +++ src/cpu/x86/lapic/lapic_cpu_init.c 2005-09-09 09:31:59.109375000 -0500 @@ -230,17 +230,16 @@ void secondary_cpu_init(void) { atomic_inc(&active_cpus); -#if SERIAL_CPU_INIT == 1 - #if CONFIG_MAX_CPUS>2 - spin_lock(&start_cpu_lock); - #endif -#endif + + // NOTE: The call to cpu_initialize() used to be bracketed by + // calls to lock and unlock the start_cpu_lock spin lock. + // These were removed to resolve a hang due to nested spin locking + // when secondary CPUs go to initialize their siblings. + // See http://openbios.org/pipermail/linuxbios/2005-July/011903.html. + // It's possible that some other form of concurrency control + // is needed at this level. cpu_initialize(); -#if SERIAL_CPU_INIT == 1 - #if CONFIG_MAX_CPUS>2 - spin_unlock(&start_cpu_lock); - #endif -#endif + atomic_dec(&active_cpus); stop_this_cpu(); } @@ -265,11 +264,9 @@ printk_err("CPU %u would not start!\n", cpu->path.u.apic.apic_id); } -#if SERIAL_CPU_INIT == 1 #if CONFIG_MAX_CPUS>2 udelay(10); #endif -#endif } /* Now loop until the other cpus have finished initializing */ --- src/config/Options.lb.orig 2005-09-09 09:36:27.562500000 -0500 +++ src/config/Options.lb 2005-09-09 09:35:17.125000000 -0500 @@ -188,37 +188,37 @@ default 65536 format "0x%x" export used - comment "Default fallback image size" + comment "ROM_SECTION_SIZE to use for the fallback build." end define ROM_SIZE default none format "0x%x" export used - comment "Size of your ROM" + comment "Total number of bytes allocated for normal and fallback LinuxBIOS images and payloads. Note that the fallback image goes at the end of the ROM, and the normal image at the beginning." end define ROM_IMAGE_SIZE default 65535 format "0x%x" export always - comment "Default image size" + comment "Maximum number of bytes allowed for a LinuxBIOS image. Does not include the payload." end define ROM_SECTION_SIZE default {FALLBACK_SIZE} format "0x%x" export used - comment "Default rom section size" + comment "Default rom section size. Normally, this is calculated in mainboard Config.lb and varies between the normal and fallback builds." end define ROM_SECTION_OFFSET default {ROM_SIZE - FALLBACK_SIZE} format "0x%x" export used - comment "Default rom section offset" + comment "Number of bytes from the beginning of the ROM to the start of the section containing this build (normal or fallback). Normally, this is calculated in mainboard Config.lb." end define PAYLOAD_SIZE default {ROM_SECTION_SIZE - ROM_IMAGE_SIZE} format "0x%x" export always - comment "Default payload size" + comment "Maximum number of bytes allowed for a payload. Normally, this is calculated as above." end define _ROMBASE default {PAYLOAD_SIZE} @@ -479,7 +479,7 @@ export used comment "System clock frequency in MHz" end - + ############################################### # SMP options ############################################### @@ -509,11 +509,6 @@ export used comment "Define to build an MP table" end -define SERIAL_CPU_INIT - default 1 - export always - comment "Serialize CPU init" -end ############################################### # Boot options @@ -533,7 +528,7 @@ default {0xffffffff - ROM_SIZE + ROM_SECTION_OFFSET + 1} format "0x%x" export always - comment "ROM stream start location" + comment "Memory address of this (normal or fallback) build's payload in ROM. Normally, this is calculated as above." end define CONFIG_FS_STREAM default 0 --- src/mainboard/tyan/s2735/Options.lb.orig 2005-09-08 13:35:22.453125000 -0500 +++ src/mainboard/tyan/s2735/Options.lb 2005-09-09 09:21:21.531250000 -0500 @@ -8,7 +8,6 @@ uses CONFIG_MAX_CPUS uses CONFIG_MAX_PHYSICAL_CPUS uses CONFIG_LOGICAL_CPUS -uses SERIAL_CPU_INIT uses CONFIG_IOAPIC uses CONFIG_SMP uses FALLBACK_SIZE @@ -127,8 +126,6 @@ default CONFIG_MAX_PHYSICAL_CPUS=2 default CONFIG_LOGICAL_CPUS=1 -default SERIAL_CPU_INIT=0 - #BTEXT Console #default CONFIG_CONSOLE_BTEXT=1 ------------------------------------------------------------------------ Steven J. Magnani "I claim this network for MARS! www.digidescorp.com Earthling, return my space modulator!" #include <standard.disclaimer>

3 3

RE: [LinuxBIOS] PATCH: relocate GDT before invoking payload
by Lu, Yinghai 09 Sep '05

09 Sep '05

I'm ok with this patch. YH ________________________________ From: linuxbios-bounces(a)openbios.org [mailto:linuxbios-bounces@openbios.org] On Behalf Of Steven J. Magnani Sent: Friday, September 09, 2005 9:35 AM To: yinghailu(a)gmail.com Cc: linuxbios(a)openbios.org Subject: RE: [LinuxBIOS] PATCH: relocate GDT before invoking payload QNX Neutrino doesn't set up its own GDT right away. Its startup code has some defensive logic that attempts to put the system into a known state. This causes an exception when booted from LinuxBIOS, if its GDT got trashed when elfboot() loaded the Neutrino image. See the hyperlink below for more discussion. The fix seems straightforward, and the increased amount of "table" memory very modest. Do you object to this patch? Steve -----Original Message----- From: yhlu [mailto:yinghailu@gmail.com] Sent: Friday, September 09, 2005 10:03 AM To: Steven J. Magnani Cc: linuxbios(a)openbios.org Subject: Re: [LinuxBIOS] PATCH: relocate GDT before invoking payload why? The payload will have its own GDT. YH On 9/9/05, Steven J. Magnani <steve(a)digidescorp.com> wrote: I posted this patch previously; see http://openbios.org/pipermail/linuxbios/2005-August/012063.html for the original issue. Here's another chance to comment before I commit it. PATCH: --- src/arch/i386/boot/tables.c.orig 2005-09-08 13:35:39.125000000 -0500 +++ src/arch/i386/boot/tables.c 2005-08-16 16:17:41.766000000 -0500 @@ -7,6 +7,32 @@ #include <arch/acpi.h> #include "linuxbios_table.h" +// Global Descriptor Table, defined in c_start.S +extern uint8_t gdt; +extern uint8_t gdt_end; + +/* i386 lgdt argument */ +struct gdtarg { + unsigned short limit; + unsigned int base; +} __attribute__((packed)); + +// Copy GDT to new location and reload it +// 2003-07 by SONE Takeshi +// Ported from Etherboot to LinuxBIOS 2005-08 by Steve Magnani +void move_gdt(unsigned long newgdt) +{ + uint16_t num_gdt_bytes = &gdt_end - &gdt; + struct gdtarg gdtarg; + + printk_debug("Moving GDT to %#lx...", newgdt); + memcpy((void*)newgdt, &gdt, num_gdt_bytes); + gdtarg.base = newgdt; + gdtarg.limit = num_gdt_bytes - 1; + __asm__ __volatile__ ("lgdt %0\n\t" : : "m" (gdtarg)); + printk_debug("ok\n"); +} + struct lb_memory *write_tables(void) { unsigned long low_table_start, low_table_end; @@ -45,6 +71,10 @@ low_table_end = 0x500; } + // Relocate the GDT to reserved memory, so it won't get clobbered + move_gdt(low_table_end); + low_table_end += &gdt_end - &gdt; + /* The linuxbios table must be in 0-4K or 960K-1M */ write_linuxbios_table( low_table_start, low_table_end, ------------------------------------------------------------------------ Steven J. Magnani "I claim this network for MARS! www.digidescorp.com Earthling, return my space modulator!" #include <standard.disclaimer> -- LinuxBIOS mailing list LinuxBIOS(a)openbios.org http://www.openbios.org/mailman/listinfo/linuxbios

1 0

[LinuxBIOS] PATCH: relocate GDT before invoking payload
by Steven J. Magnani 09 Sep '05

09 Sep '05

I posted this patch previously; see http://openbios.org/pipermail/linuxbios/2005-August/012063.html for the original issue. Here's another chance to comment before I commit it. PATCH: --- src/arch/i386/boot/tables.c.orig 2005-09-08 13:35:39.125000000 -0500 +++ src/arch/i386/boot/tables.c 2005-08-16 16:17:41.766000000 -0500 @@ -7,6 +7,32 @@ #include <arch/acpi.h> #include "linuxbios_table.h" +// Global Descriptor Table, defined in c_start.S +extern uint8_t gdt; +extern uint8_t gdt_end; + +/* i386 lgdt argument */ +struct gdtarg { + unsigned short limit; + unsigned int base; +} __attribute__((packed)); + +// Copy GDT to new location and reload it +// 2003-07 by SONE Takeshi +// Ported from Etherboot to LinuxBIOS 2005-08 by Steve Magnani +void move_gdt(unsigned long newgdt) +{ + uint16_t num_gdt_bytes = &gdt_end - &gdt; + struct gdtarg gdtarg; + + printk_debug("Moving GDT to %#lx...", newgdt); + memcpy((void*)newgdt, &gdt, num_gdt_bytes); + gdtarg.base = newgdt; + gdtarg.limit = num_gdt_bytes - 1; + __asm__ __volatile__ ("lgdt %0\n\t" : : "m" (gdtarg)); + printk_debug("ok\n"); +} + struct lb_memory *write_tables(void) { unsigned long low_table_start, low_table_end; @@ -45,6 +71,10 @@ low_table_end = 0x500; } + // Relocate the GDT to reserved memory, so it won't get clobbered + move_gdt(low_table_end); + low_table_end += &gdt_end - &gdt; + /* The linuxbios table must be in 0-4K or 960K-1M */ write_linuxbios_table( low_table_start, low_table_end, ------------------------------------------------------------------------ Steven J. Magnani "I claim this network for MARS! www.digidescorp.com Earthling, return my space modulator!" #include <standard.disclaimer>

2 2

RE: [LinuxBIOS] PATCH: correct arguments to pnp_set_drq
by Lu, Yinghai 08 Sep '05

08 Sep '05

Good, maybe this is reason why floppy have problem in Kernel.... YH -----Original Message----- From: linuxbios-bounces(a)openbios.org [mailto:linuxbios-bounces@openbios.org] On Behalf Of Steven J. Magnani Sent: Thursday, September 08, 2005 1:16 PM To: linuxbios(a)openbios.org Subject: [LinuxBIOS] PATCH: correct arguments to pnp_set_drq This patch corrects an apparent bug in the definition of pnp_set_drq(). See http://openbios.org/pipermail/linuxbios/2005-May/011605.html for a description of the issue. PATCH: BUG FIX: arguments to pnp_set_drq are transposed --- src/devices/pnp_device.c.orig 2005-09-08 13:34:52.859375000 -0500 +++ src/devices/pnp_device.c 2005-09-08 13:40:16.671875000 -0500 @@ -52,7 +52,7 @@ pnp_write_config(dev, index, irq); } -void pnp_set_drq(device_t dev, unsigned drq, unsigned index) +void pnp_set_drq(device_t dev, unsigned index, unsigned drq) { /* Index == 0x74 */ pnp_write_config(dev, index, drq & 0xff); ------------------------------------------------------------------------ Steven J. Magnani "I claim this network for MARS! www.digidescorp.com Earthling, return my space modulator!" #include <standard.disclaimer> -- LinuxBIOS mailing list LinuxBIOS(a)openbios.org http://www.openbios.org/mailman/listinfo/linuxbios

1 0

[LinuxBIOS] PATCH: correct arguments to pnp_set_drq
by Steven J. Magnani 08 Sep '05

08 Sep '05

This patch corrects an apparent bug in the definition of pnp_set_drq(). See http://openbios.org/pipermail/linuxbios/2005-May/011605.html for a description of the issue. PATCH: BUG FIX: arguments to pnp_set_drq are transposed --- src/devices/pnp_device.c.orig 2005-09-08 13:34:52.859375000 -0500 +++ src/devices/pnp_device.c 2005-09-08 13:40:16.671875000 -0500 @@ -52,7 +52,7 @@ pnp_write_config(dev, index, irq); } -void pnp_set_drq(device_t dev, unsigned drq, unsigned index) +void pnp_set_drq(device_t dev, unsigned index, unsigned drq) { /* Index == 0x74 */ pnp_write_config(dev, index, drq & 0xff); ------------------------------------------------------------------------ Steven J. Magnani "I claim this network for MARS! www.digidescorp.com Earthling, return my space modulator!" #include <standard.disclaimer>

1 0

[LinuxBIOS] RE: CMOS options questions
by Steven J. Magnani 08 Sep '05

08 Sep '05

See http://openbios.org/pipermail/linuxbios/2005-August/012255.html for an explanation of the issue that spawned this patch. I've run out of time for a complete solution, so as a compromise I propose a patch that prevents LB from modifying CMOS when HAVE_OPTION_TABLE = 0: PATCH: Don't write to CMOS when HAVE_OPTION_TABLE = 0. This allows single-image (normal) LinuxBIOS to co-exist with factory BIOSs whose CMOS usage is incompatible (i.e. Intel XE7501DevKit). --- src/pc80/mc146818rtc.c.orig 2005-09-08 13:35:36.312500000 -0500 +++ src/pc80/mc146818rtc.c 2005-09-08 14:10:06.187500000 -0500 @@ -127,6 +127,8 @@ int cmos_invalid, checksum_invalid; printk_debug("RTC Init\n"); + +#if HAVE_OPTION_TABLE /* See if there has been a CMOS power problem. */ x = CMOS_READ(RTC_VALID); cmos_invalid = !(x & RTC_VRT); @@ -160,19 +162,25 @@ } #endif } +#endif + + /* Setup the real time clock */ + CMOS_WRITE(RTC_CONTROL_DEFAULT, RTC_CONTROL); + /* Setup the frequency it operates at */ + CMOS_WRITE(RTC_FREQ_SELECT_DEFAULT, RTC_FREQ_SELECT); + +#if HAVE_OPTION_TABLE /* See if there is a LB CMOS checksum error */ checksum_invalid = !rtc_checksum_valid(LB_CKS_RANGE_START, LB_CKS_RANGE_END,LB_CKS_LOC); if(checksum_invalid) printk_debug("Invalid CMOS LB checksum\n"); - /* Setup the real time clock */ - CMOS_WRITE(RTC_CONTROL_DEFAULT, RTC_CONTROL); - /* Setup the frequency it operates at */ - CMOS_WRITE(RTC_FREQ_SELECT_DEFAULT, RTC_FREQ_SELECT); /* Make certain we have a valid checksum */ rtc_set_checksum(PC_CKS_RANGE_START, PC_CKS_RANGE_END,PC_CKS_LOC); +#endif + /* Clear any pending interrupts */ (void) CMOS_READ(RTC_INTR_FLAGS); } ------------------------------------------------------------------------ Steven J. Magnani "I claim this network for MARS! www.digidescorp.com Earthling, return my space modulator!" #include <standard.disclaimer>

1 0

[LinuxBIOS] PATCH: cygwin compilation of LinuxBIOS
by Steven J. Magnani 08 Sep '05

08 Sep '05

I'm starting to merge my source tree into the mainline. Ultimately this will include support for Intel's E7501 Xeon development kit, including the ICH3-S southbridge and the SMSC LPC47B272 Super I/O chips. Where my changes touch existing code, I'm sending out patches for review first. Constructive comments welcomed! One point about cygwin (cross-)compilation, for the record: both cmos.options and util/newconfig/config.g must be in UNIX (\n) format. The build fails if they are in DOS (\r\n) format. If you download the source with something like TortoiseSVN, text files arrive in DOS format and these particular files need to be run through dos2unix. --Steve PATCH: Modifications for building LinuxBIOS under cygwin. Remove unnecessary #include that prevents build_opt_tbl from cross-compiling with gcc 3.4.3. Add wildcards to 'clean' rules so executables ending in .exe get deleted. Added nrv2b to the list of files that are cleaned. --- util/options/build_opt_tbl.c.orig 2005-09-08 13:36:06.156250000 -0500 +++ util/options/build_opt_tbl.c 2005-09-08 14:17:28.875000000 -0500 @@ -1,6 +1,5 @@ #include <stdio.h> #include <stdlib.h> -#include <sys/io.h> #include <string.h> #include <ctype.h> #include <errno.h> --- src/config/Config.lb.orig 2005-09-08 14:41:03.953125000 -0500 +++ src/config/Config.lb 2005-09-08 14:36:47.734375000 -0500 @@ -153,9 +153,9 @@ action "rm -f linuxbios" action "rm -f ldscript.ld" action "rm -f a.out *.s *.l *.o *.E *.inc" - action "rm -f TAGS tags romcc" - action "rm -f docipl buildrom chips.c *chip.c linuxbios_ram* linuxbios_pay*" - action "rm -f build_opt_tbl option_table.c crt0.S" + action "rm -f TAGS tags romcc*" + action "rm -f docipl buildrom* chips.c *chip.c linuxbios_ram* linuxbios_pay*" + action "rm -f build_opt_tbl* nrv2b* option_table.c crt0.S" end # do standard config files that the user need not specify

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

coreboot