coreboot

coreboot@coreboot.org

24 participants
39543 discussions

New Defects reported by Coverity Scan for coreboot
by scan-admin＠coverity.com 24 Mar '24

24 Mar '24

Hi, Please find the latest report on new defect(s) introduced to coreboot found with Coverity Scan. 1 new defect(s) introduced to coreboot found with Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 1 of 1 defect(s) ** CID 1540835: Null pointer dereferences (REVERSE_INULL) /util/amdfwtool/amdfwtool.c: 533 in fill_dir_header() ________________________________________________________________________________________________________ *** CID 1540835: Null pointer dereferences (REVERSE_INULL) /util/amdfwtool/amdfwtool.c: 533 in fill_dir_header() 527 psp_directory_table *dir = directory; 528 bios_directory_table *bdir = directory; 529 /* The cookies have same offsets. */ 530 uint32_t cookie = ((psp_directory_table *)directory)->header.cookie; 531 uint32_t table_size = 0; 532 >>> CID 1540835: Null pointer dereferences (REVERSE_INULL) >>> Null-checking "directory" suggests that it may be null, but it has already been dereferenced on all paths leading to the check. 533 if (ctx == NULL || directory == NULL) { 534 fprintf(stderr, "Calling %s with NULL pointers\n", __func__); 535 return; 536 } 537 538 /* The table size needs to be 0x1000 aligned. So align the end of table. */ ________________________________________________________________________________________________________ To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=u001.AxU2LYlgjL6eX23u9ErQy-2…

1 0

[PATCH] Add missing malloc check in libpayload
by Abhinav Srivastava 23 Mar '24

23 Mar '24

Fixes #496: Add NULL check for malloc in get_option_as_string to prevent potential crashes from unhandled memory allocation failures. Signed-off-by: Abhinav Srivastava <atg271(a)gmail.com> --- payloads/libpayload/drivers/options.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/payloads/libpayload/drivers/options.c b/payloads/libpayload/drivers/options.c index b6d234222d..7571fd739a 100644 --- a/payloads/libpayload/drivers/options.c +++ b/payloads/libpayload/drivers/options.c @@ -318,6 +318,9 @@ int get_option_as_string(const struct nvram_accessor *nvram, struct cb_cmos_opti /* extra byte to ensure 0-terminated strings */ raw = malloc(cmos_length+1); + if (!raw) { + return -1; + } memset(raw, 0, cmos_length+1); int ret = get_option_with(nvram, option_table, raw, name); -- 2.34.1

1 0

2024-03-20 - coreboot Leadership Meeting Minutes
by mina＠coreboot.org 21 Mar '24

21 Mar '24

# 2024-03-20 - coreboot Leadership Meeting Minutes ## Attendees Martin Roth, Felix Held, Felix Singer, Jay Talbott, Matt DeVillier, Nicholas Chin, David Hendricks, Arthur Heymans, Mina Asante, Julius Werner,Christian Walter, Max Brune, Jon Murphy, Karthik, Patrick Georgi. ## Announcements * FOSSY conference: August 1-4 2024 in Portland, Oregon, USA [https://sfconservancy.org/fossy/]. * OSFC will be in Bochum Germany - September 3-5 - [https://www.osfc.io/]. ## Open Action Items * 2024-03-20 * [Open] Martin: Set up a new meeting link for the next leadership meeting. * [Open] Martin: Add a note to the gerrit guidelines to email the leadership. * 2024-03-06 * [Open] Martin: To update documentation on gerrit contributing guidelines. * https://doc.coreboot.org/contributing/index.html * 2024-01-10 * [Open] Werner: Push patch based on https://ticket.coreboot.org/issues/522 * Nico: https://review.coreboot.org/q/topic:enforce_region_api * Open Daniel: Look at how we want to localize (non console) strings for coreboot. Long term project. ## Minutes ### [Martin] BigBlueButton * The invite for this meeting still has the google chat link on it. We should have Patrick cancel his invite and set up a new one. * The BBB version that the SFC offers is from 2021 and has issues on mobile. There could also be unfixed CFEs (speculation). * Do we want to switch back to Google chat until the SFC can update to a newer version? Martin can set up an open invite for up to 100 users. $20 per month (I believe). * Can also use OSFF - 250 people, record, etc - everyone can join. * Decision: switch back to Google Meet ### [Martin] Adding Max Brune and Jon Murphy as core developers. * | Name | Patches | Reviews | Comments |First Patch | |------------------|---------|---------|----------|------------| | Maximilian Brune | 67 | 88 | 43 | 2022-05-16 | | Jon Murphy | 115 | 130 | 29 | 2022-02-24 | * Others who could be considered, but we’d like to see more community involvement, reviews, and/or comments from before considering them. * Frans Hendriks * Bora Guvendik * Keith Hui * Maulik Vaghela * Naresh Solanki * Tyler Wang * Varshit B Pandya * Kapil Porwal * If anyone feels that I’m mistaken about people in either group, please reach out to me or the leadership about these people. * [FelixH] We should only look at the number of commits and things from the past 2 years instead of over the entire span that they’ve been working on the project. * [Martin] I can recalculate who other than Max & Jon could be considered. * Decision: Only look at the past 2 years? * [Felix] How should we react when people don’t do a good job submitting code? * [Martin] I think that the leadership should talk with the user. * [MattD] No formal policy - let the leadership handle it. * TODO: Add a note to the gerrit guidelines to email the leadership ### [Martin] RFC: Link Time Optimization [LTO] * Jacob Garber pushed patches a few years ago to get GCC working - Arthur took these over. See Jacob’s initial email: [https://mail.coreboot.org/hyperkitty/list/coreboot@coreboot.org/message/JII…] * Working on adding clang - works differently & only works with specific linkers. [https://mail.coreboot.org/hyperkitty/search?q=lto&page=1&mlist=coreboot%40c…] * Do we want to make this a default? * [Martin] We can decide that after testing. * [Arthur] ARM (not arm64) is broken - maybe the toolchain is broken. Arm builds don’t even complete. * Would there be a reason to keep non-LTO? * Maybe to debug issues and see if they’re caused by LTO. * To add LLVM with LTO we need to add LLD as part of the project when building LLVM. * How does this affect our linker scripts? * LLD doesn’t understand “=.” but setting a variable works. ### [Martin] Bugs * Large number of outstanding bugs - how can we close these? No good solution? * Reduce barriers * Introducing single sign-on would help. * Having the email to the mailing list seems to help. * Being able to reply to the email and have it show up in the bug would help. * Why is tracker.coreboot.org down right now? * Is there any progress integrating with Gerrit? * Felix would like to move away from redmine. Highly depends on plugins and there isn’t good modern functionality. Removed support from open-connect - so people can’t use * Propose we switch to forgejo for bug tracking. * Can we use our current logins from gerrit, or does it require a new login? This is the biggest issue we’ve heard from users with redmine. * Does this help integration with gerrit? * What are we looking for? * Links from bugids from gerrit to the ticket. * Yes? I think we can do this just with gerrit. The same as we do with the CB: links. * Decision: Let’s look at Forgejo and see ### [Martin] Coverity issues * Current open issues spreadsheet * [chart of issues by area] (https://docs.google.com/spreadsheets/d/e/2PACX-1vRYUlOLQTysbdPQoOKaCnRN_K4C… 6gATqtvgDlzSl1S4DaijcTyF7yAAs3qm/pubchart?oid=502535263&format=interactive). * [chart of issues by type] (https://docs.google.com/spreadsheets/d/e/2PACX-1vRYUlOLQTysbdPQoOKaCnRN_K4C… 6gATqtvgDlzSl1S4DaijcTyF7yAAs3qm/pubchart?oid=1369215095&format=interactive). * Link to the coreboot project coverity:[https://scan.coverity.com/projects/coreboot]. * As an alternative to coverity, Felix is adding a code-checker Docker container, and we’ll be moving to it from the current scan-build website. This is not a replacement for coverity, just a nicer interface to the current scan-build that we’re already doing. * [https://codechecker.readthedocs.io/en/latest/]. * coreboot.org/scan-build is currently broken. :( # Next meeting * April 3, 2024. * [coreboot Calendar](https://coreboot.org/calendar.html). # Notice * Decisions shown here are not necessarily final, and are based on the current information available. If there are questions or comments about decisions made, or additional information to present, please put it on the leadership meeting agenda and show up if possible to discuss it. Of course items may also be discussed on the mailing list, but as it's difficult to interpret tone over email, controversial topics frequently do not have good progress in those discussions. For particularly difficult issues, it may be best to try to schedule another meeting. # coreboot leadership meeting minutes [2024-03-20](https://docs.google.com/document/d/1NRXqXcLBp5pFkHiJbrLdv3Spqh1… 1).

1 0

BootGuard policy decoder?
by mr gadha 20 Mar '24

20 Mar '24

Are there any known tools for decoding the BootGuard policy? I’m new to coreboot but have a system that I was interested in investigating adding support for it. The flash image has BootGuard signatures, but at least some parts of the UEFI area of the flash are modifiable (variables, logo, etc). I’m wondering if the DXE area is even protected at all… Or does one just abandon any attempt as soon as a BootGuard header is seen? Thanks!

4 4

Re: Gitiles broken?
by Martin Roth 20 Mar '24

20 Mar '24

Hey Julius, not a problem to bring it up. I'm sure that others were noticing it as well and just not saying anything. I just added notices to topics in irc, slack, and discord. I'll see what options we have for putting the GitHub browse link into Gerrit. Martin Mar 19, 2024 at 17:46 by jwerner(a)google.com: > Whoops, sorry for the noise then. I felt like I vaguely remembered > hearing something about it but then I guess I didn't search far enough > back in trying to find it in the mailing list and meeting notes. > > I don't suppose there's any (easy) way to get links to GitHub into > Gerrit in the repository list? I don't really care about which backend > we use, but I usually start searching on Gerrit when I'm trying to > remember how to browse the code online.

1 0

Gitiles broken?
by Julius Werner 20 Mar '24

20 Mar '24

Hi, It seems that coreboot's Gitiles has broken somehow? When I click the little SHA next to "Patchset X" on a commit, I'm just getting redirected to that commit again. When I go to BROWSE > Repositories > coreboot > Branches and click "main", nothing happens. When I directly go to https://review.coreboot.org/plugins/gitiles/coreboot, it says "Not Found".

3 2

coreboot Meetings Announcement And Agenda Call
by mina＠coreboot.org 19 Mar '24

19 Mar '24

Dear community, Please note that the upcoming coreboot leadership meeting is tomorrow, March 20, 2024.[1] You are welcome to review and update the current agenda items with matters you wish to see addressed during the meeting.[2] ## Current Agenda ### [Martin] Adding Max Brune and Jon Murphy as core developers. * | Name | Patches | Reviews | Comments|First Patch| |------------------|---------|---------|---------|-----------| | Maximilian Brune | 67 | 88 | 43 | 2022-05-16| | | | | | | | Jon Murphy | 115 | 130 | 29 | 2022-02-24| * Others who could be considered, but we’d like to see more community involvement, reviews, and/or comments from before considering them. * Frans Hendriks * Bora Guvendik * Keith Hui * Maulik Vaghela * Naresh Solanki * Tyler Wang * Varshit B Pandya * Kapil Porwal * If anyone feels that I’m mistaken about people in either group, please reach out to me or the leadership about these people. ### [Martin] RFC: Link Time Optimization ### [Martin] Bugs ### [Martin] Coverity issues * Current open issues spreadsheet [coreboot coverity issues](https://docs.google.com/spreadsheets/d/170ZaS8sRz8qh1lFm_088LzoBaL1…. * [chart of issues by area] (https://docs.google.com/spreadsheets/d/e/2PACX-1vRYUlOLQTysbdPQoOKaCnRN_K4C… 6gATqtvgDlzSl1S4DaijcTyF7yAAs3qm/pubchart?oid=502535263&format=interactive). * [chart of issues by type] (https://docs.google.com/spreadsheets/d/e/2PACX-1vRYUlOLQTysbdPQoOKaCnRN_K4C… 6gATqtvgDlzSl1S4DaijcTyF7yAAs3qm/pubchart?oid=1369215095&format=interactive). * Link to the coreboot project coverity:(https://scan.coverity.com/projects/coreboot) ## Announcements * FOSSY conference: August 1-4 2024 in Portland, Oregon, USA * https://sfconservancy.org/fossy/ [1](https://coreboot.org/calendar.html). [2](https://docs.google.com/document/d/1NRXqXcLBp5pFkHiJbrLdv3Spqh1Hu086HYkK….

1 0

coreboot Meetings Announcement And Agenda Call
by mina＠coreboot.org 18 Mar '24

18 Mar '24

Dear community, Kindly note that the upcoming coreboot leadership meeting is scheduled for Wednesday, March 20, 2024.[1] Please take a moment to update the current agenda items with matters you wish to see addressed during the meeting. [2] [1](https://www.coreboot.org/calendar.html). [2](https://docs.google.com/document/d/1NRXqXcLBp5pFkHiJbrLdv3Spqh1Hu086HYkK….

1 0

[coreboot - Bug #121] T520: Hangs in OS
by Anastasios Koutian 16 Mar '24

16 Mar '24

Issue #121 has been updated by Anastasios Koutian. Anastasios Koutian wrote in #note-86: > Martin Zwicknagl wrote in #note-46: > > Hello, > > > > I can report, that I had NO freezes for a month now. > > > > During a RAM upgrade to 16GB I have replaced one 2GB Samsung SODIMM (2GB 1Rx8 PC3-10600s-09-10-ZZZ, M471B5773CHS-CH9 1149) > > with a SODIMM [Crucial CT102464BF160B 8GB Speicher (DDR3L, 1600 MT/s, PC3L-12800, SODIMM, 204-Pin)]. > > The laptop is now using two identical Crucial SODIMMs. > > > > The problem is gone. I do not need any ``intel_idle.max_cstate`` tricks anymore. My T520 is using all cores, hyperthreading, all cstates (and turbo boost). > > > > I think ticket 178 is also solved. Who can close 178? > > > > Cheeers > > Martin > > Hello all, > > I installed the exact same SODIMMs (Crucial CT102464BF160B) as the message quoted above and achieved four days continuous uptime with no issues. > I eventually had to reboot due to a necessary update, so it might be a premature conclusion. I will keep the system running for as long as I can to confirm. > > I haven't gotten around to comparing with MSRs on stock firmware yet, but will once I have spare time. After testing for two weeks, it became clear that the problem is still present, but with different symptoms: the system freezes for a short time and then reboots. Previously, it would freeze indefinitely. ---------------------------------------- Bug #121: T520: Hangs in OS https://ticket.coreboot.org/issues/121#change-1794 * Author: Firstname Lastname * Status: In Progress * Priority: Normal * Category: chipset configuration * Start date: 2017-06-09 * Affected hardware: SNB, IVY * Affected OS: - ---------------------------------------- I have been running coreboot since 2017.04.15 and have experienced hangs ever since then. It was suggested by folk on the IRC that I run memtest to check for incorrect raminit causing errors, however I have run memtest for 12 hours straight with no errors. Due to the ambiguous nature of the hangs (immediate freeze with no warning signs, audio gets stuck repeating the last 50ms or so of noise, not sure what this effect is called) I don't have much useful information other than the .config and dmesg. However one thing I can say with high confidence is that the hangs occur significantly more frequently in Linux (*buntu distros) than Windows 10. Within an hour of launching Linux a hang is likely, whereas Windows typically runs for many hours before a hang occurs. I considered this an insignificant anecdotal anomaly at first but over the course of the nearly 2 months I have been running coreboot it seems to be a solid trend. The hangs occur anywhere, typically during mere desktop usage or basic web browsing. Additionally there is another form of hang I experience where the screen goes black except for some sort of graphical corruption down the left side (http://i.imgur.com/4zWrlpX.jpg), whether this is related to the more common total freeze hangs I don't know but I figured I should include it nonetheless. These hangs only occur about 1:20 compared to the regular hangs. ---Files-------------------------------- config (20.7 KB) dmesg.txt (57.3 KB) cbmem-raminit.txt (62 KB) lspci.txt (29.6 KB) cpuinfo.txt (3.94 KB) defconfig (1023 Bytes) defconfig (699 Bytes) -- You have received this notification because you have either subscribed to it, or are involved in it. To change your notification preferences, please click here: https://ticket.coreboot.org/my/account

1 0

[coreboot - Bug #327] MBOX3, OperationRegion (OPRG, SystemMemory, ASLS, 0x2000) causes windows uefi tianocore BSOD ACPI_BIOS_ERROR
by Joel Linn 16 Mar '24

16 Mar '24

Issue #327 has been updated by Joel Linn. Works, setting 0x400 also boots the Win11 PE environment that BSODs with 0x2000 ---------------------------------------- Bug #327: MBOX3, OperationRegion (OPRG, SystemMemory, ASLS, 0x2000) causes windows uefi tianocore BSOD ACPI_BIOS_ERROR https://ticket.coreboot.org/issues/327#change-1793 * Author: xinhua wang * Status: New * Priority: Normal * Start date: 2021-12-30 ---------------------------------------- https://review.coreboot.org/c/coreboot/+/27711/7/src/drivers/intel/gma/acpi… this line .. OperationRegion (OPRG, SystemMemory, ASLS, 0x2000) the 0x2000 will cause BSOD ACPI_BIOS_ERROR when booting installer, os, etc When set to 0x1000 windows UEFI tianocore mode boots fine ---Files-------------------------------- dmesg.txt (76.9 KB) results.log (204 KB) -- You have received this notification because you have either subscribed to it, or are involved in it. To change your notification preferences, please click here: https://ticket.coreboot.org/my/account

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

coreboot