Dave Frodin (dave.frodin(a)se-eng.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/2040
-gerrit
commit fdf790b187d668bb25a88c23919846c70371f08f
Author: Dave Frodin <dave.frodin(a)se-eng.com>
Date: Sat Dec 15 13:24:02 2012 -0700
libpayload: Check if serial console h/w is present before using
The serial_io_havechar() and serial_io_getchar() functions will
always see keystrokes available if the serial hardware isn't
actually there. We will still output chars to non-existant
hardware to allow virtual hardware to capture them.
Change-Id: I04e85157b6b7a185448abab352b5417a798a397a
Signed-off-by: Dave Frodin <dave.frodin(a)se-eng.com>
---
payloads/libpayload/drivers/serial.c | 12 ++++++++++++
1 file changed, 12 insertions(+)
diff --git a/payloads/libpayload/drivers/serial.c b/payloads/libpayload/drivers/serial.c
index c0200af..cd00a13 100644
--- a/payloads/libpayload/drivers/serial.c
+++ b/payloads/libpayload/drivers/serial.c
@@ -35,6 +35,8 @@
#define MEMBASE (phys_to_virt(lib_sysinfo.serial->baseaddr))
#define DIVISOR(x) (115200 / x)
+static int serial_io_hardware_is_present = 1;
+
#ifdef CONFIG_SERIAL_SET_SPEED
static void serial_io_hardware_init(int port, int speed, int word_bits, int parity, int stop_bits)
{
@@ -107,6 +109,12 @@ void serial_init(void)
#endif
console_add_input_driver(&consin);
console_add_output_driver(&consout);
+
+ /* check to see if there's actually serial port h/w */
+ if (lib_sysinfo.ser_ioport) {
+ if( (inb(IOBASE + 0x05)==0xFF) && (inb(IOBASE + 0x06)==0xFF) )
+ serial_io_hardware_is_present = 0;
+ }
}
static void serial_io_putchar(unsigned int c)
@@ -118,11 +126,15 @@ static void serial_io_putchar(unsigned int c)
static int serial_io_havechar(void)
{
+ if ( !serial_io_hardware_is_present )
+ return 0;
return inb(IOBASE + 0x05) & 0x01;
}
static int serial_io_getchar(void)
{
+ if ( !serial_io_hardware_is_present )
+ return -1;
while (!serial_io_havechar()) ;
return (int)inb(IOBASE);
}
Dave Frodin (dave.frodin(a)se-eng.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/2039
-gerrit
commit d61292191a3bc90b955ad4c4a0cdd044af0772a6
Author: Dave Frodin <dave.frodin(a)se-eng.com>
Date: Mon Dec 17 14:40:47 2012 -0700
libpayload: Update configs/defconfig file
Several settings have been added to the config without any
changes to the default settings file.
Change-Id: Iaf9259d77fb3c4645fc68bc0108de79c0298f0a1
Signed-off-by: Dave Frodin <dave.frodin(a)se-eng.com>
---
payloads/libpayload/configs/defconfig | 13 ++++++++++++-
1 file changed, 12 insertions(+), 1 deletion(-)
diff --git a/payloads/libpayload/configs/defconfig b/payloads/libpayload/configs/defconfig
index 1dce37a..2a2e90b 100644
--- a/payloads/libpayload/configs/defconfig
+++ b/payloads/libpayload/configs/defconfig
@@ -1,7 +1,7 @@
#
# Automatically generated make config: don't edit
# libpayload version: 0.2.0
-# Thu Jul 21 15:45:38 2011
+# Mon Dec 17 14:39:45 2012
#
#
@@ -10,6 +10,7 @@
# CONFIG_EXPERIMENTAL is not set
# CONFIG_OBSOLETE is not set
# CONFIG_DEVELOPER is not set
+# CONFIG_CHROMEOS is not set
#
# Architecture Options
@@ -33,6 +34,7 @@ CONFIG_LZMA=y
#
# Console Options
#
+# CONFIG_SKIP_CONSOLE_INIT is not set
CONFIG_CBMEM_CONSOLE=y
CONFIG_SERIAL_CONSOLE=y
CONFIG_SERIAL_IOBASE=0x3f8
@@ -53,6 +55,12 @@ CONFIG_PCI=y
CONFIG_NVRAM=y
# CONFIG_RTC_PORT_EXTENDED_VIA is not set
CONFIG_SPEAKER=y
+CONFIG_STORAGE=y
+# CONFIG_STORAGE_64BIT_LBA is not set
+CONFIG_STORAGE_ATA=y
+CONFIG_STORAGE_ATAPI=y
+CONFIG_STORAGE_AHCI=y
+CONFIG_STORAGE_AHCI_ONLY_TESTED=y
CONFIG_USB=y
CONFIG_USB_UHCI=y
CONFIG_USB_OHCI=y
@@ -61,3 +69,6 @@ CONFIG_USB_XHCI=y
CONFIG_USB_HID=y
CONFIG_USB_HUB=y
CONFIG_USB_MSC=y
+# CONFIG_BIG_ENDIAN is not set
+CONFIG_LITTLE_ENDIAN=y
+CONFIG_ARCH_SPECIFIC_OPTIONS=y
the following patch was just integrated into master:
commit c5f4926cb92c3030e67202faa828c9539e20a01f
Author: Martin Roth <martin(a)se-eng.com>
Date: Fri Dec 14 19:17:55 2012 -0700
Fix a compare against undefined variable in acpi.c
Initialize the pointer fadt to NULL to prevent a later comparison
(if (fadt == NULL)) when the pointer had the *possibility* of never
having been initialized.
Change-Id: Ib2a544c190b609ab8c23147dc69dca5f4ac7f38c
Signed-off-by: Martin Roth <martin(a)se-eng.com>
Reviewed-on: http://review.coreboot.org/2037
Reviewed-by: Peter Stuge <peter(a)stuge.se>
Tested-by: build bot (Jenkins)
Build-Tested: build bot (Jenkins) at Sat Dec 15 03:28:24 2012, giving +1
Reviewed-By: Peter Stuge <peter(a)stuge.se> at Sat Dec 15 03:27:56 2012, giving +2
See http://review.coreboot.org/2037 for details.
-gerrit
Martin Roth (martin(a)se-eng.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/2037
-gerrit
commit d484f211eb94146e964e53cd92e4dc2c691bef3e
Author: Martin Roth <martin(a)se-eng.com>
Date: Fri Dec 14 19:17:55 2012 -0700
Fix a compare against undefined variable in acpi.c
Initialize the pointer fadt to NULL to prevent a later comparison
(if (fadt == NULL)) when the pointer had the *possibility* of never
having been initialized.
Change-Id: Ib2a544c190b609ab8c23147dc69dca5f4ac7f38c
Signed-off-by: Martin Roth <martin(a)se-eng.com>
---
src/arch/x86/boot/acpi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/arch/x86/boot/acpi.c b/src/arch/x86/boot/acpi.c
index fd6a1ba..1d7dbf8 100644
--- a/src/arch/x86/boot/acpi.c
+++ b/src/arch/x86/boot/acpi.c
@@ -687,7 +687,7 @@ void *acpi_find_wakeup_vector(void)
char *p, *end;
acpi_rsdt_t *rsdt;
acpi_facs_t *facs;
- acpi_fadt_t *fadt;
+ acpi_fadt_t *fadt = NULL;
void *wake_vec;
int i;
I have the test and debugging tools from Agilent for PCIe 1.x protocol,
if needed I could get involved in the test effort.
>> Thanks to AMD, Scott and <http://www.se-eng.com/>, coreboot works with
>> the board pretty good [2]. The only problems seem to be resume from
>> suspend not working and the Ethernet device sometimes not enabling
>> during start.
>hmmm, the external PCIe slot seem untested, virtualization seem also
>untested.
>I also wonder how much RAM it accepts, and if it works in 64bit...
>
>Is the CPU fast(for compilation like compiling android)?
>How to get connectivity if the Ethernet doesn't work? (is there a way
>to get Wifi?, or maybe trough an USB Ethernet adapter?).
the following patch was just integrated into master:
commit 9f0431726353a5eaa259776ab43e57163b74605e
Author: Stefan Reinauer <reinauer(a)chromium.org>
Date: Fri Dec 14 13:06:49 2012 -0800
libpayload: add kconfig.h
This implements the linux kernel's macros to handle
boolean CONFIG_ variables more easily.
Change-Id: I595f9db652d019fe72e231111258ec609bec9d4e
Signed-off-by: Stefan Reinauer <reinauer(a)google.com>
Reviewed-on: http://review.coreboot.org/2036
Tested-by: build bot (Jenkins)
Reviewed-by: Ronald G. Minnich <rminnich(a)gmail.com>
Build-Tested: build bot (Jenkins) at Fri Dec 14 22:39:41 2012, giving +1
Reviewed-By: Ronald G. Minnich <rminnich(a)gmail.com> at Fri Dec 14 23:59:05 2012, giving +2
See http://review.coreboot.org/2036 for details.
-gerrit
Ronald G. Minnich (rminnich(a)gmail.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/2036
-gerrit
commit afcb7ec4511767839455cf9c20ddf4c2be161a80
Author: Stefan Reinauer <reinauer(a)chromium.org>
Date: Fri Dec 14 13:06:49 2012 -0800
libpayload: add kconfig.h
This implements the linux kernel's macros to handle
boolean CONFIG_ variables more easily.
Change-Id: I595f9db652d019fe72e231111258ec609bec9d4e
Signed-off-by: Stefan Reinauer <reinauer(a)google.com>
---
payloads/libpayload/include/kconfig.h | 21 +++++++++++++++++++++
1 file changed, 21 insertions(+)
diff --git a/payloads/libpayload/include/kconfig.h b/payloads/libpayload/include/kconfig.h
new file mode 100644
index 0000000..3d7d768
--- /dev/null
+++ b/payloads/libpayload/include/kconfig.h
@@ -0,0 +1,21 @@
+#ifndef __KCONFIG_H__
+#define __KCONFIG_H__
+
+#include <libpayload-config.h>
+
+/*
+ * Getting something that works in C and CPP for an arg that may or may
+ * not be defined is tricky. Here, if we have "#define CONFIG_BOOGER 1"
+ * we match on the placeholder define, insert the "0," for arg1 and generate
+ * the triplet (0, 1, 0). Then the last step cherry picks the 2nd arg (a one).
+ * When CONFIG_BOOGER is not defined, we generate a (... 1, 0) pair, and when
+ * the last step cherry picks the 2nd arg, we get a zero.
+ */
+#define __ARG_PLACEHOLDER_1 0,
+#define config_enabled(cfg) _config_enabled(cfg)
+#define _config_enabled(value) __config_enabled(__ARG_PLACEHOLDER_##value)
+#define __config_enabled(arg1_or_junk) ___config_enabled(arg1_or_junk 1, 0, 0)
+#define ___config_enabled(__ignored, val, ...) val
+
+#define IS_ENABLED(option) config_enabled(option)
+#endif
the following patch was just integrated into master:
commit 8af0d03fd49f9c88db98ef7b3c2d95bf1cd0f319
Author: Stefan Reinauer <reinauer(a)chromium.org>
Date: Fri Dec 14 13:05:21 2012 -0800
libpayload: Initial ARMv7 port
This compiles, but it's not tested yet.
Change-Id: I2f73a814649aa36c39af3e77cefd8a968671f5c0
Signed-off-by: Stefan Reinauer <reinauer(a)google.com>
Reviewed-on: http://review.coreboot.org/2035
Tested-by: build bot (Jenkins)
Reviewed-by: Ronald G. Minnich <rminnich(a)gmail.com>
Build-Tested: build bot (Jenkins) at Fri Dec 14 22:26:43 2012, giving +1
Reviewed-By: Ronald G. Minnich <rminnich(a)gmail.com> at Fri Dec 14 22:28:09 2012, giving +2
See http://review.coreboot.org/2035 for details.
-gerrit
the following patch was just integrated into master:
commit f6935a006a6ffe57413877093035cdc1a020e7bd
Author: Stefan Reinauer <reinauer(a)chromium.org>
Date: Fri Dec 14 11:42:57 2012 -0800
libpayload: rename i386 to x86
Change-Id: Ia9170bd3d04e76dbf9321ca7ea4be23b5e468d21
Signed-off-by: Stefan Reinauer <reinauer(a)google.com>
Reviewed-on: http://review.coreboot.org/2033
Tested-by: build bot (Jenkins)
Reviewed-by: Ronald G. Minnich <rminnich(a)gmail.com>
Build-Tested: build bot (Jenkins) at Fri Dec 14 22:14:01 2012, giving +1
Reviewed-By: Ronald G. Minnich <rminnich(a)gmail.com> at Fri Dec 14 22:15:37 2012, giving +2
See http://review.coreboot.org/2033 for details.
-gerrit