coreboot November 2012

coreboot@coreboot.org

35 participants
895 discussions

Patch merged into coreboot/master: bdc1816 Fix technexion tim5690 board VGA handler
by gerrit＠coreboot.org 27 Nov '12

27 Nov '12

the following patch was just integrated into master: commit bdc1816b2379bdf569ac6746172bba41e1307917 Author: Stefan Reinauer <reinauer(a)chromium.org> Date: Tue Nov 27 12:44:18 2012 -0800 Fix technexion tim5690 board VGA handler When dropping ramstage.a, unused functions with unresolved symbols are not silently dropped anymore. This makes the tim5690 compilation fail. This fix makes sure we don't compile in the int15 handler code when we don't set CONFIG_VGA_ROM_RUN Change-Id: If6872c983d9fd811eb33259421f94b551f3b9b34 Signed-off-by: Stefan Reinauer <reinauer(a)google.com> Reviewed-on: http://review.coreboot.org/1929 Reviewed-by: Patrick Georgi <patrick(a)georgi-clan.de> Tested-by: build bot (Jenkins) Reviewed-By: Patrick Georgi <patrick(a)georgi-clan.de> at Tue Nov 27 21:53:23 2012, giving +2 Build-Tested: build bot (Jenkins) at Tue Nov 27 22:18:58 2012, giving +1 See http://review.coreboot.org/1929 for details. -gerrit

1 0

Patch merged into coreboot/master: 23023a5 Enable the FCH GPP port prior to device enumeration
by gerrit＠coreboot.org 27 Nov '12

27 Nov '12

the following patch was just integrated into master: commit 23023a5691c0e3086933706c1cb2a79602ecffa0 Author: Dave Frodin <dave.frodin(a)se-eng.com> Date: Tue Nov 13 07:09:12 2012 -0700 Enable the FCH GPP port prior to device enumeration Change-Id: Ib4401897570f9e4d31c18d05144b5deb6f4523bc Signed-off-by: Dave Frodin <dave.frodin(a)se-eng.com> Reviewed-on: http://review.coreboot.org/1873 Tested-by: build bot (Jenkins) Reviewed-by: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Reviewed-by: Marc Jones <marcj303(a)gmail.com> Build-Tested: build bot (Jenkins) at Mon Nov 26 16:07:21 2012, giving +1 Reviewed-By: Stefan Reinauer <stefan.reinauer(a)coreboot.org> at Mon Nov 26 19:32:48 2012, giving +1 Reviewed-By: Marc Jones <marcj303(a)gmail.com> at Tue Nov 27 22:04:23 2012, giving +2 See http://review.coreboot.org/1873 for details. -gerrit

1 0

Patch merged into coreboot/master: 8247583 Drop duplicate files that prevent building without ramstage.a
by gerrit＠coreboot.org 27 Nov '12

27 Nov '12

the following patch was just integrated into master: commit 8247583058fc1607ccde26be7cdb1a1be4691122 Author: Stefan Reinauer <reinauer(a)chromium.org> Date: Thu Nov 15 16:24:30 2012 -0800 Drop duplicate files that prevent building without ramstage.a When dropping ramstage.a duplicate symbols in ramstage will start breaking the build. Hence drop all the duplicate functions implemented by mainboards that have those functions in generic or component code already. Change-Id: I5cf8245c67b6f0f348388db54256d28f47017a61 Signed-off-by: Stefan Reinauer <reinauer(a)google.com> Reviewed-on: http://review.coreboot.org/1865 Reviewed-by: Patrick Georgi <patrick(a)georgi-clan.de> Tested-by: build bot (Jenkins) Reviewed-By: Patrick Georgi <patrick(a)georgi-clan.de> at Tue Nov 27 21:52:07 2012, giving +2 See http://review.coreboot.org/1865 for details. -gerrit

1 0

Patch merged into coreboot/master: f33e395 build system: Split linking into multiple steps
by gerrit＠coreboot.org 27 Nov '12

27 Nov '12

the following patch was just integrated into master: commit f33e395213f0516a9256f33ede4c6bba3babb0e9 Author: Patrick Georgi <patrick(a)georgi-clan.de> Date: Sun Nov 25 17:10:47 2012 +0100 build system: Split linking into multiple steps After collecting dependencies for ramstage, add an intermediate step in which object files are linked per directory. The results are then linked into the final binary. This reduces the maximum command line length and might also help with future use of LTO linking. Also adapt the lint test for build dir handling, since printall doesn't provide individual object files for ramstage anymore. Change-Id: Ie40febd8c1eaf4609944eedeab46d870639e53df Signed-off-by: Patrick Georgi <patrick(a)georgi-clan.de> Reviewed-on: http://review.coreboot.org/1911 Tested-by: build bot (Jenkins) Reviewed-by: Stefan Reinauer <stefan.reinauer(a)coreboot.org> See http://review.coreboot.org/1911 for details. -gerrit

1 0

Patch merged into coreboot/master: 79f9010 build system: Add hook to postprocess classes (object lists)
by gerrit＠coreboot.org 27 Nov '12

27 Nov '12

the following patch was just integrated into master: commit 79f9010e80a04f2e0fb0cca5759e3215dff79aff Author: Patrick Georgi <patrick(a)georgi-clan.de> Date: Sun Nov 25 14:31:08 2012 +0100 build system: Add hook to postprocess classes (object lists) This will be used to minimize the ramstage class, to avoid command line lengths to exceed the limit on mingw, esp. after we got rid of ramstage.a Change-Id: I80582d04476545c275e8d1d08fb52a99f58cebcc Signed-off-by: Patrick Georgi <patrick(a)georgi-clan.de> Reviewed-on: http://review.coreboot.org/1910 Tested-by: build bot (Jenkins) Reviewed-by: Stefan Reinauer <stefan.reinauer(a)coreboot.org> See http://review.coreboot.org/1910 for details. -gerrit

1 0

Patch merged into coreboot/master: 6999217 build system: Eliminate special case for c_start
by gerrit＠coreboot.org 27 Nov '12

27 Nov '12

the following patch was just integrated into master: commit 6999217ab6e4c8ed4c7f19a5578c36b01ad883ed Author: Patrick Georgi <patrick(a)georgi-clan.de> Date: Sun Nov 25 17:31:25 2012 +0100 build system: Eliminate special case for c_start c_start.o has a special case in the build system, which we can eliminate, somewhat simplifying the build. To ensure that the entry point is at the beginning, introduce a new section .textfirst that is placed appropriately. In principle the ENTRY() definition in the linker script should be enough, but better be safe. Change-Id: I9737f7f5731e12ceb2119eb432b0e09832bc53fa Signed-off-by: Patrick Georgi <patrick(a)georgi-clan.de> Reviewed-on: http://review.coreboot.org/1909 Tested-by: build bot (Jenkins) Reviewed-by: Ronald G. Minnich <rminnich(a)gmail.com> See http://review.coreboot.org/1909 for details. -gerrit

1 0

Patch merged into coreboot/master: 23f38cd Get rid of drivers class
by gerrit＠coreboot.org 27 Nov '12

27 Nov '12

the following patch was just integrated into master: commit 23f38cd05c05ed1876febfa59b652cd7171027ca Author: Patrick Georgi <patrick.georgi(a)secunet.com> Date: Fri Nov 16 14:50:32 2012 +0100 Get rid of drivers class The use of ramstage.a required the build system to handle some object files in a special way, which were put in the drivers class. These object files didn't provide any symbols that were used directly (but only via linker magic), and so the linker never considered them for inclusion. With ramstage.a gone, we can drop this special class, too. Change-Id: I6f1369e08d7d12266b506a5597c3a139c5c41a55 Signed-off-by: Patrick Georgi <patrick.georgi(a)secunet.com> Reviewed-on: http://review.coreboot.org/1872 Tested-by: build bot (Jenkins) Reviewed-by: Ronald G. Minnich <rminnich(a)gmail.com> See http://review.coreboot.org/1872 for details. -gerrit

1 0

Patch merged into coreboot/master: 18607f7 Drop ramstage.a
by gerrit＠coreboot.org 27 Nov '12

27 Nov '12

the following patch was just integrated into master: commit 18607f717eb125f49431da3843c19fcb25f1ee81 Author: Patrick Georgi <patrick(a)georgi-clan.de> Date: Sun Oct 7 22:11:07 2012 +0200 Drop ramstage.a ramstage.a has two issues: 1. duplicate source filenames don't survive the ar(1) treatment properly (so files aren't considered) 2. ld doesn't resolve symbols if it isn't forced to, in particular no overrides of weak symbols Downside: The resulting binaries get slightly larger. Link time optimizations should fix that, as would tighter rules in the build system (to not compile unused code in the first place). Change-Id: Iaae771ec8f92b42069237acd3b79c14e5bf9c03d Signed-off-by: Patrick Georgi <patrick(a)georgi-clan.de> Reviewed-on: http://review.coreboot.org/1566 Tested-by: build bot (Jenkins) Reviewed-by: Ronald G. Minnich <rminnich(a)gmail.com> Build-Tested: build bot (Jenkins) at Tue Nov 27 21:56:45 2012, giving +1 Reviewed-By: Ronald G. Minnich <rminnich(a)gmail.com> at Tue Nov 27 21:59:25 2012, giving +2 See http://review.coreboot.org/1566 for details. -gerrit

1 0

Patch merged into coreboot/master: b6f765e Provide weak empty declarations of all chip_ops used on a board
by gerrit＠coreboot.org 27 Nov '12

27 Nov '12

the following patch was just integrated into master: commit b6f765e7c85539b270dba407ff40846c3688ed60 Author: Patrick Georgi <patrick(a)georgi-clan.de> Date: Sun Oct 7 22:04:52 2012 +0200 Provide weak empty declarations of all chip_ops used on a board sconfig creates empty defaults for all chip_ops, which can be overridden by drivers simply by providing a concrete implementation. Change-Id: Ib37515f0b0747bdbf4da780d28690a1e719944b2 Signed-off-by: Patrick Georgi <patrick(a)georgi-clan.de> Reviewed-on: http://review.coreboot.org/1567 Tested-by: build bot (Jenkins) Reviewed-by: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Build-Tested: build bot (Jenkins) at Sun Nov 25 18:20:34 2012, giving +1 Reviewed-By: Stefan Reinauer <stefan.reinauer(a)coreboot.org> at Mon Nov 26 19:31:11 2012, giving +2 See http://review.coreboot.org/1567 for details. -gerrit

1 0

New patch to review for coreboot: 3652eb5 Fix technexion tim5690 board VGA handler
by Stefan Reinauer 27 Nov '12

27 Nov '12

Stefan Reinauer (stefan.reinauer(a)coreboot.org) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/1929 -gerrit commit 3652eb5ae14a561967e51d17fff53e4a4ded9fe5 Author: Stefan Reinauer <reinauer(a)chromium.org> Date: Tue Nov 27 12:44:18 2012 -0800 Fix technexion tim5690 board VGA handler When dropping ramstage.a, unused functions with unresolved symbols are not silently dropped anymore. This makes the tim5690 compilation fail. This fix makes sure we don't compile in the int15 handler code when we don't set CONFIG_VGA_ROM_RUN Change-Id: If6872c983d9fd811eb33259421f94b551f3b9b34 Signed-off-by: Stefan Reinauer <reinauer(a)google.com> --- src/mainboard/technexion/tim5690/Makefile.inc | 2 +- src/mainboard/technexion/tim5690/mainboard.c | 8 +++++++- 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/src/mainboard/technexion/tim5690/Makefile.inc b/src/mainboard/technexion/tim5690/Makefile.inc index d9e8046..878dbab 100644 --- a/src/mainboard/technexion/tim5690/Makefile.inc +++ b/src/mainboard/technexion/tim5690/Makefile.inc @@ -23,4 +23,4 @@ ramstage-y += tn_post_code.c ramstage-y += speaker.c -ramstage-y += vgabios.c +ramstage-$(CONFIG_VGA_ROM_RUN) += vgabios.c diff --git a/src/mainboard/technexion/tim5690/mainboard.c b/src/mainboard/technexion/tim5690/mainboard.c index 878daae..7974ce9 100644 --- a/src/mainboard/technexion/tim5690/mainboard.c +++ b/src/mainboard/technexion/tim5690/mainboard.c @@ -188,6 +188,7 @@ static void mb_gpio_init(u16 *iobase) it8712f_exit_conf(); } +#if CONFIG_VGA_ROM_RUN /* The LCD's panel id seletion. */ static void lcd_panel_id(rs690_vbios_regs *vbios_regs, u8 num_id) { @@ -215,6 +216,7 @@ static void lcd_panel_id(rs690_vbios_regs *vbios_regs, u8 num_id) break; } } +#endif /************************************************* * enable the dedicated function in tim5690 board. @@ -222,14 +224,17 @@ static void lcd_panel_id(rs690_vbios_regs *vbios_regs, u8 num_id) *************************************************/ static void tim5690_enable(device_t dev) { - rs690_vbios_regs vbios_regs; u16 gpio_base = IT8712F_SIMPLE_IO_BASE; +#if CONFIG_VGA_ROM_RUN + rs690_vbios_regs vbios_regs; u8 port2; +#endif printk(BIOS_INFO, "Mainboard tim5690 Enable. dev=0x%p\n", dev); mb_gpio_init(&gpio_base); +#if CONFIG_VGA_ROM_RUN /* The LCD's panel id seletion by switch. */ port2 = inb(gpio_base+1); lcd_panel_id(&vbios_regs, ((~port2) & 0xf)); @@ -237,6 +242,7 @@ static void tim5690_enable(device_t dev) /* No support TV */ vbios_regs.int15_regs.fun05_tv_standard = TV_MODE_NO; vgabios_init(&vbios_regs); +#endif set_thermal_config(); }

1 0

← Newer
1
...
9
10
11
12
13
14
15
...
90
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

coreboot November 2012