coreboot September 2011

coreboot@coreboot.org

40 participants
224 discussions

Patch set updated for filo: ed521a9 Add multiboot header
by Patrick Georgi 07 Sep '11

07 Sep '11

Patrick Georgi (patrick(a)georgi-clan.de) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/197 -gerrit commit ed521a9675301224fbc6e27dd4ce3d85e9370d14 Author: Mathias Krause <mathias.krause(a)secunet.com> Date: Tue Jun 7 13:53:31 2011 +0200 Add multiboot header Change-Id: Ibe8e879a3a6f533f97aa8381697afb1f14d1f87d Signed-off-by: Mathias Krause <mathias.krause(a)secunet.com> Signed-off-by: Patrick Georgi <patrick.georgi(a)secunet.com> --- Config.in | 7 +++++++ i386/ldscript | 2 +- main/Makefile.inc | 1 + main/mb_hdr.c | 32 ++++++++++++++++++++++++++++++++ 4 files changed, 41 insertions(+), 1 deletions(-) diff --git a/Config.in b/Config.in index 8981a48..a8cbfbb 100644 --- a/Config.in +++ b/Config.in @@ -9,6 +9,13 @@ config TARGET_I386 bool default y +config MULTIBOOT_IMAGE + bool "Include a MultiBoot header" + default y + help + Including a MultiBoot header makes FILO chainloadable by MultiBoot + compliant boot loaders like GRUB. + menu "Interface Options" config USE_GRUB diff --git a/i386/ldscript b/i386/ldscript index 7fba856..b260c51 100644 --- a/i386/ldscript +++ b/i386/ldscript @@ -40,7 +40,7 @@ SECTIONS /* Start of the program. * Now the version string is in the note, we must include it * in the program. Otherwise we lose the string after relocation. */ - . = ALIGN(16); + . = ALIGN(4096); _start = .; /* Putting ELF notes near beginning of file might help bootloaders. diff --git a/main/Makefile.inc b/main/Makefile.inc index c7290cf..e2fab04 100644 --- a/main/Makefile.inc +++ b/main/Makefile.inc @@ -16,6 +16,7 @@ # Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA. # +TARGETS-$(CONFIG_MULTIBOOT_IMAGE) += main/mb_hdr.o TARGETS-y += main/filo.o main/strtox.o TARGETS-y += main/elfload.o main/ipchecksum.o TARGETS-$(CONFIG_SUPPORT_SOUND) += main/sound.o diff --git a/main/mb_hdr.c b/main/mb_hdr.c new file mode 100644 index 0000000..bb01427 --- /dev/null +++ b/main/mb_hdr.c @@ -0,0 +1,32 @@ +/* + * This file is part of FILO. + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by + * the Free Software Foundation; version 2 of the License. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + * + * You should have received a copy of the GNU General Public License + * along with this program; if not, write to the Free Software + * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA + */ + +/* Support for MultiBoot */ +#define MB_HEADER_MAGIC 0x1BADB002 +#define MB_RQ_FLAGS_4K 1 +#define MB_REQUESTED_FLAGS (MB_RQ_FLAGS_4K) + +/* this header is parsed by the boot loader that loads FILO, e.g. GRUB */ +struct mb_header { + long magic; /* multiboot magic */ + long features; /* requested features */ + long chksum; /* chksum for whole structure */ +} mb_header __attribute__((section(".hdr.mb"))) = { + .magic = MB_HEADER_MAGIC, + .features = MB_REQUESTED_FLAGS, + .chksum = -(MB_HEADER_MAGIC + MB_REQUESTED_FLAGS), +};

1 0

Patch set updated for filo: 521f67f Trivial compilation fix
by Patrick Georgi 07 Sep '11

07 Sep '11

Patrick Georgi (patrick(a)georgi-clan.de) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/181 -gerrit commit 521f67f31f65e07ed91b24512d0af71abb0ec0bb Author: Aurélien <footplus(a)gmail.com> Date: Thu Sep 9 18:39:10 2010 +0200 Trivial compilation fix Change-Id: I9e1ef711b62a42b1ddbd620d09a9c19a6e1ff0db Signed-off-by: Patrick Georgi <patrick(a)georgi-clan.de> --- main/grub/completions.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/main/grub/completions.c b/main/grub/completions.c index 161026b..a3aeba2 100644 --- a/main/grub/completions.c +++ b/main/grub/completions.c @@ -23,6 +23,7 @@ #include <config.h> #include <grub/shared.h> #define current_slice 0 +#define IS_PC_SLICE_TYPE_BSD(type) 0 static int do_completion; static int unique;

1 0

Patch merged into filo/master: 0ca6ae9 Show which file cannot be openend in file_open(), eases debuging.
by gerrit＠coreboot.org 07 Sep '11

07 Sep '11

the following patch was just integrated into master: commit 0ca6ae94bb6be913aef972b93e8e1a05f98cdfad Author: Mathias Krause <mathias.krause(a)secunet.com> Date: Thu Jun 3 15:39:46 2010 +0200 Show which file cannot be openend in file_open(), eases debuging. Change-Id: I06fd3576aa3443588e67234bce748f533c36a8ff Signed-off-by: Mathias Krause <mathias.krause(a)secunet.com> Signed-off-by: Patrick Georgi <patrick.georgi(a)secunet.com> See http://review.coreboot.org/193 for details. -gerrit

1 0

Patch merged into filo/master: e6e5a03 More compatible use of mktemp
by gerrit＠coreboot.org 07 Sep '11

07 Sep '11

the following patch was just integrated into master: commit e6e5a03bca182471fa00d937c3235ac00ef0234e Author: Patrick Georgi <patrick.georgi(a)secunet.com> Date: Thu Sep 1 09:16:37 2011 +0200 More compatible use of mktemp Change-Id: I961a7ddcd39657c9463806d7b82757eff0a4ac57 Signed-off-by: Patrick Georgi <patrick.georgi(a)secunet.com> See http://review.coreboot.org/190 for details. -gerrit

1 0

Patch merged into filo/master: e4f93b2 Show root device we're booted from in header.
by gerrit＠coreboot.org 07 Sep '11

07 Sep '11

the following patch was just integrated into master: commit e4f93b2957a293efea945dac6566547ede17b591 Author: Mathias Krause <mathias.krause(a)secunet.com> Date: Mon Mar 8 12:05:40 2010 +0100 Show root device we're booted from in header. Change-Id: I9288f88f6673fafa41d13f2035ea3b9b6550dbb2 Signed-off-by: Mathias Krause <mathias.krause(a)secunet.com> Signed-off-by: Patrick Georgi <patrick.georgi(a)secunet.com> See http://review.coreboot.org/201 for details. -gerrit

1 0

Patch merged into filo/master: 79c690a Simplify kconfig handling some more
by gerrit＠coreboot.org 07 Sep '11

07 Sep '11

the following patch was just integrated into master: commit 79c690a5e0b60f318837f152df0f7baf412f2149 Author: Patrick Georgi <patrick(a)georgi-clan.de> Date: Sat Sep 3 13:29:27 2011 +0200 Simplify kconfig handling some more Inspired by http://patchwork.coreboot.org/patch/1757/, this simplifies the build some more. Also fixes menuconfig if the compiler is picky about file naming order. Change-Id: I6d5b56a041bab1d844f4dd6ef00965736f9eb5b8 Signed-off-by: Patrick Georgi <patrick(a)georgi-clan.de> See http://review.coreboot.org/180 for details. -gerrit

1 0

E350M1 does not POST
by She, Kerry 07 Sep '11

07 Sep '11

> -----Original Message----- > From: coreboot-bounces(a)coreboot.org [mailto:coreboot- > bounces(a)coreboot.org] On Behalf Of perh52(a)runbox.com > Sent: Friday, August 19, 2011 12:37 AM > To: coreboot > Subject: [coreboot] E350M1 does not POST > > >>> Hi, > >>> > >>>> Upon booting, I get this: > >>> > >>> [...] > >>> > >>> you could try commit 0df0e14fb, that may or may not work, the > >>> commit > after > >>> that broke fusion boards completely, apparently. > >>> > >>> Florian > >>> > >> Thank you! I can confirm that 0df0e14fb works properly. > >> -Marshall > > > >Frank, > > > >It looks like we have a regression. Is there some dependency on the > >other patches that have not yet been committed? > > > >Marc > > Unfortunately git bisect is no help here because the commit which > caused the regression was a huge one. > > It's important that large patches are broken down into a set of small > comprehensible patches, each with an explanatory commit message. > > <<quote from git-bisect-lk2009.html documentation>> ... > sometimes "interesting" changes of behavior in the software are > introduced in some commits. > > In fact people are specially interested in commits that introduce a > "bad" behavior, called a bug or a regression. They are interested in > these commits because a commit (hopefully) contains a very small set > of source code changes. And it's much easier to understand and > properly fix a problem when you only need to check a very small set of > changes, than when you don't know where look in the first place. > > So to help people find commits that introduce a "bad" behavior, the > "git bisect" set of commands was invented. Hello, All Since commit 84cbce2 cause E350M1 not POST, Following patches should resolve this regression problem, please see the attachment in detail. I have test it on a Persimmon mainboard, anybody can have a test on E350M1? Thanks -- Kerry sheh

1 0

Re: [coreboot] New patch to review for coreboot: deb6f0f Add ASUS M5A88-V mainboard support
by Paul Menzel 07 Sep '11

07 Sep '11

Dear Quing Pei, Am Dienstag, den 06.09.2011, 22:42 +0800 schrieb QingPei Wang: > i tested by my opensuse 11.2 without X windows. could you just test if X works please so that nobody wanting to buy that board gets wrong expectations? Additionally: Is suspend/resume working? Are all ports working (hard drive, USB, …)? How long does coreboot + payload take on your board to load/initialize? > the patch is applicable to the former two patches which i sent before. > And it does not depend on any other patches by AMD at this moment. Some patches were committed tonight. Could you retest with them please? > And i am trying to get familiar with gerrit at this moment. I just > learned how to submit the patches, still does not know how to use "git > format-patch" things. > > The attachment is a simple boot log with the board. I will cost more time to > make this better. A TODO would also be nice. ;-) > On Tue, Sep 6, 2011 at 10:28 PM, Paul Menzel wrote: > > Am Dienstag, den 06.09.2011, 15:12 +0200 schrieb QingPei Wang: > > > > > commit deb6f0f225bddd2fa786f94689555a21add12d13 > > > Author: QingPei Wang <wangqingpei(a)gmail.com> > > > Date: Tue Sep 6 21:09:40 2011 +0800 > > > > > > Add ASUS M5A88-V mainboard support > > > > > > it's a AMD 880+800 mainboard. I port the code > > > based on the AMD reference code. You can use the following Git commands to adapt your patch. cd pathtoyourgitcorebootfolder Update the user information (just a suggestion). git config --global user.name Quingpei Wang (your Chinese spelling here) Update all remote repositories. git fetch Take a look at the changes. git log origin/master # where `origin` is the remote coreboot respository Checkout your branch with your ASUS M5A88-V stuff. git branch # show all local branches git checkout m5a88 # substitude m5a88 Put your changes on top of the latest master. git rebase origin/master # if there are conflicts, but there should not Update (amend) the commit message of the last commit to for example add information, what you have tested. git commit --amend -s If you also want to amend files, you have to add the changed file before amending. git add yourfilewithtoamendedchanges git add --patch yourfilewithtoamendedchanges # only parts of the file git commit --amend -s git commit -a --amend -s If you also want to add commits prior to the list one. git rebase -i HEAD~8 # number of commits going back If you need more information the manual pages are also quite good. For example `git help rebase` opens the manual page for `git rebase`. Thanks, Paul [1] http://review.coreboot.org/#q,status:merged,n,z

1 0

Patch merged into coreboot/master: 7700f5d Add support utils for tracing
by gerrit＠coreboot.org 06 Sep '11

06 Sep '11

the following patch was just integrated into master: commit 7700f5df07fd80c65eced4deb7d0c6051fd9f2b6 Author: Rudolf Marek <r.marek(a)assembler.cz> Date: Fri Sep 2 23:34:15 2011 +0200 Add support utils for tracing Following patch adds a userspace util genprof which is able to convert the console printed traces to gmon.out file used by gprof & friends. The log2dress will replace the adresses in logfile with a line numbers. Change-Id: I9f716f3ff2522a24fbc844a1dd5e32ef49b540c5 Signed-off-by: Rudolf Marek <r.marek(a)assembler.cz> See http://review.coreboot.org/179 for details. -gerrit

1 0

Patch merged into coreboot/master: 5ef3380 Add support for the tracing infastructure in coreboot.
by gerrit＠coreboot.org 06 Sep '11

06 Sep '11

the following patch was just integrated into master: commit 5ef3380428f35b9196ecfe7f52281bb26080c364 Author: Rudolf Marek <r.marek(a)assembler.cz> Date: Fri Sep 2 23:23:41 2011 +0200 Add support for the tracing infastructure in coreboot. The compiler is forced to emmit special functions on every entry/exit of the function. Add a compile time option to support it. Function entries will be printed in the console. The CONFIG_TRACE has more documentation. Patch for userspace tools will follow. Change-Id: I2cbeb3f104892b034c8756f86ed05bf71187c3f3 Signed-off-by: Rudolf Marek <r.marek(a)assembler.cz> See http://review.coreboot.org/178 for details. -gerrit

1 0

← Newer
1
...
13
14
15
16
17
18
19
...
23
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

coreboot September 2011