coreboot February 2011

coreboot@coreboot.org

52 participants
283 discussions

build service results for r6380
by repository service 24 Feb '11

24 Feb '11

Dear coreboot readers! This is the automatic build system of coreboot. The developer "oxygene" checked in revision 6380 to the coreboot repository. This caused the following changes: Change Log: Add compile-time defaults to some K8 CMOS options in case they're absent in CMOS This affects the CMOS options iommu, ECC_memory, max_mem_clock, hw_scrubber, interleave_chip_selects. If they're absent in cmos.layout, a Kconfig value is used if it exists, or a hardcoded default otherwise. [Patrick: I changed the ramstage CMOS handling a bit, and dropped the reliance of hw_scrubber on ECC RAM, as it has nothing to do with it - it's the cache that's being scrubbed here.] Signed-off-by: Josef Kellermann <seppk(a)arcor.de> Acked-by: Patrick Georgi <patrick.georgi(a)secunet.com> Build Log: Compilation of asi:mb_5blgp has been broken See the error log at http://qa.coreboot.org/log_buildbrd.php?revision=6380&device=mb_5blgp&vendo… If something broke during this checkin please be a pain in oxygene's neck until the issue is fixed. If this issue is not fixed within 24h the revision should be backed out. Best regards, coreboot automatic build system

1 0

add Kconfig options in addition/in place of CMOS option
by Josef Kellermann 24 Feb '11

24 Feb '11

Attached patch adds sane compile-time defaults via Kconfig options for CMOS options 'iommu, ECC_memory, max_mem_clock, hw_scrubber, interleave_chip_selects'. Avoid build error if any of these CMOS options are not defined. Checks the return value of 'get_option(..)', if not done yet, and if CMOS option not exist grab a Kconfig option otherwise a hardcoded value is used. Signed-off-by: Josef Kellermann <seppk(a)arcor.de> <mailto://seppk@arcor.de>

2 1

New CMOS option sata_mode
by Josef Kellermann 24 Feb '11

24 Feb '11

Attached patch implements a new CMOS option 'sata_mode'. A new Kconfig option 'SATA_MODE' with default 'ide' is added to amd/sb600/Kconfig. The handling of the CMOS option is placed in amd/sb600/sata.c and overrides the hardcoded 'ide' mode in the following way: if get_option(., "sata_mode") returns 0 use CMOS option in case of -2 grab the Kconfig option CONFIG_SATA_MODE if exist otherwise use the hardcoded mode. Signed-off-by: Josef Kellermann <seppk(a)arcor.de> <mailto://seppk@arcor.de>

2 1

[commit] r6379 - trunk/src/southbridge/amd/sb600
by repository service 24 Feb '11

24 Feb '11

Author: oxygene Date: Thu Feb 24 14:54:10 2011 New Revision: 6379 URL: https://tracker.coreboot.org/trac/coreboot/changeset/6379 Log: Add new option 'sata_mode' to CMOS and 'SATA_MODE' to Kconfig for AMD SB600 coreboot used to set the chipset to IDE mode unconditionally. Now, the user has a couple of ways to choose the configuration: - If a CMOS variable sata_mode exist, it is used to decide if IDE or AHCI is to be used as interface. - If not, a Kconfig option is used. - If unchanged, the Kconfig option is set to IDE. So unless the cmos.layout is extended or Kconfig is modified, this won't change behaviour. [Patrick: Compared to Josef's version, I changed the Kconfig option to be boolean, instead of a magic string. Also, the "IDE" default is handled in Kconfig, instead of an additional line of code.] Signed-off-by: Josef Kellermann <seppk(a)arcor.de> Acked-by: Patrick Georgi <patrick.georgi(a)secunet.com> Modified: trunk/src/southbridge/amd/sb600/Kconfig trunk/src/southbridge/amd/sb600/sata.c Modified: trunk/src/southbridge/amd/sb600/Kconfig ============================================================================== --- trunk/src/southbridge/amd/sb600/Kconfig Thu Feb 24 08:43:37 2011 (r6378) +++ trunk/src/southbridge/amd/sb600/Kconfig Thu Feb 24 14:54:10 2011 (r6379) @@ -23,16 +23,36 @@ select HAVE_USBDEBUG select TINY_BOOTBLOCK +if SOUTHBRIDGE_AMD_SB600 config BOOTBLOCK_SOUTHBRIDGE_INIT string default "southbridge/amd/sb600/bootblock.c" - depends on SOUTHBRIDGE_AMD_SB600 config EHCI_BAR hex - default 0xfef00000 if SOUTHBRIDGE_AMD_SB600 + default 0xfef00000 config EHCI_DEBUG_OFFSET hex - default 0xe0 if SOUTHBRIDGE_AMD_SB600 + default 0xe0 +choice + prompt "SATA Mode" + default SATA_MODE_IDE + help + Select the mode in which SATA should be driven. IDE or AHCI. + The default is IDE. + + config SATA_MODE_IDE + bool "IDE" + + config SATA_MODE_AHCI + bool "AHCI" +endchoice + +config SATA_MODE + int + default 1 if SATA_MODE_IDE + default 0 if SATA_MODE_AHCI + +endif Modified: trunk/src/southbridge/amd/sb600/sata.c ============================================================================== --- trunk/src/southbridge/amd/sb600/sata.c Thu Feb 24 08:43:37 2011 (r6378) +++ trunk/src/southbridge/amd/sb600/sata.c Thu Feb 24 14:54:10 2011 (r6379) @@ -26,6 +26,10 @@ #include <device/pci_ops.h> #include <arch/io.h> #include "sb600.h" +#include <pc80/mc146818rtc.h> + +#define SATA_MODE_IDE 1 +#define SATA_MODE_AHCI 0 static int sata_drive_detect(int portnum, u16 iobar) { @@ -98,10 +102,6 @@ printk(BIOS_SPEW, "sata_bar4=%x\n", sata_bar4); /* 3000 */ printk(BIOS_SPEW, "sata_bar5=%x\n", sata_bar5); /* e0309000 */ - /* Program the 2C to 0x43801002 */ - dword = 0x43801002; - pci_write_config32(dev, 0x2c, dword); - /* SERR-Enable */ word = pci_read_config16(dev, 0x04); word |= (1 << 8); @@ -112,13 +112,25 @@ byte |= (1 << 2); pci_write_config8(dev, 0x40, byte); - /* Set SATA Operation Mode, Set to IDE mode */ + /* Set SATA Operation Mode */ byte = pci_read_config8(dev, 0x40); byte |= (1 << 0); byte |= (1 << 4); pci_write_config8(dev, 0x40, byte); - dword = 0x01018f00; + // 1 means IDE, 0 means AHCI + if( get_option(&i, "sata_mode") < 0 ) { + // no cmos option + i = CONFIG_SATA_MODE; + } + printk(BIOS_INFO, "%s: setting sata mode = %s\n", __func__, (i == SATA_MODE_IDE)?"ide":"ahci" ); + + dword = pci_read_config32(dev, 0x8); + dword &= 0xff0000ff; + if (i == SATA_MODE_IDE) + dword |= 0x00018f00; // IDE mode + else + dword |= 0x00060100; // AHCI mode pci_write_config32(dev, 0x8, dword); byte = pci_read_config8(dev, 0x40); @@ -245,7 +257,7 @@ } static struct pci_operations lops_pci = { - /* .set_subsystem = pci_dev_set_subsystem, */ + .set_subsystem = pci_dev_set_subsystem, }; static struct device_operations sata_ops = {

1 0

searching volunteer to install coreboot on asus m4a78 pro
by Jelle de Jong 24 Feb '11

24 Feb '11

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Hello everybody, I would like to start with thanking all volunteers on the coreboot project! At FOSDEM 2011 I had dinner with two of the volunteers. I have been watching the coreboot for the past years, as something that I love to have running on my motherboards but never found the time/resources to made a first step. I would like to get coreboot on this system[1]. I would like the coreboot to be installed by a volunteer. I can provide ssh access (both ipv4 and ipv6) and a root passwd to the machine, and standby to help over IRC. [1] http://debian.pastebin.com/mqphUf5U # details ASUSTeK M4A78 PRO Features I would like: * Serial Console Redirection * AMD Athlon II X4 615e support * ECC Memory support * Readout volt,temp,rpm sensors * Boot 2.6 kernel support * Grub 2 (lvm, mdadm, ext4) support I got two M4A78 PRO motherboards that I would like to give new life by getting coreboot on them. With kind regards, Jelle de Jong -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (GNU/Linux) iJwEAQECAAYFAk1T/5sACgkQ1WclBW9j5HlTBwP+KOImcCztj3LYsrMKGO5nMO0x shPLdP+Zaa+kgM4pJP2QX748f9ibZEQGYlljbb3ZdgPzPYEguuGyZrFU+TfjTDHx ePQhfxf6IiySOMGqMLDJ7Gyd+xBVujuzvZXaF7JXfwEuXX0bQLZyq+qjEI14pKfu 0tVUxrAThodY4+a+SO4= =x6PR -----END PGP SIGNATURE-----

3 7

build service results for r6378
by repository service 24 Feb '11

24 Feb '11

Dear coreboot readers! This is the automatic build system of coreboot. The developer "oxygene" checked in revision 6378 to the coreboot repository. This caused the following changes: Change Log: Tyan/s2735 doesn't need to define its own hard_reset function anymore. The southbridge already provides hard_reset. Signed-off-by: Patrick Georgi <patrick.georgi(a)secunet.com> Acked-by: Patrick Georgi <patrick.georgi(a)secunet.com> Build Log: Compilation of tyan:s2735 has been fixed If something broke during this checkin please be a pain in oxygene's neck until the issue is fixed. If this issue is not fixed within 24h the revision should be backed out. Best regards, coreboot automatic build system

1 0

build service results for r6377
by repository service 23 Feb '11

23 Feb '11

Dear coreboot readers! This is the automatic build system of coreboot. The developer "oxygene" checked in revision 6377 to the coreboot repository. This caused the following changes: Change Log: libpayload: Move stdin/stdout/stderr away from headers Otherwise they exist in several object files, confusing the linker Signed-off-by: Patrick Georgi <patrick.georgi(a)secunet.com> Acked-by: Peter Stuge <peter(a)stuge.se> Build Log: Compilation of tyan:s2735 is still broken See the error log at http://qa.coreboot.org/log_buildbrd.php?revision=6377&device=s2735&vendor=t… If something broke during this checkin please be a pain in oxygene's neck until the issue is fixed. If this issue is not fixed within 24h the revision should be backed out. Best regards, coreboot automatic build system

1 0

[commit] r6377 - in trunk/payloads/libpayload: include libc
by repository service 23 Feb '11

23 Feb '11

Author: oxygene Date: Thu Feb 24 08:18:11 2011 New Revision: 6377 URL: https://tracker.coreboot.org/trac/coreboot/changeset/6377 Log: libpayload: Move stdin/stdout/stderr away from headers Otherwise they exist in several object files, confusing the linker Signed-off-by: Patrick Georgi <patrick.georgi(a)secunet.com> Acked-by: Peter Stuge <peter(a)stuge.se> Modified: trunk/payloads/libpayload/include/curses.h trunk/payloads/libpayload/include/stdio.h trunk/payloads/libpayload/libc/printf.c Modified: trunk/payloads/libpayload/include/curses.h ============================================================================== --- trunk/payloads/libpayload/include/curses.h Thu Feb 24 06:00:33 2011 (r6376) +++ trunk/payloads/libpayload/include/curses.h Thu Feb 24 08:18:11 2011 (r6377) @@ -148,11 +148,7 @@ typedef unsigned long mmask_t; #endif -//// #include <stdio.h> -struct _IO_FILE { - // FIXME -}; -typedef struct _IO_FILE FILE; +#include <stdio.h> //// #include <ncursesw/unctrl.h> #include <stdarg.h> /* we need va_list */ //// #define va_list int // FIXME Modified: trunk/payloads/libpayload/include/stdio.h ============================================================================== --- trunk/payloads/libpayload/include/stdio.h Thu Feb 24 06:00:33 2011 (r6376) +++ trunk/payloads/libpayload/include/stdio.h Thu Feb 24 08:18:11 2011 (r6377) @@ -32,14 +32,9 @@ #include <stddef.h> -struct _FILE { -} _stdout, _stdin, _stderr; - typedef struct _FILE FILE; -FILE *stdout = &_stdout; -FILE *stdin = &_stdin; -FILE *stderr = &_stderr; +extern FILE *stdout, *stdin, *stderr; /** * @defgroup printf Print functions Modified: trunk/payloads/libpayload/libc/printf.c ============================================================================== --- trunk/payloads/libpayload/libc/printf.c Thu Feb 24 06:00:33 2011 (r6376) +++ trunk/payloads/libpayload/libc/printf.c Thu Feb 24 08:18:11 2011 (r6377) @@ -36,6 +36,13 @@ #include <libpayload.h> #include <ctype.h> +static struct _FILE { +} _stdout, _stdin, _stderr; + +FILE *stdout = &_stdout; +FILE *stdin = &_stdin; +FILE *stderr = &_stderr; + /** Structure for specifying output methods for different printf clones. */ struct printf_spec { /* Output function, returns count of printed characters or EOF. */

1 0

Re: [coreboot] [PATCH 2/3] libpayload: Move stdin/stdout/stderr away from headers
by Georgi, Patrick 23 Feb '11

23 Feb '11

Am Dienstag, den 22.02.2011, 11:23 -0700 schrieb Marc Jones: > This change breaks the default config build of libpayload. The problem > is stdio.h and curses.h having FILE definitions. stdio.h include is > commented out of curses.h, but adding it causes multiple definition > issues. Do you have thoughts on the right way to fix this? Updated patch attached. Patrick -- Patrick Georgi SINA-Development - High Security secunet Security Networks AG - Mergenthalerallee 77 - 65760 Eschborn, Germany Phone +49 201 54 54-3610 - Fax +49 201 54 54-1325 - www.secunet.com Sitz: Kronprinzenstraße 30, 45128 Essen / Amtsgericht Essen HRB 13615 Vorstand: Dr. Rainer Baumgart (Vors.), Thomas Koelzer, Thomas Pleines Aufsichtsratsvorsitzender: Dr. Karsten Ottenberg

2 1

build service results for r6376
by repository service 23 Feb '11

23 Feb '11

Dear coreboot readers! This is the automatic build system of coreboot. The developer "sduplichan" checked in revision 6376 to the coreboot repository. This caused the following changes: Change Log: Build Log: Compilation of tyan:s2735 is still broken See the error log at http://qa.coreboot.org/log_buildbrd.php?revision=6376&device=s2735&vendor=t… If something broke during this checkin please be a pain in sduplichan's neck until the issue is fixed. If this issue is not fixed within 24h the revision should be backed out. Best regards, coreboot automatic build system

1 0

← Newer
1
...
8
9
10
11
12
13
14
...
29
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

coreboot February 2011