Florian Zumbiehl just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/370
-gerrit
commit 52522b3ff384051595fe209c678937e9c5ed8710
Author: Florian Zumbiehl <florz(a)florz.de>
Date: Tue Nov 1 20:17:12 2011 +0100
Cycle time at CAS Latency (CLX - 2) is at 25 in DDR2 SPD, not at 26
Change-Id: Ic77854130ad43715daa7c0eb462291db48df9f84
Signed-off-by: Florian Zumbiehl <florz(a)florz.de>
---
src/northbridge/amd/amdk8/raminit_f.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/src/northbridge/amd/amdk8/raminit_f.c b/src/northbridge/amd/amdk8/raminit_f.c
index 319293b..dc3addb 100644
--- a/src/northbridge/amd/amdk8/raminit_f.c
+++ b/src/northbridge/amd/amdk8/raminit_f.c
@@ -1446,7 +1446,7 @@ static long spd_enable_2channels(const struct mem_controller *ctrl, struct mem_i
18, /* *Supported CAS Latencies */
9, /* *Cycle time at highest CAS Latency CL=X */
23, /* *Cycle time at CAS Latency (CLX - 1) */
- 26, /* *Cycle time at CAS Latency (CLX - 2) */
+ 25, /* *Cycle time at CAS Latency (CLX - 2) */
};
u32 dcl, dcm;
u8 common_cl;
Florian Zumbiehl just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/374
-gerrit
commit 08d627bbecef1178921e16b45ed83538c1d35ccd
Author: Florian Zumbiehl <florz(a)florz.de>
Date: Tue Nov 1 20:17:41 2011 +0100
compile code for CONFIG_SOUTHBRIDGE_VIA_K8T800_OLD
make code dependent on CONFIG_SOUTHBRIDGE_VIA_K8T800 also be included
for CONFIG_SOUTHBRIDGE_VIA_K8T800_OLD
Change-Id: I9f4624d08de2790fb513a88ed6207e28e7fbc733
Signed-off-by: Florian Zumbiehl <florz(a)florz.de>
---
src/southbridge/via/k8t890/romstrap.inc | 2 +-
src/southbridge/via/vt8237r/lpc.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/southbridge/via/k8t890/romstrap.inc b/src/southbridge/via/k8t890/romstrap.inc
index 5b24948..a3814b0 100644
--- a/src/southbridge/via/k8t890/romstrap.inc
+++ b/src/southbridge/via/k8t890/romstrap.inc
@@ -33,7 +33,7 @@ __romstrap_start:
* Below are some Dev0 Func2 HT control registers values,
* depending on strap pin, one of below lines is used.
*/
-#if CONFIG_SOUTHBRIDGE_VIA_K8M800 || CONFIG_SOUTHBRIDGE_VIA_K8T800
+#if CONFIG_SOUTHBRIDGE_VIA_K8M800 || CONFIG_SOUTHBRIDGE_VIA_K8T800 || CONFIG_SOUTHBRIDGE_VIA_K8T800_OLD
tblpointer:
.long 0x50220000, 0X619707C2
diff --git a/src/southbridge/via/vt8237r/lpc.c b/src/southbridge/via/vt8237r/lpc.c
index e599517..b1e1afe 100644
--- a/src/southbridge/via/vt8237r/lpc.c
+++ b/src/southbridge/via/vt8237r/lpc.c
@@ -298,7 +298,7 @@ static void vt8237r_init(struct device *dev)
pci_write_config8(dev, 0x48, 0x0c);
#else
- #if CONFIG_SOUTHBRIDGE_VIA_K8T800
+ #if CONFIG_SOUTHBRIDGE_VIA_K8T800 || CONFIG_SOUTHBRIDGE_VIA_K8T800_OLD
/* It seems that when we pair with the K8T800, we need to disable
* the A2 mask
*/
Florian Zumbiehl just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/368
-gerrit
commit 99e767bfc0b2c9ee8fac96fbb66644161f0ea39a
Author: Florian Zumbiehl <florz(a)florz.de>
Date: Tue Nov 1 20:16:16 2011 +0100
in vt8237r_enable(), write function enables only to ISA bridge config space
vt8237r_enable() so far wrote the function enable values to the same
offset in the config space of every one of the vt8237's functions,
even though the register is located in the ISA bridge only.
Change-Id: I639586dc238132f5b8d2f320b794948718281b9c
Signed-off-by: Florian Zumbiehl <florz(a)florz.de>
---
src/southbridge/via/vt8237r/vt8237r.c | 14 ++++++++++++--
1 files changed, 12 insertions(+), 2 deletions(-)
diff --git a/src/southbridge/via/vt8237r/vt8237r.c b/src/southbridge/via/vt8237r/vt8237r.c
index 5ba3815..586df66 100644
--- a/src/southbridge/via/vt8237r/vt8237r.c
+++ b/src/southbridge/via/vt8237r/vt8237r.c
@@ -66,11 +66,21 @@ void dump_south(device_t dev)
static void vt8237r_enable(struct device *dev)
{
+ u16 vid, did;
struct southbridge_via_vt8237r_config *sb =
(struct southbridge_via_vt8237r_config *)dev->chip_info;
- pci_write_config8(dev, 0x50, sb->fn_ctrl_lo);
- pci_write_config8(dev, 0x51, sb->fn_ctrl_hi);
+ if (dev->path.type == DEVICE_PATH_PCI) {
+ vid = pci_read_config16(dev, PCI_VENDOR_ID);
+ did = pci_read_config16(dev, PCI_DEVICE_ID);
+ if (vid == PCI_VENDOR_ID_VIA &&
+ (did == PCI_DEVICE_ID_VIA_VT8237R_LPC ||
+ did == PCI_DEVICE_ID_VIA_VT8237A_LPC ||
+ did == PCI_DEVICE_ID_VIA_VT8237S_LPC)) {
+ pci_write_config8(dev, 0x50, sb->fn_ctrl_lo);
+ pci_write_config8(dev, 0x51, sb->fn_ctrl_hi);
+ }
+ }
/* TODO: If SATA is disabled, move IDE to fn0 to conform PCI specs. */
}
Florian Zumbiehl just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/391
-gerrit
commit 1f2aab2500227d50b5f5f141207c61b2a3e3e92e
Author: Florian Zumbiehl <florz(a)florz.de>
Date: Wed Nov 2 09:46:34 2011 +0100
fix superiotool for NCT6776F
The current code exits config mode of the NCT6776F immediately after
detection, so the register dump shows all 0xffs. This patch adds code to
re-enter config mode for the register dump so that the register contents
can be read.
Change-Id: I4ad0c108b6411a665e31f55dea4b91ca77d1a5f7
Signed-off-by: Florian Zumbiehl <florz(a)florz.de>
---
util/superiotool/nuvoton.c | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/util/superiotool/nuvoton.c b/util/superiotool/nuvoton.c
index 6a1a75c..ed2eabc 100644
--- a/util/superiotool/nuvoton.c
+++ b/util/superiotool/nuvoton.c
@@ -255,7 +255,9 @@ void probe_idregs_nuvoton(uint16_t port)
printf("Found Nuvoton %s (id=0x%02x) at 0x%x\n",
get_superio_name(reg_table, chip_id), chip_id, port);
chip_found = 1;
+ enter_conf_mode_winbond_fintek_ite_8787(port);
dump_superio("Nuvoton", reg_table, port, chip_id, LDN_SEL);
+ exit_conf_mode_winbond_fintek_ite_8787(port);
return;
}