coreboot September 2009

coreboot@coreboot.org

62 participants
305 discussions

[v2] r4643 - in trunk/coreboot-v2/src: . console devices
by svn＠coreboot.org 17 Sep '09

17 Sep '09

Author: myles Date: 2009-09-17 18:54:46 +0200 (Thu, 17 Sep 2009) New Revision: 4643 Modified: trunk/coreboot-v2/src/Kconfig trunk/coreboot-v2/src/console/Kconfig trunk/coreboot-v2/src/devices/Kconfig trunk/coreboot-v2/src/devices/device.c Log: Separate CONFIG_VGA_CONSOLE from CONFIG_VGA_BRIDGE_SETUP. Signed-off-by: Myles Watson <mylesgw(a)gmail.com> Acked-by: Peter Stuge <peter(a)stuge.se> Modified: trunk/coreboot-v2/src/Kconfig =================================================================== --- trunk/coreboot-v2/src/Kconfig 2009-09-17 16:21:31 UTC (rev 4642) +++ trunk/coreboot-v2/src/Kconfig 2009-09-17 16:54:46 UTC (rev 4643) @@ -282,7 +282,8 @@ depends on VGA_BIOS default "1106,3230" help - The ID that would associate your VGA BIOS to your video card. + The ID that would associate your VGA BIOS to your video card. + (PCI VendorID, PCI Device ID) endmenu Modified: trunk/coreboot-v2/src/console/Kconfig =================================================================== --- trunk/coreboot-v2/src/console/Kconfig 2009-09-17 16:21:31 UTC (rev 4642) +++ trunk/coreboot-v2/src/console/Kconfig 2009-09-17 16:54:46 UTC (rev 4643) @@ -29,7 +29,7 @@ # TODO: FIX DEPENDENCY HERE config CONSOLE_VGA - bool + bool "Use VGA console, once initialized." default n config MAXIMUM_CONSOLE_LOGLEVEL Modified: trunk/coreboot-v2/src/devices/Kconfig =================================================================== --- trunk/coreboot-v2/src/devices/Kconfig 2009-09-17 16:21:31 UTC (rev 4642) +++ trunk/coreboot-v2/src/devices/Kconfig 2009-09-17 16:54:46 UTC (rev 4643) @@ -20,6 +20,13 @@ menu "Devices" +config VGA_BRIDGE_SETUP + bool "Setup bridges on path to VGA adapter" + default y + help + Allow bridges to set up legacy decoding ranges for VGA. Don't disable + this unless you're sure you don't want the briges setup for VGA. + config VGA_ROM_RUN bool "Run VGA Option ROMs" help @@ -32,11 +39,11 @@ Execute non-VGA PCI option ROMs if found. choice - prompt "Option ROM Execution" - default PCI_OPTION_ROM_RUN_REALMODE + prompt "Option ROM Execution" + default PCI_OPTION_ROM_RUN_REALMODE depends on PCI_ROM_RUN || VGA_ROM_RUN - help - You can choose to execute PCI option ROMs natively (32bit x86 system + help + You can choose to execute PCI option ROMs natively (32bit x86 system required) or in an emulator (x86emu or YABEL). config PCI_OPTION_ROM_RUN_REALMODE @@ -62,6 +69,10 @@ endmenu +config CONSOLE_VGA_MULTI + bool + default n + config PCI_64BIT_PREF_MEM bool default n @@ -85,6 +96,3 @@ config CARDBUS_PLUGIN_SUPPORT bool default n - - - Modified: trunk/coreboot-v2/src/devices/device.c =================================================================== --- trunk/coreboot-v2/src/devices/device.c 2009-09-17 16:21:31 UTC (rev 4642) +++ trunk/coreboot-v2/src/devices/device.c 2009-09-17 16:54:46 UTC (rev 4643) @@ -667,7 +667,7 @@ } } -#if CONFIG_CONSOLE_VGA == 1 +#if CONFIG_VGA_BRIDGE_SETUP == 1 device_t vga_pri = 0; static void set_vga_bridge_bits(void) { @@ -926,7 +926,7 @@ struct device *child; int i; -#if CONFIG_CONSOLE_VGA == 1 +#if CONFIG_VGA_BRIDGE_SETUP == 1 set_vga_bridge_bits(); #endif

1 0

[v2] r4642 - trunk/coreboot-v2/src
by svn＠coreboot.org 17 Sep '09

17 Sep '09

Author: stuge Date: 2009-09-17 18:21:31 +0200 (Thu, 17 Sep 2009) New Revision: 4642 Modified: trunk/coreboot-v2/src/Kconfig Log: Move VGA BIOS settings from the payload menu into it's own menu Remove dependency on PAYLOAD_ELF so that config items are shown. Build tested. With this, coreboot.rom has a VGA BIOS optionrom added. Signed-off-by: Peter Stuge <peter(a)stuge.se> Acked-by: Patrick Georgi <patrick.georgi(a)coresystems.de> Modified: trunk/coreboot-v2/src/Kconfig =================================================================== --- trunk/coreboot-v2/src/Kconfig 2009-09-17 15:35:08 UTC (rev 4641) +++ trunk/coreboot-v2/src/Kconfig 2009-09-17 16:21:31 UTC (rev 4642) @@ -238,17 +238,6 @@ You will be able to specify the location and file name of the payload image later. - -config VGA_BIOS - bool "Add a VGA BIOS image" - depends on PAYLOAD_ELF - help - Select this option if you have a VGA BIOS image that you would - like to add to your ROM. - - You will be able to specify the location and file name of the - image later. - config PAYLOAD_NONE bool "No payload" help @@ -268,6 +257,19 @@ help The path and filename of the ELF executable file to use as payload. +endmenu + +menu "VGA BIOS" + +config VGA_BIOS + bool "Add a VGA BIOS image" + help + Select this option if you have a VGA BIOS image that you would + like to add to your ROM. + + You will be able to specify the location and file name of the + image later. + config FALLBACK_VGA_BIOS_FILE string "VGA BIOS path and filename" depends on VGA_BIOS

1 0

r4633 building error of serengeti_cheetah_fam10
by Bao, Zheng 17 Sep '09

17 Sep '09

I am using FC10. GCC 4.3.2. ............................... make[1]: Leaving directory `/home/baozheng/LinuxBIOS/coreboot-v2-org/util/cbfstool' make -C fallback coreboot.rom cat: ../../VERSION: No such file or directory make[1]: Entering directory `/home/baozheng/LinuxBIOS/coreboot-v2-org/targets/amd/serengeti_cheetah_ fam10/serengeti_cheetah_fam10/fallback' gcc -m32 -x assembler-with-cpp -DASSEMBLY -E -I/home/baozheng/LinuxBIOS/coreboot-v2-org/src/include -I/home/baozheng/LinuxBIOS/coreboot-v2-org/src/arch/i386/include -I/usr/lib/gcc/i386-redhat-linux/4.3.2/include -include /home/baozheng/LinuxBIOS/coreboot-v2-org/targets/amd/serengeti_cheetah_f am10/serengeti_cheetah_fam10/fallback/settings.h -I/home/baozheng/LinuxBIOS/coreboot-v2-org/util/x86emu/include -I. -I/home/baozheng/LinuxBIOS/coreboot-v2-org/src crt0.S > crt0.s.new && mv crt0.s.new crt0.s gcc -m32 -Wa,-acdlns -c -o crt0.o crt0.s >crt0.disasm gcc -m32 -Wl,--build-id=none -nostdlib -nostartfiles -static -o coreboot -T ldscript.ld crt0.o src/lib/lzma.o src/lib/cbfs.o src/arch/i386/lib/cbfs_and_run.o src/lib/uart8250.o src/lib/memcmp.o src/lib/memcpy.o src/lib/memset.o src/console/vtxprintf.o src/arch/i386/lib/printk_init.o nm -n coreboot | sort > coreboot.map objdump -dS coreboot > coreboot.disasm objcopy --gap-fill 0xff -O binary coreboot coreboot.strip PAYLOAD=payload; if [ 1 -eq 1 ]; then PAYLOAD=/dev/null; touch cbfs-support; fi; ./buildrom coreboot.strip coreboot.rom $PAYLOAD 0x7f000 0x7f000 Payload: 0 coreboot: 520192 ROM size: 520192 Left space: 0 if [ 0 -eq 1 -a 1 -eq 1 ]; then echo l > cbfs-support; fi make[1]: Leaving directory `/home/baozheng/LinuxBIOS/coreboot-v2-org/targets/amd/serengeti_cheetah_ fam10/serengeti_cheetah_fam10/fallback' make -C failover coreboot.rom cat: ../../VERSION: No such file or directory make[1]: Entering directory `/home/baozheng/LinuxBIOS/coreboot-v2-org/targets/amd/serengeti_cheetah_ fam10/serengeti_cheetah_fam10/failover' gcc -m32 -x assembler-with-cpp -DASSEMBLY -E -I/home/baozheng/LinuxBIOS/coreboot-v2-org/src/include -I/home/baozheng/LinuxBIOS/coreboot-v2-org/src/arch/i386/include -I/usr/lib/gcc/i386-redhat-linux/4.3.2/include -include /home/baozheng/LinuxBIOS/coreboot-v2-org/targets/amd/serengeti_cheetah_f am10/serengeti_cheetah_fam10/failover/settings.h -I/home/baozheng/LinuxBIOS/coreboot-v2-org/util/x86emu/include -I. -I/home/baozheng/LinuxBIOS/coreboot-v2-org/src crt0.S > crt0.s.new && mv crt0.s.new crt0.s gcc -m32 -Wa,-acdlns -c -o crt0.o crt0.s >crt0.disasm gcc -m32 -Wl,--build-id=none -nostdlib -nostartfiles -static -o coreboot -T ldscript.ld crt0.o src/lib/uart8250.o src/lib/memcmp.o src/lib/memcpy.o src/lib/memset.o src/console/vtxprintf.o src/arch/i386/lib/printk_init.o nm -n coreboot | sort > coreboot.map objdump -dS coreboot > coreboot.disasm objcopy --gap-fill 0xff -O binary coreboot coreboot.strip cp coreboot.strip coreboot.rom make[1]: Leaving directory `/home/baozheng/LinuxBIOS/coreboot-v2-org/targets/amd/serengeti_cheetah_ fam10/serengeti_cheetah_fam10/failover' rm -f ./coreboot.rom cat fallback/coreboot.rom failover/coreboot.rom > ./coreboot.rom.bootblock ./cbfs/cbfstool ./coreboot.rom create 1048576 528384 ./coreboot.rom.bootblock ./cbfs/cbfstool ./coreboot.rom add-payload ../payload.elf fallback/payload make: *** [coreboot.rom] Segmentation fault make: *** Deleting file `coreboot.rom'

3 10

patch: fix cbfstool malloc arena corruption
by ron minnich 17 Sep '09

17 Sep '09

2 2

[v2] r4641 - trunk/coreboot-v2/util/cbfstool
by svn＠coreboot.org 17 Sep '09

17 Sep '09

Author: rminnich Date: 2009-09-17 17:35:08 +0200 (Thu, 17 Sep 2009) New Revision: 4641 Modified: trunk/coreboot-v2/util/cbfstool/Makefile trunk/coreboot-v2/util/cbfstool/cbfs-mkpayload.c Log: There was a missing addition of the size of the .notes.pinfo section header which could lead to corrupted malloc arena. Also, make cbfstool always build with debugging on. Performance is not an issue here. Don't strip it either. Signed-off-by: Ronald G. Minnich <rminnich(a)gmail.com> Acked-by: Peter Stuge <peter(a)stuge.se> Modified: trunk/coreboot-v2/util/cbfstool/Makefile =================================================================== --- trunk/coreboot-v2/util/cbfstool/Makefile 2009-09-17 00:28:29 UTC (rev 4640) +++ trunk/coreboot-v2/util/cbfstool/Makefile 2009-09-17 15:35:08 UTC (rev 4641) @@ -2,7 +2,9 @@ HOSTCXX ?= g++ HOSTCC ?= gcc +CFLAGS ?= -g + BINARY:=$(obj)/cbfstool COMMON:=common.o compress.o minilzma.o Modified: trunk/coreboot-v2/util/cbfstool/cbfs-mkpayload.c =================================================================== --- trunk/coreboot-v2/util/cbfstool/cbfs-mkpayload.c 2009-09-17 00:28:29 UTC (rev 4640) +++ trunk/coreboot-v2/util/cbfstool/cbfs-mkpayload.c 2009-09-17 15:35:08 UTC (rev 4641) @@ -75,8 +75,10 @@ name = (char *)(strtab + shdr[i].sh_name); - if (!strcmp(name, ".note.pinfo")) + if (!strcmp(name, ".note.pinfo")) { segments++; + isize += (unsigned int)shdr[i].sh_size; + } } /* Now, regular headers - we only care about PT_LOAD headers,

1 0

[v2] r4640 - trunk/coreboot-v2/src/mainboard/dell/s1850
by svn＠coreboot.org 17 Sep '09

17 Sep '09

Author: rminnich Date: 2009-09-17 02:28:29 +0200 (Thu, 17 Sep 2009) New Revision: 4640 Modified: trunk/coreboot-v2/src/mainboard/dell/s1850/auto.c Log: This is a patch for killing IPMI on the s1850 -- or at least geting the BMC out of the way of the serial port. Tested extensively in user mode. Works and gets the BMC out of my way, which is good, because there are few more useless things than IPMI and the BMC. The BMC, all by itself, is the cause of most of our problems in booting and talking to these nodes. Signed-off-by: Ronald G. Minnich <rminnich(a)gmail.com> Acked-by: Peter Stuge <peter(a)stuge.se> Modified: trunk/coreboot-v2/src/mainboard/dell/s1850/auto.c =================================================================== --- trunk/coreboot-v2/src/mainboard/dell/s1850/auto.c 2009-09-17 00:24:52 UTC (rev 4639) +++ trunk/coreboot-v2/src/mainboard/dell/s1850/auto.c 2009-09-17 00:28:29 UTC (rev 4640) @@ -74,6 +74,107 @@ #include "sdram/generic_sdram.c" +/* IPMI garbage. This is all test stuff, if it really works we'll move it somewhere + */ + +#define nftransport 0xc + +#define OBF 0 +#define IBF 1 + +#define ipmidata 0xca0 +#define ipmicsr 0xca4 + + +static inline void ibfzero(void) +{ + while(inb(ipmicsr) & (1<<IBF)) + ; +} +static inline void clearobf(void) +{ + (void) inb(ipmidata); +} + +static inline void waitobf(void) +{ + while((inb(ipmicsr) & (1<<OBF)) == 0) + ; +} +/* quite possibly the stupidest interface ever designed. */ +static inline void first_cmd_byte(unsigned char byte) +{ + ibfzero(); + clearobf(); + outb(0x61, ipmicsr); + ibfzero(); + clearobf(); + outb(byte, ipmidata); +} + +static inline void next_cmd_byte(unsigned char byte) +{ + + ibfzero(); + clearobf(); + outb(byte, ipmidata); +} + +static inline void last_cmd_byte(unsigned char byte) +{ + outb(0x62, ipmicsr); + + ibfzero(); + clearobf(); + outb(byte, ipmidata); +} + +static inline void read_response_byte(void) +{ + int val = -1; + if ((inb(ipmicsr)>>6) != 1) + return; + + ibfzero(); + waitobf(); + val = inb(ipmidata); + outb(0x68, ipmidata); + + /* see if it is done */ + if ((inb(ipmicsr)>>6) != 1){ + /* wait for the dummy read. Which describes this protocol */ + waitobf(); + (void)inb(ipmidata); + } +} + +static inline void ipmidelay(void) +{ + int i; + for(i = 0; i < 1000; i++) { + inb(0x80); + } +} + +static inline void bmc_foad(void) +{ + unsigned char c; + /* be safe; make sure it is really ready */ + while ((inb(ipmicsr)>>6)) { + outb(0x60, ipmicsr); + inb(ipmidata); + } + first_cmd_byte(nftransport << 2); + ipmidelay(); + next_cmd_byte(0x12); + ipmidelay(); + next_cmd_byte(2); + ipmidelay(); + last_cmd_byte(3); + ipmidelay(); +} + +/* end IPMI garbage */ static void main(unsigned long bist) { /* @@ -100,6 +201,7 @@ } } /* Setup the console */ + bmc_foad(); outb(0x87,0x2e); outb(0x87,0x2e); pnp_write_config(CONSOLE_SERIAL_DEV, 0x24, 0x84 | (1 << 6));

1 0

[v2] r4639 - trunk/coreboot-v2/src/mainboard/dell/s1850
by svn＠coreboot.org 17 Sep '09

17 Sep '09

Author: rminnich Date: 2009-09-17 02:24:52 +0200 (Thu, 17 Sep 2009) New Revision: 4639 Modified: trunk/coreboot-v2/src/mainboard/dell/s1850/irq_tables.c Log: copyright name error. I don't know what else to do for files generated by programs ... Signed-off-by: Ronald G. Minnich <rminnich(a)gmail.com> Acked-by: Ronald G. Minnich <rminnich(a)gmail.com> Modified: trunk/coreboot-v2/src/mainboard/dell/s1850/irq_tables.c =================================================================== --- trunk/coreboot-v2/src/mainboard/dell/s1850/irq_tables.c 2009-09-16 20:18:03 UTC (rev 4638) +++ trunk/coreboot-v2/src/mainboard/dell/s1850/irq_tables.c 2009-09-17 00:24:52 UTC (rev 4639) @@ -1,8 +1,8 @@ /* * This file is part of the coreboot project. * - * Copyright (C) 2008 VIA Technologies, Inc. - * (Written by Aaron Lwe <aaron.lwe(a)gmail.com> for VIA) + * Copyright (C) by the coreboot pirq tool. + * This file was programatically generated. * * This program is free software; you can redistribute it and/or modify * it under the terms of the GNU General Public License as published by

1 0

new cbfstool has an allocation bug of some sort
by ron minnich 17 Sep '09

17 Sep '09

There is unquestionably a bug in the allocation in int parse_elf_to_payload that is resulting in a trashed malloc arena. I'm not quite sure I understand it yet but this happens: I have a filo payload which has 47516 bytes of data in two segments. The code parse_elf_to_payload computes the amount of memory to allocate and computes 47628. But the code then goes on to overwrite 47676 bytes of data. There is some simple calculation going wrong, starting me in the face ... I don't see it yet, but one of you might. The result is this: *** glibc detected *** ./cbfs/cbfstool: malloc: top chunk is corrupt: 0x0000000000d4fd60 *** I have fixed this for now: I allocate 1048576 more bytes then needed :-) ron

1 0

Embedded Systems Event Boston, MA
by Joseph Smith 16 Sep '09

16 Sep '09

http://esc-boston.techinsightsevents.com/ Too bad I didn't see this sooner, I would have loved to show off coreboot on the Kontron 986LCD-M/mITX seeing how Kontron is going to be there. Maybe next time. -- Thanks, Joseph Smith Set-Top-Linux www.settoplinux.org

2 1

Re: [coreboot] #16: I2C driver and mainboard Config.lb
by coreboot 16 Sep '09

16 Sep '09

#16: I2C driver and mainboard Config.lb ----------------------+----------------------------------------------------- Reporter: stepan | Owner: ollie Type: defect | Status: new Priority: minor | Milestone: Component: coreboot | Version: v2 Keywords: | Dependencies: ----------------------+----------------------------------------------------- Comment(by JohnMlkolkzzbvvfa): http://gologle.com, <a href=gologle.com>goolgle</a> -- Ticket URL: <http://tracker.coreboot.org/trac/coreboot/ticket/16#comment:1> coreboot <http://www.coreboot.org/>

2 2

← Newer
1
...
22
23
24
25
26
27
28
...
31
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

coreboot September 2009