coreboot September 2009

coreboot@coreboot.org

62 participants
305 discussions

[v2] r4678 - trunk/coreboot-v2/util/cbfstool
by svn＠coreboot.org 25 Sep '09

25 Sep '09

Author: cristi Date: 2009-09-26 00:21:47 +0200 (Sat, 26 Sep 2009) New Revision: 4678 Modified: trunk/coreboot-v2/util/cbfstool/cbfs-mkpayload.c Log: check for ELF payloads in cbfstool Signed-off-by: Cristi Magherusan <cristi.magherusan(a)net.utcluj.ro> Acked-by: Cristi Magherusan <cristi.magherusan(a)net.utcluj.ro> Modified: trunk/coreboot-v2/util/cbfstool/cbfs-mkpayload.c =================================================================== --- trunk/coreboot-v2/util/cbfstool/cbfs-mkpayload.c 2009-09-25 21:59:57 UTC (rev 4677) +++ trunk/coreboot-v2/util/cbfstool/cbfs-mkpayload.c 2009-09-25 22:21:47 UTC (rev 4678) @@ -48,6 +48,12 @@ struct cbfs_payload_segment *segs; int i; + if(!iself(input)){ + printf("Fatal error: the payload file is not in ELF format!\n"); + exit(1); + } + + comp_func_ptr compress = compression_function(algo); if (!compress) return -1;

1 0

build service results for r4676
by coreboot information 25 Sep '09

25 Sep '09

Dear coreboot readers! This is the automatic build system of coreboot. The developer "stepan" checked in revision 4676 to the coreboot repository. This caused the following changes: Change Log: improve lzma error messages. When coreboot panics because lzma decompression goes wrong, it might not be clear that it's lzma that failed, if the log level is low enough.. Signed-off-by: Stefan Reinauer <stepan(a)coresystems.de> Acked-by: Stefan Reinauer <stepan(a)coresystems.de> Build Log: Compilation of embeddedplanet:ep405pc is still broken See the error log at http://qa.coreboot.org/log_buildbrd.php?revision=4676&device=ep405pc&vendor… Compilation of motorola:sandpointx3_altimus_mpc7410 is still broken See the error log at http://qa.coreboot.org/log_buildbrd.php?revision=4676&device=sandpointx3_al… Compilation of totalimpact:briq is still broken See the error log at http://qa.coreboot.org/log_buildbrd.php?revision=4676&device=briq&vendor=to… If something broke during this checkin please be a pain in stepan's neck until the issue is fixed. If this issue is not fixed within 24h the revision should be backed out. Best regards, coreboot automatic build system

1 0

coreboot for Intel D945GCLF
by Ken.Fuchs＠bench.com 25 Sep '09

25 Sep '09

I'm trying to port coreboot to an Intel D945GCLF desktop board. Has anyone else worked on porting coreboot to it? I noticed the following coreboot mailing list message suggesting that its single DIMM slot could be an issue: http://www.coreboot.org/pipermail/coreboot/2008-October/041196.html Numerous mainboards support a single DIMM with coreboot. What's the issue with the D945GCLF having just one DIMM? Does anyone have suggestions on porting coreboot to the D945GCLF? Sincerely, Ken Fuchs

2 1

[v2] r4677 - in trunk/coreboot-v2/src: boot include lib
by svn＠coreboot.org 25 Sep '09

25 Sep '09

Author: stepan Date: 2009-09-25 23:59:57 +0200 (Fri, 25 Sep 2009) New Revision: 4677 Modified: trunk/coreboot-v2/src/boot/selfboot.c trunk/coreboot-v2/src/include/stdlib.h trunk/coreboot-v2/src/include/string.h trunk/coreboot-v2/src/lib/malloc.c Log: drop some dead code, clarify small comments and small cleanups to malloc.c Signed-off-by: Stefan Reinauer <stepan(a)coresystems.de> Acked-by: Stefan Reinauer <stepan(a)coresystems.de> Modified: trunk/coreboot-v2/src/boot/selfboot.c =================================================================== --- trunk/coreboot-v2/src/boot/selfboot.c 2009-09-25 21:57:25 UTC (rev 4676) +++ trunk/coreboot-v2/src/boot/selfboot.c 2009-09-25 21:59:57 UTC (rev 4677) @@ -394,6 +394,7 @@ segment++; + // FIXME: Explain what this is for(ptr = head->next; ptr != head; ptr = ptr->next) { if (new->s_srcaddr < ntohl((u32) segment->load_addr)) break; Modified: trunk/coreboot-v2/src/include/stdlib.h =================================================================== --- trunk/coreboot-v2/src/include/stdlib.h 2009-09-25 21:57:25 UTC (rev 4676) +++ trunk/coreboot-v2/src/include/stdlib.h 2009-09-25 21:59:57 UTC (rev 4677) @@ -12,13 +12,8 @@ #define MAX(a,b) ((a) > (b) ? (a) : (b)) #ifndef __ROMCC__ -extern void *malloc(size_t size); +void *malloc(size_t size); void free(void *ptr); - -/* Extensions to malloc... */ -typedef size_t malloc_mark_t; -void malloc_mark(malloc_mark_t *place); -void malloc_release(malloc_mark_t *place); #endif #endif /* STDLIB_H */ Modified: trunk/coreboot-v2/src/include/string.h =================================================================== --- trunk/coreboot-v2/src/include/string.h 2009-09-25 21:57:25 UTC (rev 4676) +++ trunk/coreboot-v2/src/include/string.h 2009-09-25 21:59:57 UTC (rev 4677) @@ -8,15 +8,12 @@ void *memmove(void *dest, const void *src, size_t n); void *memset(void *s, int c, size_t n); int memcmp(const void *s1, const void *s2, size_t n); +#ifndef __ROMCC__ int sprintf(char * buf, const char *fmt, ...); +#endif -// yes, linux has fancy ones. We don't care. This stuff gets used -// hardly at all. And the pain of including those files is just too high. +// simple string functions -//extern inline void strcpy(char *dst, char *src) {while (*src) *dst++ = *src++;} - -//extern inline int strlen(char *src) { int i = 0; while (*src++) i++; return i;} - static inline size_t strnlen(const char *src, size_t max) { size_t i = 0; Modified: trunk/coreboot-v2/src/lib/malloc.c =================================================================== --- trunk/coreboot-v2/src/lib/malloc.c 2009-09-25 21:57:25 UTC (rev 4676) +++ trunk/coreboot-v2/src/lib/malloc.c 2009-09-25 21:59:57 UTC (rev 4677) @@ -10,36 +10,27 @@ static void *free_mem_ptr = &_heap; /* Start of heap */ static void *free_mem_end_ptr = &_eheap; /* End of heap */ - -void malloc_mark(malloc_mark_t *place) -{ - *place = (malloc_mark_t)free_mem_ptr; - printk_spew("malloc_mark %p\n", free_mem_ptr); -} - -void malloc_release(malloc_mark_t *ptr) -{ - free_mem_ptr = (void *)*ptr; - printk_spew("malloc_release %p\n", free_mem_ptr); -} - void *malloc(size_t size) { void *p; MALLOCDBG("%s Enter, size %ld, free_mem_ptr %p\n", __func__, size, free_mem_ptr); + + /* Checking arguments */ if (size < 0) - die("Error! malloc: Size < 0"); + die("Error! malloc: size < 0"); + + /* Overzealous linker check */ if (free_mem_ptr <= 0) die("Error! malloc: Free_mem_ptr <= 0"); - free_mem_ptr = (void *)(((unsigned long)free_mem_ptr + 3) & ~3); /* Align */ + free_mem_ptr = (void *)ALIGN((unsigned long)free_mem_ptr, 4); p = (void *) free_mem_ptr; free_mem_ptr += size; if (free_mem_ptr >= free_mem_end_ptr) - die("Error! malloc: free_mem_ptr >= free_mem_end_ptr"); + die("Error! malloc: Out of memory (free_mem_ptr >= free_mem_end_ptr)"); MALLOCDBG("malloc %p\n", p); @@ -49,4 +40,5 @@ void free(void *where) { /* Don't care */ + MALLOCDBG("free %p\n", where); }

1 0

[v2] r4676 - trunk/coreboot-v2/src/lib
by svn＠coreboot.org 25 Sep '09

25 Sep '09

Author: stepan Date: 2009-09-25 23:57:25 +0200 (Fri, 25 Sep 2009) New Revision: 4676 Modified: trunk/coreboot-v2/src/lib/lzma.c Log: improve lzma error messages. When coreboot panics because lzma decompression goes wrong, it might not be clear that it's lzma that failed, if the log level is low enough.. Signed-off-by: Stefan Reinauer <stepan(a)coresystems.de> Acked-by: Stefan Reinauer <stepan(a)coresystems.de> Modified: trunk/coreboot-v2/src/lib/lzma.c =================================================================== --- trunk/coreboot-v2/src/lib/lzma.c 2009-09-25 19:53:59 UTC (rev 4675) +++ trunk/coreboot-v2/src/lib/lzma.c 2009-09-25 21:57:25 UTC (rev 4676) @@ -29,19 +29,19 @@ memcpy(properties, src, LZMA_PROPERTIES_SIZE); outSize = *(UInt32 *)(src + LZMA_PROPERTIES_SIZE); if (LzmaDecodeProperties(&state.Properties, properties, LZMA_PROPERTIES_SIZE) != LZMA_RESULT_OK) { - printk_warning("Incorrect stream properties\n"); + printk_warning("lzma: Incorrect stream properties.\n"); return 0; } mallocneeds = (LzmaGetNumProbs(&state.Properties) * sizeof(CProb)); if (mallocneeds > 15980) { - printk_warning("Decoder scratchpad too small!\n"); + printk_warning("lzma: Decoder scratchpad too small!\n"); return 0; } state.Probs = (CProb *)scratchpad; res = LzmaDecode(&state, src + LZMA_PROPERTIES_SIZE + 8, (SizeT)0xffffffff, &inProcessed, dst, outSize, &outProcessed); if (res != 0) { - printk_warning("Decoding error = %d\n", res); + printk_warning("lzma: Decoding error = %d\n", res); return 0; } return outSize;

1 0

Drivers vs. Objects
by Myles Watson 25 Sep '09

25 Sep '09

Drivers and objects seem interchangeable to me except that drivers get registered and checked against devices that are found during enumeration, that weren't mentioned in devicetree.cb. Either one seems to get linked into the correct place if the device is mentioned in the device tree. Are there other differences? Should I2C devices use objects, since you can't scan for them? Thanks, Myles

3 11

build service results for r4675
by coreboot information 25 Sep '09

25 Sep '09

Dear coreboot readers! This is the automatic build system of coreboot. The developer "rminnich" checked in revision 4675 to the coreboot repository. This caused the following changes: Change Log: Trivial fixups to get this board further along. Signed-off-by: Ronald G. Minnich <rminnich(a)gmail.com> Acked-by: Ronald G. Minnich <rminnich(a)gmail.com> Build Log: Compilation of embeddedplanet:ep405pc is still broken See the error log at http://qa.coreboot.org/log_buildbrd.php?revision=4675&device=ep405pc&vendor… Compilation of motorola:sandpointx3_altimus_mpc7410 is still broken See the error log at http://qa.coreboot.org/log_buildbrd.php?revision=4675&device=sandpointx3_al… Compilation of totalimpact:briq is still broken See the error log at http://qa.coreboot.org/log_buildbrd.php?revision=4675&device=briq&vendor=to… If something broke during this checkin please be a pain in rminnich's neck until the issue is fixed. If this issue is not fixed within 24h the revision should be backed out. Best regards, coreboot automatic build system

1 0

[BuildROM] r276 - in buildrom-devel: . packages/mkelfimage
by svn＠coreboot.org 25 Sep '09

25 Sep '09

Author: myles Date: 2009-09-25 21:55:13 +0200 (Fri, 25 Sep 2009) New Revision: 276 Modified: buildrom-devel/Makefile buildrom-devel/packages/mkelfimage/mkelfimage.mk Log: Add $(HOSTTOOLS) to the payload and update mkelfimage.mk so that you can do: mkelfimage-clean make payload and the correct thing happens. Trivial. Signed-off-by: Myles Watson <mylesgw(a)gmail.com> Acked-by: Myles Watson <mylesgw(a)gmail.com> Modified: buildrom-devel/Makefile =================================================================== --- buildrom-devel/Makefile 2009-09-23 03:07:31 UTC (rev 275) +++ buildrom-devel/Makefile 2009-09-25 19:55:13 UTC (rev 276) @@ -106,7 +106,7 @@ # by coreboot, for v3 it is built by us, so we have ifdef magic here ifeq ($(CONFIG_COREBOOT_V2),y) -rom: $(HOSTTOOLS-y) payload $(COREBOOT-y) +rom: payload $(COREBOOT-y) else # If compressing the payload in v3, parse the elf and tell lar to compress it. @@ -115,7 +115,7 @@ LAR_PAYLOAD_FLAGS-y=-a -e LAR_PAYLOAD_FLAGS-$(CONFIG_USE_LZMA) += -C lzma -rom: $(HOSTTOOLS-y) payload $(COREBOOT-y) +rom: payload $(COREBOOT-y) @ mkdir -p $(shell dirname $(TARGET_ROM_FILE)) @ cp $(CBV3_OUTPUT) $(TARGET_ROM_FILE) @ $(STAGING_DIR)/bin/lar $(LAR_PAYLOAD_FLAGS-y) $(TARGET_ROM_FILE) $(PAYLOAD_TARGET):normal/payload @@ -133,7 +133,7 @@ custom: custom-clean: -payload: $(DEPENDS-y) $(PAYLOAD_TARGET) +payload: $(HOSTTOOLS-y) $(DEPENDS-y) $(PAYLOAD_TARGET) extract: $(PKG_extract) Modified: buildrom-devel/packages/mkelfimage/mkelfimage.mk =================================================================== --- buildrom-devel/packages/mkelfimage/mkelfimage.mk 2009-09-23 03:07:31 UTC (rev 275) +++ buildrom-devel/packages/mkelfimage/mkelfimage.mk 2009-09-25 19:55:13 UTC (rev 276) @@ -57,8 +57,9 @@ mkelfimage-clean: @ rm -f $(MKELFIMAGE_STAMP_DIR)/.configured + @ rm -f $(STAGING_DIR)/sbin/mkelfImage ifneq ($(wildcard $(MKELFIMAGE_SRC_DIR)/Makefile),) - $(MAKE) -C $(MKELFIMAGE_SRC_DIR) clean + @ $(MAKE) -C $(MKELFIMAGE_SRC_DIR) clean endif mkelfimage-distclean:

1 0

[v2] r4675 - trunk/coreboot-v2/src/mainboard/dell/s1850
by svn＠coreboot.org 25 Sep '09

25 Sep '09

Author: rminnich Date: 2009-09-25 21:53:59 +0200 (Fri, 25 Sep 2009) New Revision: 4675 Added: trunk/coreboot-v2/src/mainboard/dell/s1850/s1850_fixups.c Removed: trunk/coreboot-v2/src/mainboard/dell/s1850/s2850_fixups.c Modified: trunk/coreboot-v2/src/mainboard/dell/s1850/Options.lb trunk/coreboot-v2/src/mainboard/dell/s1850/auto.c Log: Trivial fixups to get this board further along. Signed-off-by: Ronald G. Minnich <rminnich(a)gmail.com> Acked-by: Ronald G. Minnich <rminnich(a)gmail.com> Modified: trunk/coreboot-v2/src/mainboard/dell/s1850/Options.lb =================================================================== --- trunk/coreboot-v2/src/mainboard/dell/s1850/Options.lb 2009-09-25 19:09:23 UTC (rev 4674) +++ trunk/coreboot-v2/src/mainboard/dell/s1850/Options.lb 2009-09-25 19:53:59 UTC (rev 4675) @@ -183,10 +183,10 @@ default CONFIG_CONSOLE_SERIAL8250=1 ## Select the serial console baud rate -default CONFIG_TTYS0_BAUD=115200 +#default CONFIG_TTYS0_BAUD=115200 #default CONFIG_TTYS0_BAUD=57600 #default CONFIG_TTYS0_BAUD=38400 -#default CONFIG_TTYS0_BAUD=19200 +default CONFIG_TTYS0_BAUD=19200 #default CONFIG_TTYS0_BAUD=9600 #default CONFIG_TTYS0_BAUD=4800 #default CONFIG_TTYS0_BAUD=2400 Modified: trunk/coreboot-v2/src/mainboard/dell/s1850/auto.c =================================================================== --- trunk/coreboot-v2/src/mainboard/dell/s1850/auto.c 2009-09-25 19:09:23 UTC (rev 4674) +++ trunk/coreboot-v2/src/mainboard/dell/s1850/auto.c 2009-09-25 19:53:59 UTC (rev 4675) @@ -13,14 +13,13 @@ #include "lib/ramtest.c" #include "southbridge/intel/i82801er/i82801er_early_smbus.c" #include "northbridge/intel/e7520/raminit.h" -#include "superio/winbond/w83627hf/w83627hf.h" +#include "superio/nsc/pc8374/pc8374_early_serial.c" #include "cpu/x86/lapic/boot_cpu.c" #include "cpu/x86/mtrr/earlymtrr.c" #include "debug.c" #include "watchdog.c" #include "reset.c" -#include "s2850_fixups.c" -#include "superio/winbond/w83627hf/w83627hf_early_init.c" +#include "s1850_fixups.c" #include "northbridge/intel/e7520/memory_initialized.c" #include "cpu/x86/bist.h" @@ -28,8 +27,7 @@ #define SIO_GPIO_BASE 0x680 #define SIO_XBUS_BASE 0x4880 -#define CONSOLE_SERIAL_DEV PNP_DEV(0x2e, W83627HF_SP1) -#define HIDDEN_SERIAL_DEV PNP_DEV(0x2e, W83627HF_SP2) +#define CONSOLE_SERIAL_DEV PNP_DEV(0x2e, PC8374_SP1) #define DEVPRES_CONFIG ( \ DEVPRES_D0F0 | \ @@ -201,11 +199,9 @@ } } /* Setup the console */ + mainboard_set_ich5(); bmc_foad(); - outb(0x87,0x2e); - outb(0x87,0x2e); - pnp_write_config(CONSOLE_SERIAL_DEV, 0x24, 0x84 | (1 << 6)); - w83627hf_enable_dev(CONSOLE_SERIAL_DEV, CONFIG_TTYS0_BASE); + pc8374_enable_serial(CONSOLE_SERIAL_DEV, CONFIG_TTYS0_BASE); uart_init(); console_init(); Copied: trunk/coreboot-v2/src/mainboard/dell/s1850/s1850_fixups.c (from rev 4645, trunk/coreboot-v2/src/mainboard/dell/s1850/s2850_fixups.c) =================================================================== --- trunk/coreboot-v2/src/mainboard/dell/s1850/s1850_fixups.c (rev 0) +++ trunk/coreboot-v2/src/mainboard/dell/s1850/s1850_fixups.c 2009-09-25 19:53:59 UTC (rev 4675) @@ -0,0 +1,40 @@ +#include <arch/romcc_io.h> + +static void mch_reset(void) +{ + return; +} + + + +static void mainboard_set_e7520_pll(unsigned bits) +{ + return; +} + + +static void mainboard_set_e7520_leds(void) +{ + return; +} + +static void mainboard_set_ich5(void) +{ + /* coma is 0x3f8 , comb is 0x2f8*/ + pci_write_config8(PCI_DEV(0, 0x1f, 0), 0xe0, 0x10); + /* enable decoding of various devices */ + pci_write_config16(PCI_DEV(0, 0x1f, 0), 0xe6, 0x140f); + /* 1M flash */ + pci_write_config8(PCI_DEV(0, 0x1f, 0), 0xe3, 0xc0); + pci_write_config8(PCI_DEV(0, 0x1f, 0), 0xf0, 0x0); + /* disable certain devices -- see data sheet -- this is from + * dell settings via lspci + * Note that they leave SMBUS disabled -- 8f6f. + * we leave it enabled and visible in config space -- 8f66 + */ + pci_write_config16(PCI_DEV(0, 0x1f, 0), 0xf2, 0x8f66); +} + + + + Deleted: trunk/coreboot-v2/src/mainboard/dell/s1850/s2850_fixups.c =================================================================== --- trunk/coreboot-v2/src/mainboard/dell/s1850/s2850_fixups.c 2009-09-25 19:09:23 UTC (rev 4674) +++ trunk/coreboot-v2/src/mainboard/dell/s1850/s2850_fixups.c 2009-09-25 19:53:59 UTC (rev 4675) @@ -1,23 +0,0 @@ -#include <arch/romcc_io.h> - -static void mch_reset(void) -{ - return; -} - - - -static void mainboard_set_e7520_pll(unsigned bits) -{ - return; -} - - -static void mainboard_set_e7520_leds(void) -{ - return; -} - - - -

1 0

build service results for r4674
by coreboot information 25 Sep '09

25 Sep '09

Dear coreboot readers! This is the automatic build system of coreboot. The developer "myles" checked in revision 4674 to the coreboot repository. This caused the following changes: Change Log: Fix build of romcc boards. Invalid option specified: -mcpu=-mcpu=p2 romcc 0.71 released 03 April 2009 Signed-off-by: Myles Watson <mylesgw(a)gmail.com> Acked-by: Myles Watson <mylesgw(a)gmail.com> Build Log: Compilation of embeddedplanet:ep405pc is still broken See the error log at http://qa.coreboot.org/log_buildbrd.php?revision=4674&device=ep405pc&vendor… Compilation of motorola:sandpointx3_altimus_mpc7410 is still broken See the error log at http://qa.coreboot.org/log_buildbrd.php?revision=4674&device=sandpointx3_al… Compilation of totalimpact:briq is still broken See the error log at http://qa.coreboot.org/log_buildbrd.php?revision=4674&device=briq&vendor=to… If something broke during this checkin please be a pain in myles's neck until the issue is fixed. If this issue is not fixed within 24h the revision should be backed out. Best regards, coreboot automatic build system

1 0

← Newer
1
...
10
11
12
13
14
15
16
...
31
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

coreboot September 2009