coreboot April 2009

coreboot@coreboot.org

69 participants
583 discussions

config.g cleanup
by Myles Watson 23 Apr '09

23 Apr '09

This patch cleans up Makefile generation. It removes the coreboot.romfs file since CBFS will eventually be the standard. Before and after attached. Signed-off-by: Myles Watson <mylesgw(a)gmail.com> Thanks, Myles

2 1

[v2] r4197 - trunk/coreboot-v2/util/newconfig
by svn＠coreboot.org 23 Apr '09

23 Apr '09

Author: oxygene Date: 2009-04-23 19:01:37 +0200 (Thu, 23 Apr 2009) New Revision: 4197 Modified: trunk/coreboot-v2/util/newconfig/config.g Log: This patch cleans up Makefile generation. It removes the coreboot.romfs file since CBFS will eventually be the standard. Signed-off-by: Myles Watson <mylesgw(a)gmail.com> Acked-by: Patrick Georgi <patrick.georgi(a)coresystems.de> Modified: trunk/coreboot-v2/util/newconfig/config.g =================================================================== --- trunk/coreboot-v2/util/newconfig/config.g 2009-04-23 14:57:55 UTC (rev 4196) +++ trunk/coreboot-v2/util/newconfig/config.g 2009-04-23 17:01:37 UTC (rev 4197) @@ -2267,17 +2267,10 @@ file.write("include %s/Makefile.settings\n\n" % romimages.keys()[0]) # main rule - file.write("ifeq \"$(CONFIG_CBFS)\" \"1\"\n") file.write("\nall: ") for i in buildroms: - file.write(" %sfs" % i.name) - file.write("\n") - file.write("else") - file.write("\nall: ") - for i in buildroms: file.write(" %s" % i.name) file.write("\n") - file.write("endif\n\n") # cbfstool rules file.write("\ncbfstool:\n\tmkdir -p tools/lzma\n\t$(MAKE) -C $(TOP)/util/cbfstool obj=$(shell pwd)\n\n") @@ -2299,36 +2292,47 @@ file.write("base-clean:\n") file.write("\trm -f romcc*\n\n") + file.write("ifeq \"$(CONFIG_CBFS)\" \"1\"\n\n") + for i in buildroms: - file.write("%s:" % i.name) + file.write("%s: cbfstool" %(i.name)) for j in i.roms: file.write(" %s/coreboot.rom " % j) file.write("\n") - file.write("\t cat ") + + romsize = getoption("ROM_SIZE", image) + + file.write("\n\trm -f %s\n" %(i.name)) + + # build the bootblock here. + file.write("\n\tcat") for j in i.roms: - file.write(" %s/coreboot.rom " % j) - file.write("> %s\n\n" %i.name) - # build the bootblock here as well. - file.write("\n") - file.write("\t cat ") - for j in i.roms: file.write(" %s/coreboot.strip " % j) file.write("> %s.bootblock\n\n" %i.name) - - romsize = getoption("ROM_SIZE", image) - # i.name? That can not be right, can it? - file.write("%sfs: %s cbfstool\n" %(i.name,i.name)); - file.write("\trm -f coreboot.cbfs\n"); - file.write("\t./cbfstool %sfs create %s %s %s.bootblock\n" % (i.name, romsize, bootblocksize, i.name)) - for i in pciroms: - file.write("\tif [ -f coreboot.romfs ]; then ./cbfstool coreboot.romfs add %s pci%04x,%04x.rom 48; fi\n" % (i.name, i.pci_vid, i.pci_did)) - for i in buildroms: + file.write("\t./cbfstool %s create %s %s %s.bootblock\n" + %(i.name, romsize, bootblocksize, i.name)) + for j in pciroms: + file.write("\t./cbfstool %s add %s pci%04x,%04x.rom 48\n" % (i.name, j.name, j.pci_vid, j.pci_did)) for j in i.roms: #failover is a hack that will go away soon. if (j != "failover") and (rommapping[j] != "/dev/null"): - file.write("\tif [ -f %s/cbfs-support ]; then ./cbfstool %sfs add-payload %s %s/payload `cat %s/cbfs-support`; fi\n" % (j, i.name, rommapping[j], j, j)) - file.write("\t ./cbfstool %sfs print\n" % i.name) + file.write("\t./cbfstool %s add-payload %s %s/payload\n" % (i.name, rommapping[j], j,)) + file.write("\t./cbfstool %s print\n" % i.name) + file.write("\n") + file.write("else\n\n") + for i in buildroms: + file.write("%s:" % i.name) + for j in i.roms: + file.write(" %s/coreboot.rom " % j) + file.write("\n") + file.write("\t cat ") + for j in i.roms: + file.write(" %s/coreboot.rom " % j) + file.write("> %s\n\n" %i.name) + + file.write("endif\n\n") + file.write(".PHONY: all clean cbfstool") for i in romimages.keys(): file.write(" %s-clean" % i)

1 0

[v2] r4196 - trunk/util/flashrom
by svn＠coreboot.org 23 Apr '09

23 Apr '09

Author: uwe Date: 2009-04-23 16:57:55 +0200 (Thu, 23 Apr 2009) New Revision: 4196 Modified: trunk/util/flashrom/README trunk/util/flashrom/layout.c Log: Don't duplicate option description in README, the manpage already has that info. Also, additional small cosmetic fix. Signed-off-by: Uwe Hermann <uwe(a)hermann-uwe.de> Acked-by: Uwe Hermann <uwe(a)hermann-uwe.de> Modified: trunk/util/flashrom/README =================================================================== --- trunk/util/flashrom/README 2009-04-23 13:41:12 UTC (rev 4195) +++ trunk/util/flashrom/README 2009-04-23 14:57:55 UTC (rev 4196) @@ -22,32 +22,12 @@ * zlib-devel / zlib1g-dev -Usage ------ +Usage / Options +--------------- - $ flashrom [-rwvEVfLhR] [-c chipname] [-s exclude_start] [-e exclude_end] - [-m [vendor:]part] [-l file.layout] [-i imagename] [file] - -r | --read: read flash and save into file - -w | --write: write file into flash (default when - file is specified) - -v | --verify: verify flash against file - -E | --erase: erase flash device - -V | --verbose: more verbose output - -c | --chip <chipname>: probe only for specified flash chip - -s | --estart <addr>: exclude start position - -e | --eend <addr>: exclude end postion - -m | --mainboard <[vendor:]part>: override mainboard settings - -f | --force: force write without checking image - -l | --layout <file.layout>: read rom layout from file - -i | --image <name>: only flash image name from flash layout - -L | --list-supported: print supported devices - -h | --help: print this help text - -R | --version: print the version (release) +Please see the flashrom(8) manpage. - If no file is specified, then all that happens - is that flash info is dumped and the flash chip is set to writable. - Exit status ----------- Modified: trunk/util/flashrom/layout.c =================================================================== --- trunk/util/flashrom/layout.c 2009-04-23 13:41:12 UTC (rev 4195) +++ trunk/util/flashrom/layout.c 2009-04-23 14:57:55 UTC (rev 4196) @@ -108,8 +108,7 @@ */ if (!strcasecmp(mainboard_vendor, lb_vendor) && !strcasecmp(mainboard_part, lb_part)) { - printf_debug("This firmware image matches " - "this motherboard.\n"); + printf_debug("This firmware image matches this mainboard.\n"); } else { if (force) { printf("WARNING: This firmware image does not "

1 0

[v2] r4195 - trunk/coreboot-v2/targets/hp/dl145_g3
by svn＠coreboot.org 23 Apr '09

23 Apr '09

Author: myles Date: 2009-04-23 15:41:12 +0200 (Thu, 23 Apr 2009) New Revision: 4195 Added: trunk/coreboot-v2/targets/hp/dl145_g3/VERSION Log: Add VERSION to hp/dl145_g3. Trivial. Signed-off-by: Myles Watson <mylesgw(a)gmail.com> Acked-by: Myles Watson <mylesgw(a)gmail.com> Added: trunk/coreboot-v2/targets/hp/dl145_g3/VERSION =================================================================== --- trunk/coreboot-v2/targets/hp/dl145_g3/VERSION (rev 0) +++ trunk/coreboot-v2/targets/hp/dl145_g3/VERSION 2009-04-23 13:41:12 UTC (rev 4195) @@ -0,0 +1 @@ +_dl145_g3

1 0

show the version of code we are running
by Bao, Zheng 23 Apr '09

23 Apr '09

Sometimes when we debug the code, we need to know which version we are working on. Zheng Signed-off-by: Zheng Bao <zheng.bao(a)amd.com> Index: src/boot/hardwaremain.c =================================================================== --- src/boot/hardwaremain.c (revision 4080) +++ src/boot/hardwaremain.c (working copy) @@ -58,7 +58,7 @@ post_code(0x39); - printk_notice("coreboot-%s%s %s %s...\n", + printk_notice("coreboot-%s-r%s %s %s...\n", coreboot_version, coreboot_extra_version, coreboot_build, (boot_complete)?"rebooting":"booting"); Index: src/config/Options.lb =================================================================== --- src/config/Options.lb (revision 4080) +++ src/config/Options.lb (working copy) @@ -103,7 +103,7 @@ comment "coreboot version" end define COREBOOT_EXTRA_VERSION - default "" + default "$(shell if [ -x /usr/bin/svnversion ]; then /usr/bin/svnversion $(TOP); fi)" export used format "\"%s\"" comment "coreboot extra version" Index: src/arch/i386/lib/console.c =================================================================== --- src/arch/i386/lib/console.c (revision 4080) +++ src/arch/i386/lib/console.c (working copy) @@ -30,6 +30,7 @@ static const char console_test[] = "\r\n\r\ncoreboot-" COREBOOT_VERSION + "-r" COREBOOT_EXTRA_VERSION " " COREBOOT_BUILD

3 8

[v2] r4194 - trunk/coreboot-v2/src/config
by svn＠coreboot.org 23 Apr '09

23 Apr '09

Author: hailfinger Date: 2009-04-23 15:05:45 +0200 (Thu, 23 Apr 2009) New Revision: 4194 Modified: trunk/coreboot-v2/src/config/Options.lb Log: This patch hooks up git mirrored svn revisions and adds some error checking to the svnrevision call. If a .svn directory exists in the top level directory and the svnversion utility is available, we use svnversion. Otherwise, if a .git directory exists in the top level directory and the git utility is available, we use git log. Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006(a)gmx.net> Acked-by: Myles Watson <mylesgw(a)gmail.com> Modified: trunk/coreboot-v2/src/config/Options.lb =================================================================== --- trunk/coreboot-v2/src/config/Options.lb 2009-04-23 03:59:33 UTC (rev 4193) +++ trunk/coreboot-v2/src/config/Options.lb 2009-04-23 13:05:45 UTC (rev 4194) @@ -96,8 +96,11 @@ export always comment "Objcopy command" end + +# Try to determine svn revision first. +# If that fails, try last svn revision in git log. define COREBOOT_VERSION - default "2.0.0-r$(shell if [ -f `which svnversion` ]; then svnversion $(TOP); fi)" + default "2.0.0-r$(shell if [ -d $(TOP)/.svn -a -f `which svnversion` ]; then svnversion $(TOP); else if [ -d $(TOP)/.git -a -f `which git` ]; then git --git-dir=/$(TOP)/.git log|grep git-svn-id|cut -f 2 -d@|cut -f 1 -d' '|sort -g|tail -1; fi; fi)" export always format "\"%s\"" comment "coreboot version"

1 0

SeaBIOS and ATA spinup
by Kevin O'Connor 23 Apr '09

23 Apr '09

Hi, Latest SeaBIOS git should now handle the case where SeaBIOS can't find drives because it runs before the drives are ready. The code tries to wait for not-BSY. However, if the ide bus appears to be "floating", then it will stop waiting. Myles - I know you were working around this on your board. Can you test if the code in git works for you? Thanks, -Kevin

2 2

Re: [coreboot] [v2] r4191 - trunk/coreboot-v2/src/config
by Stephan Raue 23 Apr '09

23 Apr '09

Am 23.04.2009 01:27, schrieb svn(a)coreboot.org: > Author: hailfinger > Date: 2009-04-23 01:27:25 +0200 (Thu, 23 Apr 2009) > New Revision: 4191 > > Modified: > trunk/coreboot-v2/src/config/Options.lb > Log: > Sometimes when we debug the code, we need to know which version we are > working on. > Add the svn revision to the coreboot version string. > > Signed-off-by: Zheng Bao<zheng.bao(a)amd.com> > Acked-by: Myles Watson<mylesgw(a)gmail.com> > Acked-by: Carl-Daniel Hailfinger<c-d.hailfinger.devel.2006(a)gmx.net> > > > Modified: trunk/coreboot-v2/src/config/Options.lb > =================================================================== > --- trunk/coreboot-v2/src/config/Options.lb 2009-04-22 23:17:44 UTC (rev 4190) > +++ trunk/coreboot-v2/src/config/Options.lb 2009-04-22 23:27:25 UTC (rev 4191) > @@ -97,7 +97,7 @@ > comment "Objcopy command" > end > define COREBOOT_VERSION > - default "2.0.0" > + default "2.0.0-r$(shell if [ -f `which svnversion` ]; then svnversion $(TOP); fi)" > how i can handle this, when i am provide a source-package downloaded with a very recent svn-program and packaged this to *tar.bz2. when this tar.bz2 is downloaded by any person that have a older svn program he has an error like this: http://subversion.tigris.org/faq.html#working-copy-format-change this is also a "problem" with flashrom Stephan -- ### OpenELEC.tv ### The free and open Mediacenter Distribution 4 you http://www.openelec.tv

3 4

How to support 256M VGA buffer size and [E0000000-F0000000]PCIE-HOLE in coreboot's dev_configure()?
by JasonZhao＠viatech.com.cn 23 Apr '09

23 Apr '09

There are some codes that deal with PCIE-HOLE in device.c: #if CONFIG_PCIE_CONFIGSPACE_HOLE #warning Handle PCIe hole differently... if (base >= 0xf0000000 && base < 0xf4000000) { base = 0xf4000000; } #endif But these code do not work for my case. My case is: PCI-e hole is 0xe0000000~0xf0000000, and VGA buffer size is 256MB. So, if I use the below code (change 0xf000000~f4000000 to 0xe0000000~f0000000) #if CONFIG_PCIE_CONFIGSPACE_HOLE #warning Handle PCIe hole differently... if (base >= 0xe0000000 && base < 0xf0000000) { base = 0xf0000000; } #endif Then at last the whole area 0xf0000000~0xffffffff will be set in to VGA's BAR, which is obviously wrong. Any body has idea about this? Many thanks! -jasonzhao

1 0

continuing some v2 doco
by ron minnich 23 Apr '09

23 Apr '09

attached ron

3 5

← Newer
1
...
13
14
15
16
17
18
19
...
59
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

coreboot April 2009