coreboot April 2009

coreboot@coreboot.org

69 participants
583 discussions

[v2] r4204 - trunk/coreboot-v2/src/boot
by svn＠coreboot.org 24 Apr '09

24 Apr '09

Author: oxygene Date: 2009-04-24 12:23:56 +0200 (Fri, 24 Apr 2009) New Revision: 4204 Modified: trunk/coreboot-v2/src/boot/selfboot.c Log: Another v3-style #ifdef in v2 to kill Signed-off-by: Patrick Georgi <patrick.georgi(a)coresystems.de> Acked-by: Peter Stuge <peter(a)stuge.se> Modified: trunk/coreboot-v2/src/boot/selfboot.c =================================================================== --- trunk/coreboot-v2/src/boot/selfboot.c 2009-04-24 06:32:29 UTC (rev 4203) +++ trunk/coreboot-v2/src/boot/selfboot.c 2009-04-24 10:23:56 UTC (rev 4204) @@ -90,7 +90,7 @@ return -1; switch(algo) { -#ifdef CONFIG_COMPRESSION_LZMA +#if CONFIG_COMPRESSED_PAYLOAD_LZMA==1 case CBFS_COMPRESS_LZMA: { unsigned long ulzma(unsigned char *src, unsigned char *dst); ulzma(src, dst); @@ -98,7 +98,7 @@ } #endif -#ifdef CONFIG_COMPRESSION_NRV2B +#if CONFIG_COMPRESSED_PAYLOAD_NRV2B==1 case CBFS_COMPRESS_NRV2B: { unsigned long unrv2b(u8 *src, u8 *dst, unsigned long *ilen_p); unsigned long tmp;

1 0

[v2] r4203 - in trunk/coreboot-v2/src: boot lib
by svn＠coreboot.org 24 Apr '09

24 Apr '09

Author: oxygene Date: 2009-04-24 08:32:29 +0200 (Fri, 24 Apr 2009) New Revision: 4203 Modified: trunk/coreboot-v2/src/boot/selfboot.c trunk/coreboot-v2/src/lib/cbfs.c Log: These are some really horrible bugs that got through. (and, for the record: no more #ifdef in coreboot. We're not going to have this happen again. If we do have it in v2, let's remove it.) Signed-off-by: Ronald G. Minnich <rminnich(a)gmail.com> Acked-by: Myles Watson <mylesgw(a)gmail.com> Modified: trunk/coreboot-v2/src/boot/selfboot.c =================================================================== --- trunk/coreboot-v2/src/boot/selfboot.c 2009-04-24 06:28:48 UTC (rev 4202) +++ trunk/coreboot-v2/src/boot/selfboot.c 2009-04-24 06:32:29 UTC (rev 4203) @@ -94,6 +94,7 @@ case CBFS_COMPRESS_LZMA: { unsigned long ulzma(unsigned char *src, unsigned char *dst); ulzma(src, dst); + break; } #endif @@ -102,6 +103,7 @@ unsigned long unrv2b(u8 *src, u8 *dst, unsigned long *ilen_p); unsigned long tmp; unrv2b(src, dst, &tmp); + break; } #endif default: Modified: trunk/coreboot-v2/src/lib/cbfs.c =================================================================== --- trunk/coreboot-v2/src/lib/cbfs.c 2009-04-24 06:28:48 UTC (rev 4202) +++ trunk/coreboot-v2/src/lib/cbfs.c 2009-04-24 06:32:29 UTC (rev 4203) @@ -39,7 +39,7 @@ memcpy(dst, src, len); return 0; -#ifdef CONFIG_COMPRESSION_LZMA +#if CONFIG_COMPRESSED_PAYLOAD_LZMA==1 case CBFS_COMPRESS_LZMA: { unsigned long ulzma(unsigned char *src, unsigned char *dst); @@ -48,7 +48,7 @@ return 0; #endif -#ifdef CONFIG_COMPRESSION_NRV2B +#if CONFIG_COMPRESSED_PAYLOAD_NRV2B==1 case CBFS_COMPRESS_NRV2B: { unsigned long unrv2b(u8 *src, u8 *dst, unsigned long *ilen_p); unsigned long tmp;

1 0

[v2] r4202 - trunk/coreboot-v2/src/arch/i386/boot
by svn＠coreboot.org 24 Apr '09

24 Apr '09

Author: oxygene Date: 2009-04-24 08:28:48 +0200 (Fri, 24 Apr 2009) New Revision: 4202 Modified: trunk/coreboot-v2/src/arch/i386/boot/tables.c Log: Change the behaviour of the ACPI generating code so it only writes at most one full ACPI table. In the cases where both HAVE_LOW_TABLES and HAVE_HIGH_TABLES are enabled, the table is written to high memory, and an RSDP is written to the low memory that points to the high mem one. All other cases work exactly the same way as before. Signed-off-by: Patrick Georgi <patrick.georgi(a)coresystems.de> Acked-by: Myles Watson <mylesgw(a)gmail.com> Modified: trunk/coreboot-v2/src/arch/i386/boot/tables.c =================================================================== --- trunk/coreboot-v2/src/arch/i386/boot/tables.c 2009-04-24 06:27:31 UTC (rev 4201) +++ trunk/coreboot-v2/src/arch/i386/boot/tables.c 2009-04-24 06:28:48 UTC (rev 4202) @@ -112,16 +112,23 @@ /* write them in the rom area because DSDT can be large (8K on epia-m) which * pushes coreboot table out of first 4K if set up in low table area */ -#if HAVE_LOW_TABLES == 1 - rom_table_end = write_acpi_tables(rom_table_end); - rom_table_end = (rom_table_end+1023) & ~1023; -#endif #if HAVE_HIGH_TABLES == 1 + unsigned long high_rsdp=ALIGN(high_table_end, 16); if (high_tables_base) { high_table_end = write_acpi_tables(high_table_end); high_table_end = (high_table_end+1023) & ~1023; } +#if HAVE_LOW_TABLES == 1 + unsigned long rsdt_location=(unsigned long*)(((acpi_rsdp_t*)high_rsdp)->rsdt_address); + acpi_write_rsdp(rom_table_end, rsdt_location); + rom_table_end = ALIGN(ALIGN(rom_table_end, 16) + sizeof(acpi_rsdp_t), 16); #endif +#else +#if HAVE_LOW_TABLES == 1 + rom_table_end = write_acpi_tables(rom_table_end); + rom_table_end = (rom_table_end+1023) & ~1023; +#endif +#endif /* copy the smp block to address 0 */ post_code(0x96);

1 0

[v2] r4201 - trunk/coreboot-v2/src/arch/i386/smp
by svn＠coreboot.org 24 Apr '09

24 Apr '09

Author: oxygene Date: 2009-04-24 08:27:31 +0200 (Fri, 24 Apr 2009) New Revision: 4201 Modified: trunk/coreboot-v2/src/arch/i386/smp/mpspec.c Log: Remove duplicate code. Signed-off-by: Patrick Georgi <patrick.georgi(a)coresystems.de> Acked-by: Myles Watson <mylesgw(a)gmail.com> Modified: trunk/coreboot-v2/src/arch/i386/smp/mpspec.c =================================================================== --- trunk/coreboot-v2/src/arch/i386/smp/mpspec.c 2009-04-23 22:51:56 UTC (rev 4200) +++ trunk/coreboot-v2/src/arch/i386/smp/mpspec.c 2009-04-24 06:27:31 UTC (rev 4201) @@ -28,24 +28,7 @@ /* 16 byte align the table address */ addr = (addr + 0xf) & (~0xf); - v = (void *)addr; - - mf = v; - mf->mpf_signature[0] = '_'; - mf->mpf_signature[1] = 'M'; - mf->mpf_signature[2] = 'P'; - mf->mpf_signature[3] = '_'; - mf->mpf_physptr = (unsigned long)(((char *)v) + SMP_FLOATING_TABLE_LEN); - mf->mpf_length = 1; - mf->mpf_specification = 4; - mf->mpf_checksum = 0; - mf->mpf_feature1 = 0; - mf->mpf_feature2 = 0; - mf->mpf_feature3 = 0; - mf->mpf_feature4 = 0; - mf->mpf_feature5 = 0; - mf->mpf_checksum = smp_compute_checksum(mf, mf->mpf_length*16); - return v; + return smp_write_floating_table_physaddr(addr, addr + SMP_FLOATING_TABLE_LEN); } void *smp_write_floating_table_physaddr(unsigned long addr, unsigned long mpf_physptr)

1 0

[PATCHES] Small cleanup for MP Tables, avoid duplicate ACPI tables
by Patrick Georgi 24 Apr '09

24 Apr '09

Hi, 20090423-1-cleanup-mptable-code.patch removes some duplicate code (see the function right below the one that is changed) 20090423-2-only-write-acpi-table-once.patch changes the behaviour of the ACPI generating code so it only writes at most one full ACPI table. In the cases where both HAVE_LOW_TABLES and HAVE_HIGH_TABLES are enabled, the table is written to high memory, and an RSDP is written to the low memory that points to the high mem one. All other cases should do exactly the same as before. Both are Signed-off-by: Patrick Georgi <patrick.georgi(a)coresystems.de> Patrick

2 1

[flashrom][PATCH] support for MX25L3235D
by stephan.guilloux＠free.fr 24 Apr '09

24 Apr '09

Hello, Below, a patch to allow MX25L3235D support, from the datasheet. From the datasheets, 3225 and 3237 are also supported. The patch is also available in attachment. Make good use of it ;-) Stephan. Signed-off-by: Stephan Guilloux <stephan.guilloux(a)free.fr> Index: flashrom-support-MX25L3235/flash.h =================================================================== --- flashrom-support-MX25L3235/flash.h (révision 4198) +++ flashrom-support-MX25L3235/flash.h (copie de travail) @@ -285,7 +285,7 @@ #define MX_25L6405 0x2017 /* MX25L3205{,D} */ #define MX_25L12805 0x2018 /* MX25L12805 */ #define MX_25L1635D 0x2415 -#define MX_25L3235D 0x2416 +#define MX_25L3235D 0x5E16 /* MX25L3225D/MX25L3235D/MX25L3237D */ #define MX_29F002B 0x34 #define MX_29F002T 0xB0 #define MX_29LV002CB 0x5A Index: flashrom-support-MX25L3235/flashchips.c =================================================================== --- flashrom-support-MX25L3235/flashchips.c (révision 4198) +++ flashrom-support-MX25L3235/flashchips.c (copie de travail) @@ -841,6 +841,20 @@ { .vendor = "Macronix", + .name = "MX25L3235D", + .manufacture_id = MX_ID, + .model_id = MX_25L3235D, + .total_size = 4096, + .page_size = 256, + .tested = TEST_UNTESTED, + .probe = probe_spi_rdid, + .erase = spi_chip_erase_60_c7, + .write = spi_chip_write, + .read = spi_chip_read, + }, + + { + .vendor = "Macronix", .name = "MX25L6405", .manufacture_id = MX_ID, .model_id = MX_25L6405,

2 1

[v2] r4200 - trunk/util/flashrom
by svn＠coreboot.org 24 Apr '09

24 Apr '09

Author: stuge Date: 2009-04-24 00:51:56 +0200 (Fri, 24 Apr 2009) New Revision: 4200 Modified: trunk/util/flashrom/flash.h trunk/util/flashrom/flashchips.c Log: flashrom: Support MX25L3235D Signed-off-by: Stephan Guilloux <stephan.guilloux(a)free.fr> Acked-by: Peter Stuge <peter(a)stuge.se> Modified: trunk/util/flashrom/flash.h =================================================================== --- trunk/util/flashrom/flash.h 2009-04-23 22:22:47 UTC (rev 4199) +++ trunk/util/flashrom/flash.h 2009-04-23 22:51:56 UTC (rev 4200) @@ -285,7 +285,7 @@ #define MX_25L6405 0x2017 /* MX25L3205{,D} */ #define MX_25L12805 0x2018 /* MX25L12805 */ #define MX_25L1635D 0x2415 -#define MX_25L3235D 0x2416 +#define MX_25L3235D 0x5E16 /* MX25L3225D/MX25L3235D/MX25L3237D */ #define MX_29F002B 0x34 #define MX_29F002T 0xB0 #define MX_29LV002CB 0x5A Modified: trunk/util/flashrom/flashchips.c =================================================================== --- trunk/util/flashrom/flashchips.c 2009-04-23 22:22:47 UTC (rev 4199) +++ trunk/util/flashrom/flashchips.c 2009-04-23 22:51:56 UTC (rev 4200) @@ -841,6 +841,20 @@ { .vendor = "Macronix", + .name = "MX25L3235D", + .manufacture_id = MX_ID, + .model_id = MX_25L3235D, + .total_size = 4096, + .page_size = 256, + .tested = TEST_UNTESTED, + .probe = probe_spi_rdid, + .erase = spi_chip_erase_60_c7, + .write = spi_chip_write, + .read = spi_chip_read, + }, + + { + .vendor = "Macronix", .name = "MX25L6405", .manufacture_id = MX_ID, .model_id = MX_25L6405,

1 0

[v2] r4199 - trunk/util/ectool
by svn＠coreboot.org 24 Apr '09

24 Apr '09

Author: uwe Date: 2009-04-24 00:22:47 +0200 (Fri, 24 Apr 2009) New Revision: 4199 Modified: trunk/util/ectool/Makefile Log: Add 'install' target for ectool (trivial). Signed-off-by: Uwe Hermann <uwe(a)hermann-uwe.de> Acked-by: Uwe Hermann <uwe(a)hermann-uwe.de> Modified: trunk/util/ectool/Makefile =================================================================== --- trunk/util/ectool/Makefile 2009-04-23 18:46:32 UTC (rev 4198) +++ trunk/util/ectool/Makefile 2009-04-23 22:22:47 UTC (rev 4199) @@ -19,16 +19,22 @@ # Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA. # -CC=gcc -CFLAGS=-O2 -Wall -W +CC = gcc +CFLAGS = -O2 -Wall -W +PROGRAM = ectool +INSTALL = /usr/bin/install +PREFIX = /usr/local -all: ectool +all: $(PROGRAM) -ectool: ec.o ectool.o +$(PROGRAM): ec.o ectool.o $(CC) $(CFLAGS) -o $@ $^ +install: $(PROGRAM) + $(INSTALL) $(PROGRAM) $(PREFIX)/sbin + clean: - rm *.o ectool + rm *.o $(PROGRAM) %.o: %.c $(CC) $(CFLAGS) -c $^ -I. -o $@

1 0

cbfstool mk-payload fix
by Myles Watson 23 Apr '09

23 Apr '09

This patch fixes a seg fault in mk-payload due to an uninitialized variable. Signed-off-by: Myles Watson <mylesgw(a)gmail.com> Thanks, Myles

2 2

[v2] r4198 - trunk/coreboot-v2/util/cbfstool/tools
by svn＠coreboot.org 23 Apr '09

23 Apr '09

Author: myles Date: 2009-04-23 20:46:32 +0200 (Thu, 23 Apr 2009) New Revision: 4198 Modified: trunk/coreboot-v2/util/cbfstool/tools/cbfs-mkpayload.c Log: Fix an uninitialized variable. If it didn't end up being zero it sometimes caused a seg fault, sometimes executed somewhere else. Also add an error if the algorithm is unknown. Signed-off-by: Myles Watson <mylesgw(a)gmail.com> Acked-by: Ward Vandewege <ward(a)gnu.org> Modified: trunk/coreboot-v2/util/cbfstool/tools/cbfs-mkpayload.c =================================================================== --- trunk/coreboot-v2/util/cbfstool/tools/cbfs-mkpayload.c 2009-04-23 17:01:37 UTC (rev 4197) +++ trunk/coreboot-v2/util/cbfstool/tools/cbfs-mkpayload.c 2009-04-23 18:46:32 UTC (rev 4198) @@ -191,7 +191,7 @@ int main(int argc, char **argv) { void (*compress) (char *, int, char *, int *); - int algo; + int algo = CBFS_COMPRESS_NONE; char *output = NULL; char *input = NULL; @@ -251,6 +251,9 @@ case CBFS_COMPRESS_LZMA: compress = lzma_compress; break; + default: + fprintf(stderr, "E: Unknown compression algorithm %d!\n", algo); + return -1; } osize = parse_elf(buffer, &obuffer, algo, compress);

1 0

← Newer
1
...
12
13
14
15
16
17
18
...
59
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

coreboot April 2009