coreboot September 2008

coreboot@coreboot.org

59 participants
415 discussions

r3579 - trunk/payloads/libpayload/curses
by svn＠coreboot.org 17 Sep '08

17 Sep '08

Author: stepan Date: 2008-09-17 18:32:17 +0200 (Wed, 17 Sep 2008) New Revision: 3579 Modified: trunk/payloads/libpayload/curses/tinycurses.c Log: This patch adds damage detection to libpayload's tinycurses. This significantly speeds up serial output with large windows. It also adds the function curs_set to enable/disable the cursor (video console only for now) Also, use werase in one place to reduce code duplication. Signed-off-by: Stefan Reinauer <stepan(a)coresystems.de> Acked-by: Jordan Crouse <jordan.crouse(a)amd.com> Modified: trunk/payloads/libpayload/curses/tinycurses.c =================================================================== --- trunk/payloads/libpayload/curses/tinycurses.c 2008-09-12 21:50:57 UTC (rev 3578) +++ trunk/payloads/libpayload/curses/tinycurses.c 2008-09-17 16:32:17 UTC (rev 3579) @@ -3,6 +3,7 @@ * * Copyright (C) 2007 Uwe Hermann <uwe(a)hermann-uwe.de> * Copyright (C) 2008 Ulf Jordan <jordan(a)chalmers.se> + * Copyright (C) 2008 coresystems GmbH * * Redistribution and use in source and binary forms, with or without * modification, are permitted provided that the following conditions @@ -193,7 +194,18 @@ int cbreak(void) { /* TODO */ return 0; } /* D */ int clearok(WINDOW *win, bool flag) { win->_clear = flag; return OK; } // int color_content(short color, short *r, short *g, short *b) {} -// int curs_set(int) {} +int curs_set(int on) +{ + if (curses_flags & F_ENABLE_SERIAL) { + // TODO + } + + if (curses_flags & F_ENABLE_CONSOLE) { + video_console_cursor_enable(on); + } + + return OK; +} // int def_prog_mode(void) {} // int def_shell_mode(void) {} // int delay_output(int) {} @@ -252,7 +264,7 @@ return win; } -int doupdate(void) { /* TODO */ return(*(int *)0); } +int doupdate(void) { /* TODO */ return(0); } // WINDOW * dupwin (WINDOW *) {} /* D */ int echo(void) { SP->_echo = TRUE; return OK; } int endwin(void) @@ -281,7 +293,7 @@ /** Note: Must _not_ be called twice! */ WINDOW *initscr(void) { - int x, y, i; + int i; // newterm(name, stdout, stdin); // def_prog_mode(); @@ -305,12 +317,7 @@ stdscr = newwin(SCREEN_Y, SCREEN_X + 1, 0, 0); // TODO: curscr, newscr? - for (y = 0; y <= stdscr->_maxy; y++) { - for (x = 0; x <= stdscr->_maxx; x++) { - stdscr->_line[y].text[x].chars[0] = ' '; - stdscr->_line[y].text[x].attr = A_NORMAL; - } - } + werase(stdscr); return stdscr; } @@ -473,19 +480,27 @@ return waddstr(win, (char *)&sprintf_tmp); } // int vwscanw (WINDOW *, NCURSES_CONST char *,va_list) {} -// int waddch (WINDOW *, const chtype) {} int waddch(WINDOW *win, const chtype ch) { int code = ERR; // NCURSES_CH_T wch; // SetChar2(wch, ch); + if (win->_line[win->_cury].firstchar == _NOCHANGE || + win->_line[win->_cury].firstchar > win->_curx) + win->_line[win->_cury].firstchar = win->_curx; + win->_line[win->_cury].text[win->_curx].chars[0] = ((ch) & (chtype)A_CHARTEXT); win->_line[win->_cury].text[win->_curx].attr = WINDOW_ATTRS(win); win->_line[win->_cury].text[win->_curx].attr |= ((ch) & (chtype)A_ATTRIBUTES); + + if (win->_line[win->_cury].lastchar == _NOCHANGE || + win->_line[win->_cury].lastchar < win->_curx) + win->_line[win->_cury].lastchar = win->_curx; + win->_curx++; // FIXME // if (win && (waddch_nosync(win, wch) != ERR)) { @@ -507,6 +522,10 @@ if (n < 0) n = strlen(astr); + if (win->_line[win->_cury].firstchar == _NOCHANGE || + win->_line[win->_cury].firstchar > win->_curx) + win->_line[win->_cury].firstchar = win->_curx; + while ((n-- > 0) && (*str != '\0')) { // while (*str != '\0') { win->_line[win->_cury].text[win->_curx].chars[0] = *str++; @@ -521,6 +540,11 @@ // break; // } } + + if (win->_line[win->_cury].lastchar == _NOCHANGE || + win->_line[win->_cury].lastchar < win->_curx) + win->_line[win->_cury].lastchar = win->_curx; + return code; } int wattr_on(WINDOW *win, attr_t at, void *opts GCC_UNUSED) @@ -603,6 +627,9 @@ win->_line[y].text[x].chars[0] = ' '; win->_line[y].text[x].attr = WINDOW_ATTRS(win); } + // Should we check instead? + win->_line[y].firstchar = 0; + win->_line[y].lastchar = win->_maxx; } return OK; } @@ -681,12 +708,16 @@ for (y = 0; y <= win->_maxy; y++) { + if (win->_line[y].firstchar == _NOCHANGE) + continue; + /* Position the serial cursor */ if (curses_flags & F_ENABLE_SERIAL) - serial_set_cursor(win->_begy + y, win->_begx); + serial_set_cursor(win->_begy + y, win->_begx + + win->_line[y].firstchar); - for (x = 0; x <= win->_maxx; x++) { + for (x = win->_line[y].firstchar; x <= win->_line[y].lastchar; x++) { attr_t attr = win->_line[y].text[x].attr; unsigned int c = @@ -734,6 +765,7 @@ } serial_putchar(ch); + } c = SWAP_RED_BLUE(c); @@ -768,8 +800,16 @@ video_console_putc(win->_begy + y, win->_begx + x, c); } } + win->_line[y].firstchar = _NOCHANGE; + win->_line[y].lastchar = _NOCHANGE; } + if (curses_flags & F_ENABLE_SERIAL) + serial_set_cursor(win->_begy + win->_cury, win->_begx + win->_curx); + + if (curses_flags & F_ENABLE_CONSOLE) + video_console_set_cursor(win->_begx + win->_curx, win->_begy + win->_cury); + return OK; } int wprintw(WINDOW *win, const char *fmt, ...) @@ -813,29 +853,49 @@ // int wscanw (WINDOW *, NCURSES_CONST char *,...) {} int wscrl(WINDOW *win, int n) { + int x, y; + if (!win->_scroll) return ERR; - if (n != 0) { - int x, y; + if (n == 0) + return OK; - for (y = 0; y <= (win->_maxy - n); y++) { - for (x = 0; x <= win->_maxx; x++) { + for (y = 0; y <= (win->_maxy - n); y++) { + win->_line[y].firstchar = win->_line[y + n].firstchar; + win->_line[y].lastchar = win->_line[y + n].lastchar; + for (x = 0; x <= win->_maxx; x++) { + if ((win->_line[y].text[x].chars[0] != win->_line[y + n].text[x].chars[0]) || + (win->_line[y].text[x].attr != win->_line[y + n].text[x].attr)) { + if (win->_line[y].firstchar == _NOCHANGE) + win->_line[y].firstchar = x; + + win->_line[y].lastchar = x; + win->_line[y].text[x].chars[0] = win->_line[y + n].text[x].chars[0]; win->_line[y].text[x].attr = win->_line[y + n].text[x].attr; } } + } - for (y = (win->_maxy+1 - n); y <= win->_maxy; y++) { - for (x = 0; x <= win->_maxx; x++) { + for (y = (win->_maxy+1 - n); y <= win->_maxy; y++) { + for (x = 0; x <= win->_maxx; x++) { + if ((win->_line[y].text[x].chars[0] != ' ') || + (win->_line[y].text[x].attr != A_NORMAL)) { + if (win->_line[y].firstchar == _NOCHANGE) + win->_line[y].firstchar = x; + + win->_line[y].lastchar = x; + win->_line[y].text[x].chars[0] = ' '; win->_line[y].text[x].attr = A_NORMAL; } } + } - // _nc_scroll_window(win, n, win->_regtop, win->_regbottom, win->_nc_bkgd); - // _nc_synchook(win); - } + // _nc_scroll_window(win, n, win->_regtop, win->_regbottom, win->_nc_bkgd); + // _nc_synchook(win); + return OK; } int wsetscrreg(WINDOW *win, int top, int bottom)

1 0

r864 - coreboot-v3/southbridge/amd/cs5536
by svn＠coreboot.org 17 Sep '08

17 Sep '08

Author: rminnich Date: 2008-09-17 18:29:02 +0200 (Wed, 17 Sep 2008) New Revision: 864 Modified: coreboot-v3/southbridge/amd/cs5536/smbus_initram.c Log: EMERGENCY patch for a stupid typo. This code won't compile without these includes. Signed-off-by: Ronald G. Minnich <rminnich(a)gmail.com> Acked-by: Ronald G. Minnich <rminnich(a)gmail.com> Modified: coreboot-v3/southbridge/amd/cs5536/smbus_initram.c =================================================================== --- coreboot-v3/southbridge/amd/cs5536/smbus_initram.c 2008-09-17 02:19:59 UTC (rev 863) +++ coreboot-v3/southbridge/amd/cs5536/smbus_initram.c 2008-09-17 16:29:02 UTC (rev 864) @@ -19,7 +19,9 @@ #include <types.h> #include <console.h> +#include <globalvars.h> #include <io.h> +#include <cpu.h> #include "cs5536.h" #define SMBUS_ERROR -1

1 0

[PATCH] libpayload - damage detection for tinycurses
by Stefan Reinauer 17 Sep '08

17 Sep '08

See patch. -- coresystems GmbH • Brahmsstr. 16 • D-79104 Freiburg i. Br. Tel.: +49 761 7668825 • Fax: +49 761 7664613 Email: info(a)coresystems.de • http://www.coresystems.de/ Registergericht: Amtsgericht Freiburg • HRB 7656 Geschäftsführer: Stefan Reinauer • Ust-IdNr.: DE245674866 This patch adds damage detection to libpayload's tinycurses. This significantly speeds up serial output with large windows. It also adds the function curs_set to enable/disable the cursor (video console only for now) Also, use werase in one place to reduce code duplication. Signed-off-by: Stefan Reinauer <stepan(a)coresystems.de> diff -urN filo-mainstream/libpayload/curses/tinycurses.c filo-coresystems/libpayload/curses/tinycurses.c --- filo-mainstream/libpayload/curses/tinycurses.c 2008-09-12 23:50:57.000000000 +0200 +++ filo-coresystems/libpayload/curses/tinycurses.c 2008-09-16 01:20:24.000000000 +0200 @@ -3,6 +3,7 @@ * * Copyright (C) 2007 Uwe Hermann <uwe(a)hermann-uwe.de> * Copyright (C) 2008 Ulf Jordan <jordan(a)chalmers.se> + * Copyright (C) 2008 coresystems GmbH * * Redistribution and use in source and binary forms, with or without * modification, are permitted provided that the following conditions @@ -193,7 +194,18 @@ int cbreak(void) { /* TODO */ return 0; } /* D */ int clearok(WINDOW *win, bool flag) { win->_clear = flag; return OK; } // int color_content(short color, short *r, short *g, short *b) {} -// int curs_set(int) {} +int curs_set(int on) +{ + if (curses_flags & F_ENABLE_SERIAL) { + // TODO + } + + if (curses_flags & F_ENABLE_CONSOLE) { + video_console_cursor_enable(on); + } + + return OK; +} // int def_prog_mode(void) {} // int def_shell_mode(void) {} // int delay_output(int) {} @@ -252,7 +264,7 @@ return win; } -int doupdate(void) { /* TODO */ return(*(int *)0); } +int doupdate(void) { /* TODO */ return(0); } // WINDOW * dupwin (WINDOW *) {} /* D */ int echo(void) { SP->_echo = TRUE; return OK; } int endwin(void) @@ -281,7 +293,7 @@ /** Note: Must _not_ be called twice! */ WINDOW *initscr(void) { - int x, y, i; + int i; // newterm(name, stdout, stdin); // def_prog_mode(); @@ -305,12 +317,7 @@ stdscr = newwin(SCREEN_Y, SCREEN_X + 1, 0, 0); // TODO: curscr, newscr? - for (y = 0; y <= stdscr->_maxy; y++) { - for (x = 0; x <= stdscr->_maxx; x++) { - stdscr->_line[y].text[x].chars[0] = ' '; - stdscr->_line[y].text[x].attr = A_NORMAL; - } - } + werase(stdscr); return stdscr; } @@ -473,19 +480,27 @@ return waddstr(win, (char *)&sprintf_tmp); } // int vwscanw (WINDOW *, NCURSES_CONST char *,va_list) {} -// int waddch (WINDOW *, const chtype) {} int waddch(WINDOW *win, const chtype ch) { int code = ERR; // NCURSES_CH_T wch; // SetChar2(wch, ch); + if (win->_line[win->_cury].firstchar == _NOCHANGE || + win->_line[win->_cury].firstchar > win->_curx) + win->_line[win->_cury].firstchar = win->_curx; + win->_line[win->_cury].text[win->_curx].chars[0] = ((ch) & (chtype)A_CHARTEXT); win->_line[win->_cury].text[win->_curx].attr = WINDOW_ATTRS(win); win->_line[win->_cury].text[win->_curx].attr |= ((ch) & (chtype)A_ATTRIBUTES); + + if (win->_line[win->_cury].lastchar == _NOCHANGE || + win->_line[win->_cury].lastchar < win->_curx) + win->_line[win->_cury].lastchar = win->_curx; + win->_curx++; // FIXME // if (win && (waddch_nosync(win, wch) != ERR)) { @@ -507,6 +522,10 @@ if (n < 0) n = strlen(astr); + if (win->_line[win->_cury].firstchar == _NOCHANGE || + win->_line[win->_cury].firstchar > win->_curx) + win->_line[win->_cury].firstchar = win->_curx; + while ((n-- > 0) && (*str != '\0')) { // while (*str != '\0') { win->_line[win->_cury].text[win->_curx].chars[0] = *str++; @@ -521,6 +540,11 @@ // break; // } } + + if (win->_line[win->_cury].lastchar == _NOCHANGE || + win->_line[win->_cury].lastchar < win->_curx) + win->_line[win->_cury].lastchar = win->_curx; + return code; } int wattr_on(WINDOW *win, attr_t at, void *opts GCC_UNUSED) @@ -603,6 +627,9 @@ win->_line[y].text[x].chars[0] = ' '; win->_line[y].text[x].attr = WINDOW_ATTRS(win); } + // Should we check instead? + win->_line[y].firstchar = 0; + win->_line[y].lastchar = win->_maxx; } return OK; } @@ -681,12 +708,16 @@ for (y = 0; y <= win->_maxy; y++) { + if (win->_line[y].firstchar == _NOCHANGE) + continue; + /* Position the serial cursor */ if (curses_flags & F_ENABLE_SERIAL) - serial_set_cursor(win->_begy + y, win->_begx); + serial_set_cursor(win->_begy + y, win->_begx + + win->_line[y].firstchar); - for (x = 0; x <= win->_maxx; x++) { + for (x = win->_line[y].firstchar; x <= win->_line[y].lastchar; x++) { attr_t attr = win->_line[y].text[x].attr; unsigned int c = @@ -734,6 +765,7 @@ } serial_putchar(ch); + } c = SWAP_RED_BLUE(c); @@ -768,8 +800,16 @@ video_console_putc(win->_begy + y, win->_begx + x, c); } } + win->_line[y].firstchar = _NOCHANGE; + win->_line[y].lastchar = _NOCHANGE; } + if (curses_flags & F_ENABLE_SERIAL) + serial_set_cursor(win->_begy + win->_cury, win->_begx + win->_curx); + + if (curses_flags & F_ENABLE_CONSOLE) + video_console_set_cursor(win->_begx + win->_curx, win->_begy + win->_cury); + return OK; } int wprintw(WINDOW *win, const char *fmt, ...) @@ -813,29 +853,49 @@ // int wscanw (WINDOW *, NCURSES_CONST char *,...) {} int wscrl(WINDOW *win, int n) { + int x, y; + if (!win->_scroll) return ERR; - if (n != 0) { - int x, y; + if (n == 0) + return OK; + + for (y = 0; y <= (win->_maxy - n); y++) { + win->_line[y].firstchar = win->_line[y + n].firstchar; + win->_line[y].lastchar = win->_line[y + n].lastchar; + for (x = 0; x <= win->_maxx; x++) { + if ((win->_line[y].text[x].chars[0] != win->_line[y + n].text[x].chars[0]) || + (win->_line[y].text[x].attr != win->_line[y + n].text[x].attr)) { + if (win->_line[y].firstchar == _NOCHANGE) + win->_line[y].firstchar = x; + + win->_line[y].lastchar = x; - for (y = 0; y <= (win->_maxy - n); y++) { - for (x = 0; x <= win->_maxx; x++) { win->_line[y].text[x].chars[0] = win->_line[y + n].text[x].chars[0]; win->_line[y].text[x].attr = win->_line[y + n].text[x].attr; } } + } + + for (y = (win->_maxy+1 - n); y <= win->_maxy; y++) { + for (x = 0; x <= win->_maxx; x++) { + if ((win->_line[y].text[x].chars[0] != ' ') || + (win->_line[y].text[x].attr != A_NORMAL)) { + if (win->_line[y].firstchar == _NOCHANGE) + win->_line[y].firstchar = x; + + win->_line[y].lastchar = x; - for (y = (win->_maxy+1 - n); y <= win->_maxy; y++) { - for (x = 0; x <= win->_maxx; x++) { win->_line[y].text[x].chars[0] = ' '; win->_line[y].text[x].attr = A_NORMAL; } } - - // _nc_scroll_window(win, n, win->_regtop, win->_regbottom, win->_nc_bkgd); - // _nc_synchook(win); } + + // _nc_scroll_window(win, n, win->_regtop, win->_regbottom, win->_nc_bkgd); + // _nc_synchook(win); + return OK; } int wsetscrreg(WINDOW *win, int top, int bottom)

2 1

Coreboot v3 producing 4 gigabyte files
by Stephen Crocker 17 Sep '08

17 Sep '08

I am running into the following problem building coreboot v3 for an AMD Geode LX board that my company is developing: Building coreboot v3... CP build/config.h GEN build/build.h BUILD build/coreboot.bootblock cat: write error: No space left on device make[1]: *** [/usr/src/tinygx/buildrom/buildrom-devel/work/coreboot-v3/svn/build/coreboot.bootblock] Error 1 make: *** [/usr/src/tinygx/buildrom/buildrom-devel/work/coreboot-v3/svn/build/coreboot.rom] Error 2 The stage0.init file is 4294967296 bytes and the coreboot.bootblock file is 3940851712 bytes long. The configuration that I am building is derived from the AMD DB800 board, but with an ITE Super I/O instead on the Winbond one. I have attached the .config files from the autobuilder and from coreboot itself. I would be grateful for any insight that can be provided.

3 6

M50FW080 replacement
by Joseph Smith 17 Sep '08

17 Sep '08

Hello, I have someone that is looking for a good replacement for the ST M50FW080. Looks like ST is not manufacturing them any more. The requirements for this replacement needs to be a PLCC32 Intel Compatable FWH. Any recomendations? -- Thanks, Joseph Smith Set-Top-Linux www.settoplinux.org

3 3

Re: [coreboot] v3 parallel port console?
by Joseph Smith 17 Sep '08

17 Sep '08

On Tue, 16 Sep 2008 20:17:36 +0200, Peter Stuge <peter(a)stuge.se> wrote: > Joseph Smith wrote: >> > Joe, I remember you were interested in crazy hardware hacks. >> > Would designing a floppy->parallel port interface (or >> > floppy->serial) fit your bill? >> >> That would be a crazy hardware hack. I don't think it would be too >> dificult considering floppies are basicly serial devices. I'll do >> some research. > > These are the signals: > > http://hardwarebook.info/Internal_Diskdrive > > >> I think the hardest part would be a driver/software able to >> manipulate the floppy port for serial. > > Not so hard, it will just be bit-banging the signals. I would suggest > using 8 output signals, one strobe out and one ack in to increase the > transfer rate. > > The drawbacks are that timing and thus transfer speed will differ > with CPU speed and that it is relatively impractical to drive > communication like this. > > > I'd like to also nominate PS/2 for consideration, it already comes > with a serial transceiver (odd-8-1) and once the superio is > configured, writing one byte should need just a few io instructions. > > http://hardwarebook.info/Keyboard_%286_PC%2C_PS/2%29 > http://hardwarebook.info/AT_Keyboard/Mouse_protocol > and the PORTS file from > http://www.cs.cmu.edu/~ralf/files.html (search for K-P0060) > > 10-16.7 kHz it's kind of slow, but.. > > My vote is for PS/2 also. There's a data and a clk line, so simple. The question is, newer motherboards are not coming with PS/2 ports, only USB (especially BTX). So Carl-Daniel how many of those boards have PS/2? Here is my favorite site to find out what devices have what signals (and pin outs): http://pinouts.ru/ -- Thanks, Joseph Smith Set-Top-Linux www.settoplinux.org

4 12

Via vt8237 bug/romcc segfault
by Alex Mauer 17 Sep '08

17 Sep '08

In trying to use the latest coreboot with my Jetway board, I've run into the following errors: First, in src/southbridge/via/vt8237r/vt8237r.h: vt8237r.h:96.24: Unknown attribute:packed Simple enough to remove the relevant attribute... Then: vt8237r_early_smbus.c:342.62: Junk at end of integer constant The constant here is: #define VT8237S_SPI_MEM_BASE 0xfed02000ULL So I remove the ULL, and now I get a segfault from romcc! Anyone have any idea what's going on here? -Alex Mauer "hawke"

2 1

MICRON is awsome!
by Joseph Smith 17 Sep '08

17 Sep '08

Can I just say MICRON is an awsome company. Many praises to them. Did anyone know that they list SPD dumps for every piece of memory they make? That makes life so much easier when trying to trouble shoot memory and SPD values. I think we should add a link to the wiki. What do you think? http://www.micron.com/support/part_info/spd -- Thanks, Joseph Smith Set-Top-Linux www.settoplinux.org

2 1

the patch for AMD S1G1 processor socket
by Xie, Michael 17 Sep '08

17 Sep '08

<<s1g1_cpu.patch>> <<s1g1_k8.patch>>

2 2

patch: remove static variable from cs5536 smbus function
by ron minnich 17 Sep '08

17 Sep '08

in the cs5536 we have this: int smbus_read_byte(u16 device, u8 address) { static int first_time = 1; if (first_time) { smbus_init(); first_time = 0; } return do_smbus_read_byte(SMBUS_IO_BASE, device, address); } This construct is problematic due to the use of the static; it will not work in CAR mode. It is only an accident that it ever worked at all. This fix proposes the following: 1. mainboard/*/*/initram.c has to provide an spd_init function just as each mainboard provides an spd_read_byte function now. 2. this function is called from sdram_set_spd_registers before any spd functions are used. It does require that we add an spd_init function to mainboards. This addition is very useful, in fact, as many mainboards have I2C hardware that is special and unique to that board that has to be set up (think: I2C mux). I realize it is a bit more inconvenient to require adding this function but I think it is worth it. Signed-off-by: Ronald G. Minnich <rminnich(a)gmail.com> test to build only on dbe62. Testing on real hardware later today. Comments welcome. ron

3 8

← Newer
1
...
24
25
26
27
28
29
30
...
42
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

coreboot September 2008