coreboot September 2008

coreboot@coreboot.org

59 participants
415 discussions

[PATCH] coreinfo: modwin initialization
by Ulf Jordan 24 Sep '08

24 Sep '08

The attached patch fixes an overflow in the erasure of modwin, and removes an unnecessary refresh. Compile and runtime tested with coreinfo+libpayload+coreboot-v3 under QEMU. /ulf

2 1

r3599 - trunk/payloads/coreinfo
by svn＠coreboot.org 24 Sep '08

24 Sep '08

Author: jcrouse Date: 2008-09-24 16:21:02 +0200 (Wed, 24 Sep 2008) New Revision: 3599 Modified: trunk/payloads/coreinfo/coreinfo.c Log: Fix overflow in modwin erase. Do not refresh modwin yet, since it is immediately overwritten by stdscr. Signed-off-by: Ulf Jordan <jordan(a)chalmers.se> Acked-by: Jordan Crouse <jordan.crouse(a)amd.com> Modified: trunk/payloads/coreinfo/coreinfo.c =================================================================== --- trunk/payloads/coreinfo/coreinfo.c 2008-09-24 14:17:02 UTC (rev 3598) +++ trunk/payloads/coreinfo/coreinfo.c 2008-09-24 14:21:02 UTC (rev 3599) @@ -276,14 +276,8 @@ wattrset(modwin, COLOR_PAIR(2)); wattrset(menuwin, COLOR_PAIR(1) | A_BOLD); - for (i = 0; i < SCREEN_Y - 1; i++) { - wmove(modwin, i - 1, 0); - for (j = 0; j < SCREEN_X; j++) - waddch(modwin, ' '); - } + werase(modwin); - wrefresh(modwin); - for (i = 0; i < ARRAY_SIZE(categories); i++) { for (j = 0; j < categories[i].count; j++) categories[i].modules[j]->init();

1 0

[PATCH] libpayload: fix off-by-one in stdscr
by Ulf Jordan 24 Sep '08

24 Sep '08

The attached patch fixes an off-by-one issue in the allocation of stdscr, which lead to alignment and data corruption issues. /ulf

2 1

full stops (was: Re: r229 - in buildrom-devel: config/platforms packages/grub2 packages/roms)
by Paul Menzel 24 Sep '08

24 Sep '08

Dear list, Add missing full stops. Signed-off-by: Paul Menzel <paulepanter(a)users.sourceforge.net> Thanks, Paul

2 1

r3598 - trunk/payloads/libpayload/curses
by svn＠coreboot.org 24 Sep '08

24 Sep '08

Author: jcrouse Date: 2008-09-24 16:17:02 +0200 (Wed, 24 Sep 2008) New Revision: 3598 Modified: trunk/payloads/libpayload/curses/tinycurses.c Log: Adjust width of stdscr to exactly SCREEN_X. This fixes alignment issues due to an extra space sent at end of each line, as well as a data corruption issue, which could result in undefined color pairs being referenced. Signed-off-by: Ulf Jordan <jordan(a)chalmers.se> Acked-by: Jordan Crouse <jordan.crouse(a)amd.com> Modified: trunk/payloads/libpayload/curses/tinycurses.c =================================================================== --- trunk/payloads/libpayload/curses/tinycurses.c 2008-09-24 10:09:03 UTC (rev 3597) +++ trunk/payloads/libpayload/curses/tinycurses.c 2008-09-24 14:17:02 UTC (rev 3598) @@ -314,7 +314,7 @@ // Speaker init? - stdscr = newwin(SCREEN_Y, SCREEN_X + 1, 0, 0); + stdscr = newwin(SCREEN_Y, SCREEN_X, 0, 0); // TODO: curscr, newscr? werase(stdscr);

1 0

[buildrom] [PATCH] s/LinuxBIOS/coreboot/
by Paul Menzel 24 Sep '08

24 Sep '08

Dear list, s/LinuxBIOS/coreboot/ Signed-off-by: Paul Menzel <paulepanter(a)users.sourceforge.net> Thanks, Paul

2 1

r236 - buildrom-devel/config/platforms
by svn＠coreboot.org 24 Sep '08

24 Sep '08

Author: jcrouse Date: 2008-09-24 16:15:45 +0200 (Wed, 24 Sep 2008) New Revision: 236 Modified: buildrom-devel/config/platforms/Config.in Log: buildrom: Add missing full stops. Signed-off-by: Paul Menzel <paulepanter(a)users.sourceforge.net> Acked-by: Jordan Crouse <jordan.crouse(a)amd.com> Modified: buildrom-devel/config/platforms/Config.in =================================================================== --- buildrom-devel/config/platforms/Config.in 2008-09-24 14:13:42 UTC (rev 235) +++ buildrom-devel/config/platforms/Config.in 2008-09-24 14:15:45 UTC (rev 236) @@ -177,7 +177,7 @@ depends on PLATFORM_GEODE default VSA_LEGACY help - Select the SMM handler source to use with Geode platforms + Select the SMM handler source to use with Geode platforms. config VSA_LEGACY bool "Legacy VSA binary from AMD" @@ -212,7 +212,7 @@ default n help Say 'y' here to patch the build to work on an - emulated platform in the AMD SimNow (TM) simulator + emulated platform in the AMD SimNow (TM) simulator. config AMD_R690_HEADLESS bool "Build the R690 platform as headless (without VGA)" @@ -243,6 +243,6 @@ depends on AMD_R690_CUSTOM_VBIOS default "" help - Specify the full pathname for your RS690 video BIOS file + Specify the full pathname for your RS690 video BIOS file. endmenu

1 0

r235 - buildrom-devel/config/platforms
by svn＠coreboot.org 24 Sep '08

24 Sep '08

Author: jcrouse Date: 2008-09-24 16:13:42 +0200 (Wed, 24 Sep 2008) New Revision: 235 Modified: buildrom-devel/config/platforms/Config.in Log: buildrom: s/LinuxBIOS/coreboot/ Signed-off-by: Paul Menzel <paulepanter(a)users.sourceforge.net> Acked-by: Jordan Crouse <jordan.crouse(a)amd.com> Modified: buildrom-devel/config/platforms/Config.in =================================================================== --- buildrom-devel/config/platforms/Config.in 2008-09-23 22:15:47 UTC (rev 234) +++ buildrom-devel/config/platforms/Config.in 2008-09-24 14:13:42 UTC (rev 235) @@ -190,12 +190,12 @@ config BUILD_QEMU - bool "Build QEMU with patches for LinuxBIOS" + bool "Build QEMU with patches for coreboot" depends on PLATFORM_QEMU-X86 default n help Say 'y' here to build a patched version of QEMU to work with - LinuxBIOS. This downloads the correct version and patches it; + coreboot. This downloads the correct version and patches it; it even builds it if you specify the QEMU_CC correctly. config QEMU_CC

1 0

r3597 build service
by coreboot information 24 Sep '08

24 Sep '08

Dear coreboot readers! This is the automated build check service of coreboot. The developer "hailfinger" checked in revision 3597 to the coreboot source repository and caused the following changes: Change Log: Fix up remaining AMD DBM690T autobuild issue. Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006(a)gmx.net> Acked-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006(a)gmx.net> Build Log: Compilation of amd:dbm690t has been fixed Compilation of jetway:j7f24 is still broken See the error log at http://qa.coreboot.org/log_buildbrd.php?revision=3597&device=j7f24&vendor=j… Compilation of via:epia-cn is still broken See the error log at http://qa.coreboot.org/log_buildbrd.php?revision=3597&device=epia-cn&vendor… If something broke during this checkin please be a pain in hailfinger's neck until the issue is fixed. If this issue is not fixed within 24h the revision should be backed out. Best regards, coreboot automatic build system

1 0

r3597 - trunk/coreboot-v2/targets/amd/dbm690t
by svn＠coreboot.org 24 Sep '08

24 Sep '08

Author: hailfinger Date: 2008-09-24 12:09:03 +0200 (Wed, 24 Sep 2008) New Revision: 3597 Modified: trunk/coreboot-v2/targets/amd/dbm690t/Config-abuild.lb Log: Fix up remaining AMD DBM690T autobuild issue. Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006(a)gmx.net> Acked-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006(a)gmx.net> Modified: trunk/coreboot-v2/targets/amd/dbm690t/Config-abuild.lb =================================================================== --- trunk/coreboot-v2/targets/amd/dbm690t/Config-abuild.lb 2008-09-24 03:21:55 UTC (rev 3596) +++ trunk/coreboot-v2/targets/amd/dbm690t/Config-abuild.lb 2008-09-24 10:09:03 UTC (rev 3597) @@ -23,6 +23,7 @@ option ROM_IMAGE_SIZE=0x20000 option XIP_ROM_SIZE=0x20000 option COREBOOT_EXTRA_VERSION=".0-failover" + payload __PAYLOAD__ end buildrom ./coreboot.rom ROM_SIZE "normal" "failover"

1 0

← Newer
1
...
15
16
17
18
19
20
21
...
42
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

coreboot September 2008