coreboot August 2008

coreboot@coreboot.org

64 participants
593 discussions

[PATCH 1/6] libpayload cursor handling
by Stefan Reinauer 19 Aug '08

19 Aug '08

see patch -- coresystems GmbH • Brahmsstr. 16 • D-79104 Freiburg i. Br. Tel.: +49 761 7668825 • Fax: +49 761 7664613 Email: info(a)coresystems.de • http://www.coresystems.de/ Registergericht: Amtsgericht Freiburg • HRB 7656 Geschäftsführer: Stefan Reinauer • Ust-IdNr.: DE245674866 add functions to query cursor position to video layer Signed-off-by: Stefan Reinauer <stepan(a)coresystems.de> Index: include/libpayload.h =================================================================== --- include/libpayload.h (revision 3519) +++ include/libpayload.h (working copy) @@ -120,7 +124,12 @@ void video_console_putc(u8 row, u8 col, unsigned int ch); void video_console_clear(void); void video_console_cursor_enable(int state); +void video_console_get_cursor(unsigned int *x, unsigned int *y, unsigned int *en); +void video_console_set_cursor(unsigned int cursorx, unsigned int cursory); +/* drivers/option.c */ +int get_option(void *dest, char *name); + /* libc/console.c */ void console_init(void); int putchar(int c); Index: drivers/video/video.c =================================================================== --- drivers/video/video.c (revision 3519) +++ drivers/video/video.c (working copy) @@ -141,6 +141,26 @@ video_console_fixup_cursor(); } +void video_console_get_cursor(unsigned int *x, unsigned int *y, unsigned int *en) +{ + *x=0; + *y=0; + *en=0; + + if (console->get_cursor) + console->get_cursor(x, y, en); + + *x = cursorx; + *y = cursory; +} + +void video_console_set_cursor(unsigned int x, unsigned int y) +{ + cursorx = x; + cursory = y; + video_console_fixup_cursor(); +} + int video_console_init(void) { int i;

2 2

r3520 - in trunk/payloads/libpayload: drivers/video include
by svn＠coreboot.org 19 Aug '08

19 Aug '08

Author: stepan Date: 2008-08-19 19:44:49 +0200 (Tue, 19 Aug 2008) New Revision: 3520 Modified: trunk/payloads/libpayload/drivers/video/video.c trunk/payloads/libpayload/include/libpayload.h Log: add functions to query cursor position to video layer Signed-off-by: Stefan Reinauer <stepan(a)coresystems.de> Acked-by: Jordan Crouse <jordan.crouse(a)amd.com> Modified: trunk/payloads/libpayload/drivers/video/video.c =================================================================== --- trunk/payloads/libpayload/drivers/video/video.c 2008-08-19 16:55:05 UTC (rev 3519) +++ trunk/payloads/libpayload/drivers/video/video.c 2008-08-19 17:44:49 UTC (rev 3520) @@ -141,6 +141,26 @@ video_console_fixup_cursor(); } +void video_console_get_cursor(unsigned int *x, unsigned int *y, unsigned int *en) +{ + *x=0; + *y=0; + *en=0; + + if (console->get_cursor) + console->get_cursor(x, y, en); + + *x = cursorx; + *y = cursory; +} + +void video_console_set_cursor(unsigned int x, unsigned int y) +{ + cursorx = x; + cursory = y; + video_console_fixup_cursor(); +} + int video_console_init(void) { int i; Modified: trunk/payloads/libpayload/include/libpayload.h =================================================================== --- trunk/payloads/libpayload/include/libpayload.h 2008-08-19 16:55:05 UTC (rev 3519) +++ trunk/payloads/libpayload/include/libpayload.h 2008-08-19 17:44:49 UTC (rev 3520) @@ -120,7 +120,12 @@ void video_console_putc(u8 row, u8 col, unsigned int ch); void video_console_clear(void); void video_console_cursor_enable(int state); +void video_console_get_cursor(unsigned int *x, unsigned int *y, unsigned int *en); +void video_console_set_cursor(unsigned int cursorx, unsigned int cursory); +/* drivers/option.c */ +int get_option(void *dest, char *name); + /* libc/console.c */ void console_init(void); int putchar(int c);

1 0

[PATCH 6/6] libpayload misc fixes
by Stefan Reinauer 19 Aug '08

19 Aug '08

-- coresystems GmbH • Brahmsstr. 16 • D-79104 Freiburg i. Br. Tel.: +49 761 7668825 • Fax: +49 761 7664613 Email: info(a)coresystems.de • http://www.coresystems.de/ Registergericht: Amtsgericht Freiburg • HRB 7656 Geschäftsführer: Stefan Reinauer • Ust-IdNr.: DE245674866 misc fixes: * give struct memrange a name * add explicit cast. Signed-off-by: Stefan Reinauer <stepan(a)coresystems.de> Index: include/sysinfo.h =================================================================== --- include/sysinfo.h (revision 3519) +++ include/sysinfo.h (working copy) @@ -39,7 +39,7 @@ int n_memranges; - struct { + struct memrange { unsigned long long base; unsigned long long size; } memrange[SYSINFO_MAX_MEM_RANGES]; Index: drivers/options.c =================================================================== --- drivers/options.c (revision 3519) +++ drivers/options.c (working copy) @@ -90,7 +90,7 @@ for ( cmos_entry = (struct cb_cmos_entries*)((unsigned char *)option_table + option_table->header_length); cmos_entry->tag == CB_TAG_OPTION; cmos_entry = (struct cb_cmos_entries*)((unsigned char *)cmos_entry + cmos_entry->size)) { - if (memcmp(cmos_entry->name, name, len)) + if (memcmp((const char*)cmos_entry->name, name, len)) continue; if(get_cmos_value(cmos_entry->bit, cmos_entry->length, dest)) return 1;

2 1

r3519 - trunk/payloads/libpayload/libc
by svn＠coreboot.org 19 Aug '08

19 Aug '08

Author: stepan Date: 2008-08-19 18:55:05 +0200 (Tue, 19 Aug 2008) New Revision: 3519 Modified: trunk/payloads/libpayload/libc/memory.c Log: libpayload: Fix the memcpy functions There was a bit of confusion in the memcpy functions - we could simplify things slightly without having to revert to 8 bit copies on a 32 bit system. Signed-off-by: Jordan Crouse <jordan.crouse(a)amd.com> Acked-by: Stefan Reinauer <stepan(a)coresystems.de> Modified: trunk/payloads/libpayload/libc/memory.c =================================================================== --- trunk/payloads/libpayload/libc/memory.c 2008-08-19 16:53:47 UTC (rev 3518) +++ trunk/payloads/libpayload/libc/memory.c 2008-08-19 16:55:05 UTC (rev 3519) @@ -43,59 +43,41 @@ return s; } -struct along { - unsigned long n; -} __attribute__ ((packed)); - -static void *unaligned_memcpy(void *dst, const void *src, size_t n) -{ - int i, j; - struct along *adst = dst; - const struct along *asrc = src; - - for (i = 0; i < n / sizeof(unsigned long); i++) - adst[i].n = asrc[i].n; - - for (j = 0; j < n % sizeof(unsigned long); j++) - ((unsigned char *)(((unsigned long *)dst) + i))[j] = - ((unsigned char *)(((unsigned long *)src) + i))[j]; - - return (char *)src; -} - void *memcpy(void *dst, const void *src, size_t n) { - int i, j; + int i; - if (((long)dst & (sizeof(long) - 1)) - || ((long)src & (sizeof(long) - 1))) - return unaligned_memcpy(dst, src, n); + for(i = 0; i < n % sizeof(unsigned long); i++) + ((unsigned char *) dst)[i] = ((unsigned char *) src)[i]; - for (i = 0; i < n / sizeof(unsigned long); i++) - ((unsigned long *)dst)[i] = ((unsigned long *)src)[i]; + n -= i; + src += i; + dst += i; - for (j = 0; j < n % sizeof(unsigned long); j++) - ((unsigned char *)(((unsigned long *)dst) + i))[j] = - ((unsigned char *)(((unsigned long *)src) + i))[j]; + for(i = 0; i < n / sizeof(unsigned long); i++) + ((unsigned long *) dst)[i] = ((unsigned long *) src)[i]; - return (char *)src; + return dst; } void *memmove(void *dst, const void *src, size_t n) { - int i, j; + int i; + unsigned long offs; if (src > dst) return memcpy(dst, src, n); - for (j = (n % sizeof(unsigned long)) - 1; j >= 0; j--) - ((unsigned char *)((unsigned long *)dst))[j] = - ((unsigned char *)((unsigned long *)src))[j]; + offs = n - (n % sizeof(unsigned long)); + for (i = (n % sizeof(unsigned long)) - 1; i >= 0; i--) + ((unsigned char *)dst)[i + offs] = + ((unsigned char *)src)[i + offs]; + for (i = n / sizeof(unsigned long) - 1; i >= 0; i--) ((unsigned long *)dst)[i] = ((unsigned long *)src)[i]; - return (char *)src; + return dst; } /**

1 0

r3518 - trunk/payloads/libpayload/libc
by svn＠coreboot.org 19 Aug '08

19 Aug '08

Author: stepan Date: 2008-08-19 18:53:47 +0200 (Tue, 19 Aug 2008) New Revision: 3518 Modified: trunk/payloads/libpayload/libc/ctype.c Log: fix typo in ctype.c Signed-off-by: Stefan Reinauer <stepan(a)coresystems.de> Acked-by: Stefan Reinauer <stepan(a)coresystems.de> Modified: trunk/payloads/libpayload/libc/ctype.c =================================================================== --- trunk/payloads/libpayload/libc/ctype.c 2008-08-18 19:29:41 UTC (rev 3517) +++ trunk/payloads/libpayload/libc/ctype.c 2008-08-19 16:53:47 UTC (rev 3518) @@ -81,7 +81,7 @@ int isspace(int c) { - return (c == ' ' || (c >= '\t' || c <= '\r')); + return (c == ' ' || (c >= '\t' && c <= '\r')); } int isupper(int c)

1 0

Q) FILO : File not found.
by Young-Whan Kim 19 Aug '08

19 Aug '08

Hi~ I made a file system using buildroot. And, I did boot but file not found. System is : hda1 : /boot hda2 : / command is : hda1:/vmlinuz root=/dev/hda2 ...... Message is like following: ------------------------------- boot: hda1:/vmlinuz-2.6.26 hda: LBA48 160GB: ST3160215A Mounted EXT2 filesystem File not found ------------------------------- What's a problem?

3 4

r53 - trunk/filo-0.5/fs
by svn＠coreboot.org 19 Aug '08

19 Aug '08

Author: stepan Date: 2008-08-19 13:12:03 +0200 (Tue, 19 Aug 2008) New Revision: 53 Modified: trunk/filo-0.5/fs/fsys_ext2fs.c Log: fix the fast link bug in filo. Thank you to Jason Wang Modified: trunk/filo-0.5/fs/fsys_ext2fs.c =================================================================== --- trunk/filo-0.5/fs/fsys_ext2fs.c 2008-08-04 21:14:40 UTC (rev 52) +++ trunk/filo-0.5/fs/fsys_ext2fs.c 2008-08-19 11:12:03 UTC (rev 53) @@ -618,7 +618,7 @@ linkbuf[filemax + len] = '\0'; /* Read the symlink data. */ - if (INODE->i_blocks) + if (INODE->i_size>0x3C) { /* Read the necessary blocks, and reset the file pointer. */ len = grub_read (linkbuf, filemax);

1 0

worse is better
by ron minnich 19 Aug '08

19 Aug '08

This is a classic paper from 1991 that I reread from time to time and recommend to anyone in our business. I think it's worth keeping in mind as we continue the work on v3. http://www.dreamsongs.com/WIB.html thanks ron

1 0

[PATCH][RFC] v3: Use less magic values in GeodeLX code
by Carl-Daniel Hailfinger 18 Aug '08

18 Aug '08

Use less magic values in GeodeLX code. This is RFC only. Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006(a)gmx.net> Index: corebootv3-stuff1/arch/x86/geodelx/stage0.S =================================================================== --- corebootv3-stuff1/arch/x86/geodelx/stage0.S (Revision 789) +++ corebootv3-stuff1/arch/x86/geodelx/stage0.S (Arbeitskopie) @@ -180,8 +180,10 @@ movl $CPU_RCONF_DEFAULT, %ecx rdmsr - /* 1MB system memory in write back 1|00100|00. */ - movl $0x010010000, %eax + /* 1 MB system memory (256 blocks of 4kB), + * disable cache between SYSTOP and ROMBASE. + */ + movl $(RCONF_CD(RCONF_DEFAULT_LOWER_DEVRC_LOW_SHIFT)|(256<<RCONF_DEFAULT_LOWER_SYSTOP_SHIFT)), %eax wrmsr /* In LX DCDIS is set after POR which disables the cache..., clear Index: corebootv3-stuff1/arch/x86/geodelx/stage1.c =================================================================== --- corebootv3-stuff1/arch/x86/geodelx/stage1.c (Revision 789) +++ corebootv3-stuff1/arch/x86/geodelx/stage1.c (Arbeitskopie) @@ -26,7 +26,12 @@ static const struct msrinit msr_table[] = { /* Setup access to cache under 1MB. */ - {CPU_RCONF_DEFAULT, {.hi = 0x24fffc02,.lo = 0x1000A000}}, // 0x00000-0xA0000 + {CPU_RCONF_DEFAULT, {.hi = (RCONF_WS(RCONF_DEFAULT_UPPER_ROMRC_SHIFT)| + RCONF_WP(RCONF_DEFAULT_UPPER_ROMRC_SHIFT)| + (0xfffc<<RCONF_DEFAULT_UPPER_ROMBASE_SHIFT)| + RCONF_CD((RCONF_DEFAULT_LOWER_DEVRC_LOW_SHIFT-32))), + .lo = RCONF_CD(RCONF_DEFAULT_LOWER_DEVRC_LOW_SHIFT)| + (0x00A0<<RCONF_DEFAULT_LOWER_SYSTOP_SHIFT)}}, // 0x00000-0xA0000 {CPU_RCONF_A0_BF, {.hi = 0x00000000,.lo = 0x00000000}}, // 0xA0000-0xBFFFF {CPU_RCONF_C0_DF, {.hi = 0x00000000,.lo = 0x00000000}}, // 0xC0000-0xDFFFF {CPU_RCONF_E0_FF, {.hi = 0x00000000,.lo = 0x00000000}}, // 0xE0000-0xFFFFF -- http://www.hailfinger.org/

2 1

r789 - coreboot-v3/lib
by svn＠coreboot.org 18 Aug '08

18 Aug '08

Author: hailfinger Date: 2008-08-18 23:11:05 +0200 (Mon, 18 Aug 2008) New Revision: 789 Modified: coreboot-v3/lib/lar.c Log: Fix unexplained magic value and make it future-proof. Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006(a)gmx.net> Acked-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006(a)gmx.net> Modified: coreboot-v3/lib/lar.c =================================================================== --- coreboot-v3/lib/lar.c 2008-08-18 20:31:34 UTC (rev 788) +++ coreboot-v3/lib/lar.c 2008-08-18 21:11:05 UTC (rev 789) @@ -114,7 +114,7 @@ for (walk = archive->start; (walk < (char *)(archive->start + archive->len - sizeof(struct lar_header))) && (walk >= (char *)archive->start); walk += 16) { - if (strncmp(walk, MAGIC, 8) != 0) + if (strncmp(walk, MAGIC, sizeof(header->magic)) != 0) continue; header = (struct lar_header *)walk;

1 0

← Newer
1
...
22
23
24
25
26
27
28
...
60
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

coreboot August 2008