November 2008 - coreboot - mail.coreboot.org

r3783 build service
by coreboot information Nov. 30, 2008

Nov. 30, 2008

Dear coreboot readers! This is the automated build check service of coreboot. The developer "stepan" checked in revision 3783 to the coreboot source repository and caused the following changes: Change Log: ok, another attempt to the build_opt_tbl problem: - create temp files and move them afterwards - remove dummy option -b - fix usage - drop implicit creation of .c file if no --option is specified. Now let's see if this fixes the issue. :-) We don't want to take 24s instead of 6s to build an image reliably (Yes, yes, I know Tiano takes over 20 minutes) Signed-off-by: Stefan Reinauer <stepan(a)coresystems.de> Acked-by: Stefan Reinauer <stepan(a)coresystems.de> Build Log: Compilation of emulation:qemu-x86 has been fixed If something broke during this checkin please be a pain in stepan's neck until the issue is fixed. If this issue is not fixed within 24h the revision should be backed out. Best regards, coreboot automatic build system

1 0

Any chance I can write to my flash chip without desoldering it?
by FENG Yu Ning Nov. 30, 2008

Nov. 30, 2008

dear flashrom tells me the following info: BIOS Lock Enable: enabled, BIOS Write Enable: disabled, BIOS_CNTL is 0x2 tried to set 0xdc to 0x3 on Intel ICH7/ICH7R failed (WARNING ONLY) Does it mean desoldering is inevitable for writing? yu ning

1 0

r3777 build service
by coreboot information Nov. 30, 2008

Nov. 30, 2008

Dear coreboot readers! This is the automated build check service of coreboot. The developer "oxygene" checked in revision 3777 to the coreboot source repository and caused the following changes: Change Log: This patch fixes the ugly race condition created through build_opt_tbl running twice at the same time, overwriting its output files. This caused a depending rule to produce an object file with no symbols in it. This should silence up the regularly happening build failure messages on the mailing list since we moved to the newer, much faster server. Signed-off-by: Stefan Reinauer <stepan(a)coresystems.de> Signed-off-by: Patrick Georgi <patrick.georgi(a)coresystems.de> Acked-by: Peter Stuge <peter(a)stuge.se> Build Log: Compilation of gigabyte:m57sli has been broken See the error log at http://qa.coreboot.org/log_buildbrd.php?revision=3777&device=m57sli&vendor=… Compilation of via:pc2500e has been broken See the error log at http://qa.coreboot.org/log_buildbrd.php?revision=3777&device=pc2500e&vendor… If something broke during this checkin please be a pain in oxygene's neck until the issue is fixed. If this issue is not fixed within 24h the revision should be backed out. Best regards, coreboot automatic build system

4 7

r3783 - in trunk/coreboot-v2: src/config util/options
by svn＠coreboot.org Nov. 30, 2008

Nov. 30, 2008

Author: stepan Date: 2008-11-30 15:52:46 +0100 (Sun, 30 Nov 2008) New Revision: 3783 Modified: trunk/coreboot-v2/src/config/Config.lb trunk/coreboot-v2/util/options/build_opt_tbl.c Log: ok, another attempt to the build_opt_tbl problem: - create temp files and move them afterwards - remove dummy option -b - fix usage - drop implicit creation of .c file if no --option is specified. Now let's see if this fixes the issue. :-) We don't want to take 24s instead of 6s to build an image reliably (Yes, yes, I know Tiano takes over 20 minutes) Signed-off-by: Stefan Reinauer <stepan(a)coresystems.de> Acked-by: Stefan Reinauer <stepan(a)coresystems.de> Modified: trunk/coreboot-v2/src/config/Config.lb =================================================================== --- trunk/coreboot-v2/src/config/Config.lb 2008-11-29 15:07:15 UTC (rev 3782) +++ trunk/coreboot-v2/src/config/Config.lb 2008-11-30 14:52:46 UTC (rev 3783) @@ -183,7 +183,7 @@ makerule option_table.h option_table.c depends "build_opt_tbl $(MAINBOARD)/cmos.layout" - action "./build_opt_tbl -b --config $(MAINBOARD)/cmos.layout --header option_table.h --option option_table.c" + action "./build_opt_tbl --config $(MAINBOARD)/cmos.layout --header option_table.h --option option_table.c" end if HAVE_OPTION_TABLE Modified: trunk/coreboot-v2/util/options/build_opt_tbl.c =================================================================== --- trunk/coreboot-v2/util/options/build_opt_tbl.c 2008-11-29 15:07:15 UTC (rev 3782) +++ trunk/coreboot-v2/util/options/build_opt_tbl.c 2008-11-30 14:52:46 UTC (rev 3783) @@ -1,6 +1,7 @@ #include <stdio.h> #include <stdlib.h> #include <string.h> +#include <unistd.h> #include <ctype.h> #include <errno.h> #include "../../src/include/pc80/mc146818rtc.h" @@ -10,6 +11,7 @@ #define INPUT_LINE_MAX 256 #define MAX_VALUE_BYTE_LENGTH 64 +#define TMPFILE_TEMPLATE "/tmp/build_opt_tbl_XXXXXX" static unsigned char cmos_table[4096]; @@ -95,16 +97,15 @@ } /* This routine displays the usage options */ -void display_usage(void) +void display_usage(char *name) { - printf("Usage build_opt_table [-b] [--option filename]\n"); - printf(" [--config filename]\n"); - printf(" [--header filename]\n"); - printf("b = build option_table.c\n"); - printf("--option = name of option table output file\n"); - printf("--config = build the definitions table from the given file\n"); - printf("--header = ouput a header file with the definitions\n"); - exit(1); + printf("Usage: %s [--config filename]\n", name); + printf(" [--option filename]\n"); + printf(" [--header filename]\n\n"); + printf("--config = Build the definitions table from the given file.\n"); + printf("--option = Output a C source file with the definitions.\n"); + printf("--header = Ouput a C header file with the definitions.\n"); + exit(1); } @@ -213,6 +214,8 @@ char *option=0; char *header=0; FILE *fp; + int tmpfile; + char tmpfilename[32]; struct cmos_option_table *ct; struct cmos_entries *ce; struct cmos_enums *c_enums, *c_enums_start; @@ -233,39 +236,37 @@ for(i=1;i<argc;i++) { if(argv[i][0]!='-') { - display_usage(); + display_usage(argv[0]); } switch(argv[i][1]) { - case 'b': /* build the table */ - break; case '-': /* data is requested from a file */ switch(argv[i][2]) { case 'c': /* use a configuration file */ if(strcmp(&argv[i][2],"config")) { - display_usage(); + display_usage(argv[0]); } config=argv[++i]; break; case 'o': /* use a cmos definitions table file */ if(strcmp(&argv[i][2],"option")) { - display_usage(); + display_usage(argv[0]); } option=argv[++i]; break; case 'h': /* Output a header file */ if (strcmp(&argv[i][2], "header") != 0) { - display_usage(); + display_usage(argv[0]); } header=argv[++i]; break; default: - display_usage(); + display_usage(argv[0]); break; } break; default: - display_usage(); + display_usage(argv[0]); break; } } @@ -482,52 +483,72 @@ ct->size += (cptr - (char *)(cmos_table + ct->size)); fclose(fp); - /* test if an alternate file is to be created */ + /* See if we want to output a C source file */ if(option) { - if((fp=fopen(option,"w"))==NULL){ - fprintf(stderr, "Error - Can not open %s\n",option); + strcpy(tmpfilename, TMPFILE_TEMPLATE); + tmpfile = mkstemp(tmpfilename); + if(tmpfile == -1) { + perror("Error - Could not create temporary file"); exit(1); } - } - else { /* no, so use the default option_table.c */ - if((fp=fopen("option_table.c","w"))==NULL){ - fprintf(stderr, "Error - Can not open option_table.c\n"); - exit(1); + + if((fp=fdopen(tmpfile,"w"))==NULL){ + perror("Error - Could not open temporary file"); + unlink(tmpfilename); + exit(1); } + + /* write the header */ + if(!fwrite("unsigned char option_table[] = {",1,32,fp)) { + perror("Error - Could not write image file"); + fclose(fp); + unlink(tmpfilename); + exit(1); + } + /* write the array values */ + for(i=0;i<(ct->size-1);i++) { + if(!(i%10)) fwrite("\n\t",1,2,fp); + sprintf(buf,"0x%02x,",cmos_table[i]); + fwrite(buf,1,5,fp); + } + /* write the end */ + sprintf(buf,"0x%02x\n",cmos_table[i]); + fwrite(buf,1,4,fp); + if(!fwrite("};\n",1,3,fp)) { + perror("Error - Could not write image file"); + fclose(fp); + unlink(tmpfilename); + exit(1); + } + + fclose(fp); + if (rename(tmpfilename, option)) { + fprintf(stderr, "Error - Could not write %s: ", option); + perror(NULL); + unlink(tmpfilename); + exit(1); + } } - /* write the header */ - if(!fwrite("unsigned char option_table[] = {",1,32,fp)) { - fprintf(stderr, "Error - Could not write image file\n"); - fclose(fp); - exit(1); - } - /* write the array values */ - for(i=0;i<(ct->size-1);i++) { - if(!(i%10)) fwrite("\n\t",1,2,fp); - sprintf(buf,"0x%02x,",cmos_table[i]); - fwrite(buf,1,5,fp); - } - /* write the end */ - sprintf(buf,"0x%02x",cmos_table[i]); - fwrite(buf,1,4,fp); - if(!fwrite("};\n",1,3,fp)) { - fprintf(stderr, "Error - Could not write image file\n"); - fclose(fp); - exit(1); - } - fclose(fp); - /* See if we also want to output a C header file */ if (header) { struct cmos_option_table *hdr; struct lb_record *ptr, *end; - fp = fopen(header, "w"); + + strcpy(tmpfilename, TMPFILE_TEMPLATE); + tmpfile = mkstemp(tmpfilename); + if(tmpfile == -1) { + perror("Error - Could not create temporary file"); + exit(1); + } + + fp = fdopen(tmpfile, "w"); if (!fp) { - fprintf(stderr, "Error Can not open %s: %s\n", - header, strerror(errno)); + perror("Error - Could not open temporary file"); + unlink(tmpfilename); exit(1); } + /* Get the cmos table header */ hdr = (struct cmos_option_table *)cmos_table; /* Walk through the entry records */ @@ -544,6 +565,8 @@ if (!is_ident((char *)ce->name)) { fprintf(stderr, "Invalid identifier: %s\n", ce->name); + fclose(fp); + unlink(tmpfilename); exit(1); } fprintf(fp, "#define CMOS_VSTART_%s %d\n", @@ -552,6 +575,13 @@ ce->name, ce->length); } fclose(fp); + + if (rename(tmpfilename, header)) { + fprintf(stderr, "Error - Could not write %s: ", header); + perror(NULL); + unlink(tmpfilename); + exit(1); + } } return(0); }

1 0

Resource Allocation in v3
by Myles Watson Nov. 30, 2008

Nov. 30, 2008

This patch has been languishing while I've been trying to hash out the dts stuff. The basic idea of this patch is that it splits resource allocation into three passes: Read Sum Assign This puts code with my mail from last week. It applies to head and compiles. It does a fairly good job on serengeti (the same allocations as before). I haven't tried it on other platforms. Signed-off-by: Myles Watson <mylesgw(a)gmail.com> Thanks, Myles

2 2

r3782 build service
by coreboot information Nov. 29, 2008

Nov. 29, 2008

Dear coreboot readers! This is the automated build check service of coreboot. The developer "stepan" checked in revision 3782 to the coreboot source repository and caused the following changes: Change Log: Copyright update by Jason Wang for freshly written sb600 code. Signed-off-by: Jason Wang<Qingpei.wang(a)amd.com> Reviewed-by: Joe, Bao <Zheng.Bao(a)amd.com> Acked-by: Stefan Reinauer <stepan(a)coresystems.de> Build Log: Compilation of emulation:qemu-x86 has been broken See the error log at http://qa.coreboot.org/log_buildbrd.php?revision=3782&device=qemu-x86&vendo… If something broke during this checkin please be a pain in stepan's neck until the issue is fixed. If this issue is not fixed within 24h the revision should be backed out. Best regards, coreboot automatic build system

1 0

r3782 - trunk/util/flashrom
by svn＠coreboot.org Nov. 29, 2008

Nov. 29, 2008

Author: stepan Date: 2008-11-29 16:07:15 +0100 (Sat, 29 Nov 2008) New Revision: 3782 Modified: trunk/util/flashrom/sb600spi.c Log: Copyright update by Jason Wang for freshly written sb600 code. Signed-off-by: Jason Wang<Qingpei.wang(a)amd.com> Reviewed-by: Joe, Bao <Zheng.Bao(a)amd.com> Acked-by: Stefan Reinauer <stepan(a)coresystems.de> Modified: trunk/util/flashrom/sb600spi.c =================================================================== --- trunk/util/flashrom/sb600spi.c 2008-11-28 23:47:55 UTC (rev 3781) +++ trunk/util/flashrom/sb600spi.c 2008-11-29 15:07:15 UTC (rev 3782) @@ -1,9 +1,9 @@ /* * This file is part of the flashrom project. * - * Copyright (C) 2008 Stefan Wildemann <stefan.wildemann(a)kontron.com> - * Copyright (C) 2008 Claus Gindhart <claus.gindhart(a)kontron.com> - * Copyright (C) 2008 Dominik Geyer <dominik.geyer(a)kontron.com> + * Copyright (C) 2008 Wang Qingpei <Qingpei.Wang(a)amd.com> + * Copyright (C) 2008 Joe Bao <Zheng.Bao(a)amd.com> + * Copyright (C) Adavanced Micro Devices, Inc * * This program is free software; you can redistribute it and/or modify * it under the terms of the GNU General Public License as published by

1 0

[PATCH] flashrom: more accurate debug output and other trival changes
by FENG Yu Ning Nov. 29, 2008

Nov. 29, 2008

For more information, see ich7 spec(order no. 307013) section 21.1.1 . Signed-off-by: FENG yu ning <fengyuning1984(a)gmail.com> Index: flashrom/ichspi.c =================================================================== --- flashrom/ichspi.c (revision 3781) +++ flashrom/ichspi.c (working copy) @@ -77,7 +77,7 @@ #define ICH7_REG_SPIS 0x00 /* 16 Bits */ #define SPIS_SCIP 0x00000001 #define SPIS_CDS 0x00000004 -#define SPIS_FCERR 0x00000008 +#define SPIS_BAS 0x00000008 /* VIA SPI is compatible with ICH7, but maxdata to transfer is 16 bytes. @@ -268,8 +268,8 @@ /* Assemble SPIS */ temp16 = 0; - /* clear error status registers */ - temp16 |= (SPIS_CDS + SPIS_FCERR); + /* clear bits indicating command completion status */ + temp16 |= (SPIS_CDS + SPIS_BAS); REGWRITE16(ICH7_REG_SPIS, temp16); /* Assemble SPIC */ @@ -322,8 +322,8 @@ printf_debug("timeout\n"); } - if ((REGREAD16(ICH7_REG_SPIS) & SPIS_FCERR) != 0) { - printf_debug("Transaction error!\n"); + if ((REGREAD16(ICH7_REG_SPIS) & SPIS_BAS) != 0) { + printf_debug("Access blocked!\n"); return 1; }

1 0

Porting to some platforms
by 孙恭鑫 Nov. 29, 2008

Nov. 29, 2008

Hi, all. I have a 430HX, a 810e, a 815, a Apollo Pro 133A and a KT600 that I want to port coreboot to. Which one is easier to start with since I'm new to coreboot? -------------- Alex 2008-11-26

3 3

flashrom patch for partial flash read
by Stephan GUILLOUX Nov. 29, 2008

Nov. 29, 2008

The goal for this patch is to allow flashrom to read some part of the flash. flashrom arguments are --chunk-start --chunk-size. the result is stored in a chunk-size file. The design intends to provide start and size arguments to the xxx_read functions, so that each can read only <size> bytes from <start> address. Actually, for the READ part, there are still 2 or 3 to modify. If this design is agreed, I'll modify the others too. The same kind of design could be used for the VERIFY and WRITE (more difficult) parts too. I added a generic_read() function to carry out some tests on arguments : int generic_read(struct flashchip *flash, uint8_t *buf, uint32_t start, uint32_t size) { /* some tests here */ if (flash-read == NULL) { memcpy(...); return (0); } else { return (flash->read(...)); } } The design keeps the current buffer size to total_size bytes. This allows exclude_start/end to be applied too. Any comment is welcome. Stephan. Also in attachment for GMail users. Signed-off-by: Stephan Guilloux <mailto:stephan.guilloux@free.fr> Index: flashrom/flash.h =================================================================== --- flashrom/flash.h (revision 3781) +++ flashrom/flash.h (working copy) @@ -74,7 +74,7 @@ int (*probe) (struct flashchip *flash); int (*erase) (struct flashchip *flash); int (*write) (struct flashchip *flash, uint8_t *buf); - int (*read) (struct flashchip *flash, uint8_t *buf); + int (*read) (struct flashchip *flash, uint8_t *buf, uint32_t start, uint32_t size); /* Some flash devices have an additional register space. */ volatile uint8_t *virtual_memory; @@ -464,7 +464,7 @@ int spi_block_erase_52(const struct flashchip *flash, unsigned long addr); int spi_block_erase_d8(const struct flashchip *flash, unsigned long addr); int spi_chip_write(struct flashchip *flash, uint8_t *buf); -int spi_chip_read(struct flashchip *flash, uint8_t *buf); +int spi_chip_read(struct flashchip *flash, uint8_t *buf, uint32_t start, uint32_t size); uint8_t spi_read_status_register(); int spi_disable_blockprotect(void); void spi_byte_program(int address, uint8_t byte); @@ -488,7 +488,7 @@ /* ichspi.c */ int ich_spi_command(unsigned int writecnt, unsigned int readcnt, const unsigned char *writearr, unsigned char *readarr); -int ich_spi_read(struct flashchip *flash, uint8_t * buf); +int ich_spi_read(struct flashchip *flash, uint8_t * buf, uint32_t start, uint32_t size); int ich_spi_write(struct flashchip *flash, uint8_t * buf); /* it87spi.c */ Index: flashrom/spi.c =================================================================== --- flashrom/spi.c (revision 3781) +++ flashrom/spi.c (working copy) @@ -544,17 +544,27 @@ return spi_command(sizeof(cmd), len, cmd, bytes); } -int spi_chip_read(struct flashchip *flash, uint8_t *buf) +int spi_chip_read(struct flashchip *flash, uint8_t *buf, uint32_t start, uint32_t size) { + unsigned int total_size = flash->total_size * 1024; + switch (flashbus) { case BUS_TYPE_IT87XX_SPI: + if ((start != 0) || (size != total_size)) { + printf ("Error: chunks not supported.\n"); + return (1); + } return it8716f_spi_chip_read(flash, buf); case BUS_TYPE_SB600_SPI: + if ((start != 0) || (size != total_size)) { + printf ("Error: chunks not supported.\n"); + return (1); + } return sb600_spi_read(flash, buf); case BUS_TYPE_ICH7_SPI: case BUS_TYPE_ICH9_SPI: case BUS_TYPE_VIA_SPI: - return ich_spi_read(flash, buf); + return ich_spi_read(flash, buf, start, size); default: printf_debug ("%s called, but no SPI chipset/strapping detected\n", Index: flashrom/flashrom.c =================================================================== --- flashrom/flashrom.c (revision 3781) +++ flashrom/flashrom.c (working copy) @@ -46,6 +46,8 @@ int verbose = 0; int fd_mem; +#define UNKNOWN_CHUNK_SIZE 0xffffffff + struct pci_dev *pci_dev_find(uint16_t vendor, uint16_t device) { struct pci_dev *temp; @@ -171,15 +173,41 @@ return flash; } +static int generic_read(struct flashchip *flash, uint8_t *buf, uint32_t chk_start, uint32_t chk_size) +{ + int total_size = flash->total_size * 1024; + + if (chk_start > total_size) { + printf ("Error: Invalid chunk start.\n"); + return (1); + } + + if ((chk_size == 0) || (chk_start + chk_size > total_size)) { + printf ("Error: Invalid chunk size.\n"); + return (1); + } + + if (flash->read == NULL) { + memcpy(buf, (const char *)flash->virtual_memory + chk_start, chk_size); + } else { + if (flash->read(flash, buf, chk_start, chk_size)) { + printf ("ERROR : flash read failed\n"); + return (1); + } + } + return (0); +} + int verify_flash(struct flashchip *flash, uint8_t *buf) { int idx; int total_size = flash->total_size * 1024; uint8_t *buf2 = (uint8_t *) calloc(total_size, sizeof(char)); - if (flash->read == NULL) - memcpy(buf2, (const char *)flash->virtual_memory, total_size); - else - flash->read(flash, buf2); + + if (generic_read(flash, buf2, 0, total_size)) { + printf ("ERROR : verification aborted.\n"); + return (1); + } printf("Verifying flash... "); @@ -280,6 +308,8 @@ {"force", 0, 0, 'f'}, {"layout", 1, 0, 'l'}, {"image", 1, 0, 'i'}, + {"chunk-start", 1, 0, 'S'}, + {"chunk-size", 1, 0, 'N'}, {"list-supported", 0, 0, 'L'}, {"help", 0, 0, 'h'}, {"version", 0, 0, 'R'}, @@ -288,6 +318,8 @@ char *filename = NULL; + unsigned int chunk_start = 0; + unsigned int chunk_size = UNKNOWN_CHUNK_SIZE; unsigned int exclude_start_position = 0, exclude_end_position = 0; // [x,y) char *tempstr = NULL, *tempstr2 = NULL; @@ -329,6 +361,14 @@ tempstr = strdup(optarg); sscanf(tempstr, "%x", &exclude_end_position); break; + case 'S': + tempstr = strdup(optarg); + sscanf(tempstr, "%x", &chunk_start); + break; + case 'N': + tempstr = strdup(optarg); + sscanf(tempstr, "%x", &chunk_size); + break; case 'm': tempstr = strdup(optarg); strtok(tempstr, ":"); @@ -459,22 +499,25 @@ size = flashes[0]->total_size * 1024; buf = (uint8_t *) calloc(size, sizeof(char)); + if (chunk_size == UNKNOWN_CHUNK_SIZE) + chunk_size = size - chunk_start; + if ((image = fopen(filename, "w")) == NULL) { perror(filename); exit(1); } printf("Force reading flash... "); - if (!flashes[0]->read) - memcpy(buf, (const char *)flashes[0]->virtual_memory, size); - else - flashes[0]->read(flashes[0], buf); + if (generic_read(flashes[0], buf + chunk_start, chunk_start, chunk_size)) { + fclose(image); + exit (1); + } if (exclude_end_position - exclude_start_position > 0) memset(buf + exclude_start_position, 0, exclude_end_position - exclude_start_position); - fwrite(buf, sizeof(char), size, image); + fwrite(buf + chunk_start, sizeof(char), chunk_size, image); fclose(image); printf("done.\n"); free(buf); @@ -546,21 +589,25 @@ printf("done.\n"); exit(0); } else if (read_it) { + printf("Reading flash... "); if ((image = fopen(filename, "w")) == NULL) { perror(filename); exit(1); } - printf("Reading flash... "); - if (flash->read == NULL) - memcpy(buf, (const char *)flash->virtual_memory, size); - else - flash->read(flash, buf); + if (chunk_size == UNKNOWN_CHUNK_SIZE) + chunk_size = size - chunk_start; + + if (generic_read(flash, buf + chunk_start, chunk_start, chunk_size)) { + fclose(image); + exit(1); + } + if (exclude_end_position - exclude_start_position > 0) memset(buf + exclude_start_position, 0, exclude_end_position - exclude_start_position); - fwrite(buf, sizeof(char), size, image); + fwrite(buf + chunk_start, sizeof(char), chunk_size, image); fclose(image); printf("done.\n"); } else { @@ -620,7 +667,7 @@ } if (verify_it) - ret |= verify_flash(flash, buf); + ret |= verify_flash(flash, buf); #ifdef __FreeBSD__ close(io_fd); Index: flashrom/ichspi.c =================================================================== --- flashrom/ichspi.c (revision 3781) +++ flashrom/ichspi.c (working copy) @@ -545,18 +545,26 @@ return 0; } -int ich_spi_read(struct flashchip *flash, uint8_t * buf) +int ich_spi_read(struct flashchip *flash, uint8_t * buf, uint32_t start, uint32_t size) { int i, rc = 0; - int total_size = flash->total_size * 1024; int page_size = flash->page_size; int maxdata = 64; + int page_start; + int page_nbr; + if ((start % page_size) || (size % page_size)) { + printf ("Error: start/size must be page aligned (page=%d bytes).\n", page_size); + return (1); + } + page_start = start / page_size; + page_nbr = size / page_size; + if (flashbus == BUS_TYPE_VIA_SPI) { maxdata = 16; } - for (i = 0; (i < total_size / page_size) && (rc == 0); i++) { + for (i = page_start; (i < page_nbr) && (rc == 0); i++) { rc = ich_spi_read_page(flash, (void *)(buf + i * page_size), i * page_size, maxdata); }

1 0