coreboot January 2008

coreboot@coreboot.org

79 participants
347 discussions

Start a nNew thread

proposal to enable running vsa in geode northbridge
by ron minnich 25 Jan '08

25 Jan '08

Attached. It's pretty simple and short and untested :-) ron

2 3

r562 - coreboot-v3/northbridge/amd/geodelx
by svn＠coreboot.org 25 Jan '08

25 Jan '08

Author: rminnich Date: 2008-01-26 04:45:13 +0100 (Sat, 26 Jan 2008) New Revision: 562 Modified: coreboot-v3/northbridge/amd/geodelx/vsmsetup.c Log: This is a cosmetic change. LAR names don't start with / . Signed-off-by: Ronald G. Minnich <rminnich(a)gmail.com> Acked-by: Ronald G. Minnich <rminnich(a)gmail.com> Modified: coreboot-v3/northbridge/amd/geodelx/vsmsetup.c =================================================================== --- coreboot-v3/northbridge/amd/geodelx/vsmsetup.c 2008-01-26 03:40:00 UTC (rev 561) +++ coreboot-v3/northbridge/amd/geodelx/vsmsetup.c 2008-01-26 03:45:13 UTC (rev 562) @@ -182,7 +182,7 @@ } init_archive(&archive); - if (find_file(&archive, "/blob/vsa", &file)){ + if (find_file(&archive, "blob/vsa", &file)){ printk(BIOS_ERR, "NO VSA found!\n"); return; }

1 0

r561 - in coreboot-v3: arch/x86 include lib northbridge/amd/geodelx
by svn＠coreboot.org 25 Jan '08

25 Jan '08

Author: rminnich Date: 2008-01-26 04:40:00 +0100 (Sat, 26 Jan 2008) New Revision: 561 Modified: coreboot-v3/arch/x86/stage1.c coreboot-v3/include/lar.h coreboot-v3/lib/lar.c coreboot-v3/northbridge/amd/geodelx/vsmsetup.c Log: This change will support stage2 running LAR files. The initial example is running the VSA in the geode lx northbridge. It builds but is not tested. lar.h: make LAR functions SHARED lar.c: make process_file non-static (i.e. global) vsmsetup.c: modify to use LAR functions. stage1.c: new function, init_archive, which is SHARED and will set up the initial archive struct. Note that some work remains. The use of unsigned longs and unsigned shorts should be changed to u32/u16 as Carl-Daniel has pointed out, Because this change requires changes elsewhere I am not including them in this patch. Signed-off-by: Ronald G. Minnich <rminnich(a)gmail.com> Acked-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006(a)gmx.net> Modified: coreboot-v3/arch/x86/stage1.c =================================================================== --- coreboot-v3/arch/x86/stage1.c 2008-01-24 21:54:22 UTC (rev 560) +++ coreboot-v3/arch/x86/stage1.c 2008-01-26 03:40:00 UTC (rev 561) @@ -50,7 +50,21 @@ post_code(POST_STAGE1_ENABLE_ROM); } +void init_archive(struct mem_file *archive) +{ + // FIXME this should be defined in the VPD area + // but NOT IN THE CODE. + /* The len field starts behind the reset vector on x86. + * The start is not correct for all platforms. sc520 will + * need some hands on here. + */ + archive->len = *(u32 *)0xfffffff4; + archive->start =(void *)(0UL-archive->len); + + // FIXME check integrity + +} /* until we get rid of elf */ int legacy(struct mem_file *archive, char *name, void *where, struct lb_memory *mem) { @@ -121,19 +135,8 @@ // location and size of image. - // FIXME this should be defined in the VPD area - // but NOT IN THE CODE. + init_archive(&archive); - /* The len field starts behind the reset vector on x86. - * The start is not correct for all platforms. sc520 will - * need some hands on here. - */ - archive.len = *(u32 *)0xfffffff4; - archive.start =(void *)(0UL-archive.len); - - // FIXME check integrity - - // find first initram if (check_normal_boot_flag()) { printk(BIOS_DEBUG, "Choosing normal boot.\n"); Modified: coreboot-v3/include/lar.h =================================================================== --- coreboot-v3/include/lar.h 2008-01-24 21:54:22 UTC (rev 560) +++ coreboot-v3/include/lar.h 2008-01-26 03:40:00 UTC (rev 561) @@ -51,6 +51,7 @@ #define LAR_H #include <types.h> +#include <shared.h> #define MAGIC "LARCHIVE" #define MAX_PATHLEN 1024 @@ -82,11 +83,15 @@ }; /* Prototypes. */ -int find_file(const struct mem_file *archive, const char *filename, struct mem_file *result); -int copy_file(const struct mem_file *archive, const char *filename, void *where); -int run_file(const struct mem_file *archive, const char *filename, void *where); -int execute_in_place(const struct mem_file *archive, const char *filename); -int run_address(void *f); -void *load_file(const struct mem_file *archive, const char *filename); -void *load_file_segments(const struct mem_file *archive, const char *filename); +/* architecture-defined */ +SHARED(init_archive, void, struct mem_file *); +/* architecture-independent */ +SHARED(find_file, int, const struct mem_file *archive, const char *filename, struct mem_file *result); +SHARED(copy_file, int, const struct mem_file *archive, const char *filename, void *where); +SHARED(run_file, int, const struct mem_file *archive, const char *filename, void *where); +SHARED(execute_in_place, int, const struct mem_file *archive, const char *filename); +SHARED(run_address, int, void *f); +SHARED(load_file, void *, const struct mem_file *archive, const char *filename); +SHARED(load_file_segments, void *, const struct mem_file *archive, const char *filename); +SHARED(process_file, int, const struct mem_file *archive, void *where); #endif /* LAR_H */ Modified: coreboot-v3/lib/lar.c =================================================================== --- coreboot-v3/lib/lar.c 2008-01-24 21:54:22 UTC (rev 560) +++ coreboot-v3/lib/lar.c 2008-01-26 03:40:00 UTC (rev 561) @@ -145,7 +145,7 @@ return 1; } -static int process_file(const struct mem_file *archive, void *where) +int process_file(const struct mem_file *archive, void *where) { printk(BIOS_SPEW, "LAR: Compression algorithm #%i used\n", archive->compression); /* no compression */ Modified: coreboot-v3/northbridge/amd/geodelx/vsmsetup.c =================================================================== --- coreboot-v3/northbridge/amd/geodelx/vsmsetup.c 2008-01-24 21:54:22 UTC (rev 560) +++ coreboot-v3/northbridge/amd/geodelx/vsmsetup.c 2008-01-26 03:40:00 UTC (rev 561) @@ -29,6 +29,7 @@ #include <device/pci_ids.h> #include <msr.h> #include <amd_geodelx.h> +#include <lar.h> #define VSA2_BUFFER 0x60000 #define VSA2_ENTRY_POINT 0x60020 @@ -169,25 +170,30 @@ void do_vsmbios(void *bios) { - struct device *dev; - unsigned long busdevfn; - unsigned int rom = 0; unsigned char *buf; - unsigned int size = SMM_SIZE * 1024; int i; - unsigned long ilen, olen; + struct mem_file archive; + struct mem_file file; printk(BIOS_ERR, "do_vsmbios\n"); /* clear vsm bios data area */ for (i = 0x400; i < 0x500; i++) { *(volatile unsigned char *)i = 0; } + init_archive(&archive); - rom = (unsigned long) bios; + if (find_file(&archive, "/blob/vsa", &file)){ + printk(BIOS_ERR, "NO VSA found!\n"); + return; + } + + if (process_file(&file, (void *)VSA2_BUFFER)) { + printk(BIOS_ERR, "Processing /blob/vsa failed\n"); + return; + } + buf = (unsigned char *)VSA2_BUFFER; - // FIXME - //olen = unrv2b((u8 *) rom, buf, &ilen); - printk(BIOS_DEBUG, "buf ilen %d olen%d\n", ilen, olen); + printk(BIOS_DEBUG, "buf ilen %d real len %uld\n", file.len, file.reallen); printk(BIOS_DEBUG, "buf %p *buf %d buf[256k] %d\n", buf, buf[0], buf[SMM_SIZE * 1024]); printk(BIOS_DEBUG, "buf[0x20] signature is %x:%x:%x:%x\n", @@ -253,16 +259,16 @@ eax, ebx, ecx, edx); printk(BIOS_DEBUG, "biosint: ebp 0x%lx esp 0x%lx edi 0x%lx esi 0x%lx\n", ebp, esp, edi, esi); - printk(BIOS_DEBUG, "biosint: ip 0x%x cs 0x%x flags 0x%x\n", + printk(BIOS_DEBUG, "biosint: ip 0x%lx cs 0x%lx flags 0x%lx\n", ip, cs, flags); - printk(BIOS_DEBUG, "biosint: gs 0x%x fs 0x%x ds 0x%x es 0x%x\n", + printk(BIOS_DEBUG, "biosint: gs 0x%lx fs 0x%lx ds 0x%lx es 0x%lx\n", gsfs >> 16, gsfs & 0xffff, dses >> 16, dses & 0xffff); // cases in a good compiler are just as good as your own tables. switch (intnumber) { case 0 ... 15: // These are not BIOS service, but the CPU-generated exceptions - printk(BIOS_INFO, "biosint: Oops, exception %u\n", intnumber); + printk(BIOS_INFO, "biosint: Oops, exception %lu\n", intnumber); if (esp < 0x1000) { printk(BIOS_DEBUG, "Stack contents: "); while (esp < 0x1000) { @@ -290,7 +296,7 @@ &ebx, &edx, &ecx, &eax, &flags); break; default: - printk(BIOS_INFO, "BIOSINT: Unsupport int #0x%x\n", intnumber); + printk(BIOS_INFO, "BIOSINT: Unsupport int #0x%lx\n", intnumber); break; } if (ret)

1 0

stage2 access to LAR
by ron minnich 25 Jan '08

25 Jan '08

how does stage 2 access LAR? The mem_file struct is an auto (local) for stage1. void __attribute__((stdcall)) stage1_main(u32 bist) { int ret; struct mem_file archive, result; int elfboot_mem(struct lb_memory *mem, void *where, int size); void *entry; You need that mem_file struct ... how do we get this made available to other functions? Remember, you can't make it global to the file before RAM is turned on ... Just have a global that is assigned once RAM is on? ron

3 2

[patch] 'dist' target for 'flashrom' Makefile
by Martin-Éric Racine 25 Jan '08

25 Jan '08

Greetings, I just implemented release tarball generation (with ChangeLog generation) in the enclosed patch for flashrom's Makefile, diffed against SVN. This required editing the version parsing rule to make it useful for versioning the tarball filename too. Please check if this still produces the desired effect for the -D CFLAG fragment. Best Regards, -- Martin-Éric Racine http://q-funk.iki.fi

5 6

r3077 - trunk/coreboot-v2/targets
by svn＠coreboot.org 25 Jan '08

25 Jan '08

Author: oxygene Date: 2008-01-25 20:31:26 +0100 (Fri, 25 Jan 2008) New Revision: 3077 Modified: trunk/coreboot-v2/targets/buildtarget Log: bsh/ksh-clone and make(1)-syntax don't go well together (unlike 5 lines later where make syntax is emitted into a file) Signed-off-by: Patrick Georgi <patrick(a)georgi-clan.de> Acked-by: Peter Stuge <peter(a)stuge.se> Modified: trunk/coreboot-v2/targets/buildtarget =================================================================== --- trunk/coreboot-v2/targets/buildtarget 2008-01-25 18:28:18 UTC (rev 3076) +++ trunk/coreboot-v2/targets/buildtarget 2008-01-25 19:31:26 UTC (rev 3077) @@ -72,7 +72,7 @@ ld --help | awk '{for (i=1;i<=NF;i++) if ($i ~ /build-id/){n++} }; END {exit n}' build_id=$? if [ $build_id -ge 1 ] ; then - EXTRA_LFLAGS+=" -Wl,--build-id=none" + EXTRA_LFLAGS="$EXTRA_LFLAGS -Wl,--build-id=none" fi for i in $build_dir/Makefile.settings $build_dir/*/Makefile.settings

1 0

[PATCH][v2] buildtarget tries to apply make syntax to shell
by Patrick Georgi 25 Jan '08

25 Jan '08

Hi, see attached patch Regards, Patrick Georgi

2 1

r3076 - in trunk/coreboot-v2/src: arch/i386/boot include/boot
by svn＠coreboot.org 25 Jan '08

25 Jan '08

Author: oxygene Date: 2008-01-25 19:28:18 +0100 (Fri, 25 Jan 2008) New Revision: 3076 Modified: trunk/coreboot-v2/src/arch/i386/boot/coreboot_table.c trunk/coreboot-v2/src/include/boot/coreboot_tables.h Log: This patch adds a new record type for lbtable to provide information about a serial port. If a port is defined in the board configuration, add it to lbtable. Signed-off-by: Patrick Georgi <patrick(a)georgi-clan.de> Acked-by: Peter Stuge <peter(a)stuge.se> Modified: trunk/coreboot-v2/src/arch/i386/boot/coreboot_table.c =================================================================== --- trunk/coreboot-v2/src/arch/i386/boot/coreboot_table.c 2008-01-25 15:08:37 UTC (rev 3075) +++ trunk/coreboot-v2/src/arch/i386/boot/coreboot_table.c 2008-01-25 18:28:18 UTC (rev 3076) @@ -74,6 +74,22 @@ return mem; } +struct lb_serial *lb_serial(struct lb_header *header) +{ +#if defined(TTYS0_BASE) + struct lb_record *rec; + struct lb_serial *serial; + rec = lb_new_record(header); + serial = (struct lb_serial *)rec; + serial->tag = LB_TAG_SERIAL; + serial->size = sizeof(*serial); + serial->ioport = TTYS0_BASE; + return serial; +#else + return header; +#endif +} + struct lb_mainboard *lb_mainboard(struct lb_header *header) { struct lb_record *rec; @@ -406,8 +422,10 @@ * size of the coreboot table. */ - /* Record our motheboard */ + /* Record our motherboard */ lb_mainboard(head); + /* Record the serial port, if present */ + lb_serial(head); /* Record our various random string information */ lb_strings(head); Modified: trunk/coreboot-v2/src/include/boot/coreboot_tables.h =================================================================== --- trunk/coreboot-v2/src/include/boot/coreboot_tables.h 2008-01-25 15:08:37 UTC (rev 3075) +++ trunk/coreboot-v2/src/include/boot/coreboot_tables.h 2008-01-25 18:28:18 UTC (rev 3076) @@ -138,6 +138,13 @@ uint8_t string[0]; }; +#define LB_TAG_SERIAL 0x000f +struct lb_serial { + uint32_t tag; + uint32_t size; + uint16_t ioport; +}; + /* The following structures are for the cmos definitions table */ #define LB_TAG_CMOS_OPTION_TABLE 200 /* cmos header record */

1 0

Patching Config.lb
by Myles Watson 25 Jan '08

25 Jan '08

Jordan, What benefit do we get from patching Config.lb instead of just copying a new one into the directory? It seems like the same thing, only the complete Config.lb would be more human readable. I just thought that as long as you are regenerating those patches, we might want to reconsider how we do it. One of the implications is that now if you switch payloads in buildrom, Coreboot needs to be unpacked again, because the patch won't apply. If we used a new Config.lb, we could just copy over it and run buildtarget again. Myles

4 3

trying to understand the build process of coreboot-v2
by Harald Gutmann 25 Jan '08

25 Jan '08

Hello! As now SPI-Chips with more space than 512kB are supported for the Gigabyte M57SLI-4 Mainboard, i want to build a coreboot image with Linux as Payload. First i tried to do that with buildrom-devel, but i wasn't successful. Buildrom-devel created a payload.elf file (in buildrom-devel/work/coreboot/svn/targets/gigabyte/m57sli/m57sli/payload.elf), which should be a linux-2.6.22.2 image with my current kernel config, but without modules, everything compiled into the kernel. This payload.elf file has a size of about three megabytes. The buildrom tool failed to create a working image, so i tired to build the stuff manually. First i checked out the current coreboot svn tree, and edited the "payload" option in targets/gigabyte/m57sli/Config.lb to point at the payload.elf file which i got from the buildrom tool. I also set the "option ROM_SIZE" to the correct value for 4megabytes. Compilling the image manually worked nearly, at the end i got an error in the fallback directory, where it complains about the image size. Here it is: "objcopy --gap-fill 0xff -O binary coreboot coreboot.strip ./buildrom coreboot.strip coreboot.rom payload 0x20000 0x3f000 ERROR: payload (2956431) + coreboot (131072) - Size is 2829455 bytes larger than ROM size (258048). make: *** [coreboot.rom] Error 1" After that error i had a look to the Makefile in that directory and noticed that there is written the following: "coreboot.rom: coreboot.strip buildrom $(PAYLOAD-1) ./buildrom $< $@ $(PAYLOAD-1) $(ROM_IMAGE_SIZE) $(ROM_SECTION_SIZE)" I just had set the ROM_SIZE in the Config.lb but it seems that here the ROM_SECTION_SIZE is used to generate the image. But at that point i've a (maybe) stupid question: What is the difference between normal/fallback/failover, and are all these 3 images needed? Another quite simple/stupid question is, how do i generate a payload.elf with the correct kernel options by hand? (or are the kernel options not in the payload.elf which was generated by buildrom?) It would be quite easyier for me, if someone would be so nice, and add an article to the Wiki how the procesess for Linux as payload works, manually and with buildrom. Kind regards, Harald Gutmann

3 3

← Newer
1
...
7
8
9
10
11
12
13
...
35
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

coreboot January 2008